linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Inki Dae <daeinki@gmail.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: "moderated list:ARM/S5P EXYNOS AR..."
	<linux-samsung-soc@vger.kernel.org>,
	DRI mailing list <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/2] drm/exynos: mixer: simplify mixer_cfg_rgb_fmt()
Date: Sun, 9 Apr 2017 01:22:13 +0900	[thread overview]
Message-ID: <CAAQKjZPLh14=OXUucyoM+QqFvtYkTg=HoGMwMYiVdX-c+r=kWA@mail.gmail.com> (raw)
In-Reply-To: <7e2db947-882e-6b31-aa57-85ec28b49f0c@math.uni-bielefeld.de>

2017-03-29 20:55 GMT+09:00 Tobias Jakobi <tjakobi@math.uni-bielefeld.de>:
> Hello Daniel,
>
> I'm not getting any response from the Exynos DRM maintainer concerning
> this patch. Since this is just a simple cleanup, and Andrzej has already
> review, could you perhaps merge it through drm-misc?
>

Sorry for late. Confirmed just now. This patch is a trivial thing so
will be merged soon.

Thanks,
Inki Dae

> With best wishes,
> Tobias
>
>
>
> Tobias Jakobi wrote:
>> Convert if-statements to switch statement. Removes
>> duplicated code.
>>
>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>>  drivers/gpu/drm/exynos/exynos_mixer.c | 30 ++++++++----------------------
>>  1 file changed, 8 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
>> index 72143ac..41d0c36 100644
>> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
>> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
>> @@ -382,29 +382,14 @@ static void mixer_cfg_rgb_fmt(struct mixer_context *ctx, unsigned int height)
>>       struct mixer_resources *res = &ctx->mixer_res;
>>       u32 val;
>>
>> -     if (height == 480) {
>> +     switch (height) {
>> +     case 480:
>> +     case 576:
>>               val = MXR_CFG_RGB601_0_255;
>> -     } else if (height == 576) {
>> -             val = MXR_CFG_RGB601_0_255;
>> -     } else if (height == 720) {
>> -             val = MXR_CFG_RGB709_16_235;
>> -             mixer_reg_write(res, MXR_CM_COEFF_Y,
>> -                             (1 << 30) | (94 << 20) | (314 << 10) |
>> -                             (32 << 0));
>> -             mixer_reg_write(res, MXR_CM_COEFF_CB,
>> -                             (972 << 20) | (851 << 10) | (225 << 0));
>> -             mixer_reg_write(res, MXR_CM_COEFF_CR,
>> -                             (225 << 20) | (820 << 10) | (1004 << 0));
>> -     } else if (height == 1080) {
>> -             val = MXR_CFG_RGB709_16_235;
>> -             mixer_reg_write(res, MXR_CM_COEFF_Y,
>> -                             (1 << 30) | (94 << 20) | (314 << 10) |
>> -                             (32 << 0));
>> -             mixer_reg_write(res, MXR_CM_COEFF_CB,
>> -                             (972 << 20) | (851 << 10) | (225 << 0));
>> -             mixer_reg_write(res, MXR_CM_COEFF_CR,
>> -                             (225 << 20) | (820 << 10) | (1004 << 0));
>> -     } else {
>> +             break;
>> +     case 720:
>> +     case 1080:
>> +     default:
>>               val = MXR_CFG_RGB709_16_235;
>>               mixer_reg_write(res, MXR_CM_COEFF_Y,
>>                               (1 << 30) | (94 << 20) | (314 << 10) |
>> @@ -413,6 +398,7 @@ static void mixer_cfg_rgb_fmt(struct mixer_context *ctx, unsigned int height)
>>                               (972 << 20) | (851 << 10) | (225 << 0));
>>               mixer_reg_write(res, MXR_CM_COEFF_CR,
>>                               (225 << 20) | (820 << 10) | (1004 << 0));
>> +             break;
>>       }
>>
>>       mixer_reg_writemask(res, MXR_CFG, val, MXR_CFG_RGB_FMT_MASK);
>>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2017-04-08 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 13:30 [PATCH v2 1/2] drm/exynos: mixer: simplify mixer_cfg_rgb_fmt() Tobias Jakobi
2017-03-10 13:30 ` [PATCH v2 2/2] drm/exynos: mixer: document YCbCr magic numbers Tobias Jakobi
2017-03-10 13:59   ` Andrzej Hajda
2017-03-22 11:18 ` [PATCH v2 1/2] drm/exynos: mixer: simplify mixer_cfg_rgb_fmt() Tobias Jakobi
2017-03-29 11:55 ` Tobias Jakobi
2017-04-08 16:22   ` Inki Dae [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAQKjZPLh14=OXUucyoM+QqFvtYkTg=HoGMwMYiVdX-c+r=kWA@mail.gmail.com' \
    --to=daeinki@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).