From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521AFC433FE for ; Thu, 30 Sep 2021 18:31:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36BD6617E6 for ; Thu, 30 Sep 2021 18:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229582AbhI3Sd0 (ORCPT ); Thu, 30 Sep 2021 14:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbhI3SdZ (ORCPT ); Thu, 30 Sep 2021 14:33:25 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E416CC06176A for ; Thu, 30 Sep 2021 11:31:42 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id v10so25923773edj.10 for ; Thu, 30 Sep 2021 11:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=57Llzgrk8lHt7Xo2P5Ng2+YQoTMIOMCchXp4xSgknMk=; b=qCNHubRpYsl2KShLEgoKcAg1XkM+flFqwpUFpfl2SvYHun9wUbaWdDYiyGjRW2Jsbd VdQPKfO3YnpxBAihCSVu2sOPft8zM0KJl86yBloC1fLvkwYL0S4GdRmD/0hggep9YwD9 M7eYKSXF1d4Kv0w91VICm13eNfB1YVm2D23lLykPv0sObzl+HuVastAApQNKEWHimaQv AMigogxGRcuLGSCvEbq9IsWR/Lk5JMywo3O3KQw8oWHJHJ3NkRLsy1Ii4ldoY8ObOIY8 mD0cGvrtuz/hGR+0Cx6y5rhF0voZzYTfUA/rJNTJTdCqeD2k4AGzWL1Uwpj/sK7tmQE6 tgvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=57Llzgrk8lHt7Xo2P5Ng2+YQoTMIOMCchXp4xSgknMk=; b=ehytu7BAxAgumgbf7Ac69M6Kqa5chY0Tk9A3+pHZrXt3+QyoLDEWPLx5qfepN/JQEP y2J6od/I5khF99T2lm1ZELUcJA9cnoxiAYisALogfFEddhzVp2yUHwmHFrnGeb9Qifyr 5rsupkrbaBexmTa0akwSNIeDYdyKvWEbOoPI80HbvN6NwlKwGD6nGJO6Ur9as+XWkKcE lWkAaBJIc2kgEq9LxkdTlqc8LyakXTz0ob4Law6MIAP+77lxo9WeEmWsTxWj9wP8sHws FkQUlIQH8e5g813GleSFN4yG+ynDy23gGGStLu9gQyYmbp1Vv2fjdMQ8/vrN5okNbWoB w2MA== X-Gm-Message-State: AOAM532bylRTWltOcZgNNsWbiloAMVV/FqcHJ8Fx8uD8dEKjcub4yv5O lOc/A3TGzWBdLo63pJeBYH20SC7XMcuKNO+xJWgong== X-Google-Smtp-Source: ABdhPJzlSNDKjr2XQYyGWvZ6wVqvdu6JiqBsgpApQl0wZaMzJq4PH9as3kJjSkfYWfTwWQP4lOv/sqEpvKhejHkecug= X-Received: by 2002:a17:907:9908:: with SMTP id ka8mr905842ejc.164.1633026701077; Thu, 30 Sep 2021 11:31:41 -0700 (PDT) MIME-Version: 1.0 References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-3-willmcvicker@google.com> In-Reply-To: From: Will McVicker Date: Thu, 30 Sep 2021 11:31:23 -0700 Message-ID: Subject: Re: [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended To: John Stultz Cc: Russell King , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Linus Walleij , Alessandro Zummo , Alexandre Belloni , Thomas Gleixner , Lee Jones , Geert Uytterhoeven , Saravana Kannan , Android Kernel Team , linux-arm-kernel , lkml , Linux Samsung SOC , "open list:COMMON CLK FRAMEWORK" , "open list:GPIO SUBSYSTEM" , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Thanks for the suggestion. That makes sense. I'll look into that for the next version. --Will On Wed, Sep 29, 2021 at 1:46 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 1:01 PM Will McVicker wrote: > > On Tue, Sep 28, 2021 at 8:42 PM John Stultz wrote: > > > On Tue, Sep 28, 2021 at 4:56 PM Will McVicker wrote: > > > > > > > > This allows modules to access the value of timekeeping_suspended without > > > > giving them write access to the variable. > > > > > > > > > > It's important to cover "the why" not "the what" in these commit > > > messages, so you might add a note as to what code will be the user of > > > this (the samsung/clk-pll.c code changed later in this series). > > > > > > thanks > > > -john > > > > Thanks John for the tip. I will try to be better at that in the followup. > > I have to remind myself regularly as well. :) Apologies if my quick > reply above seemed curt (as it does to me re-reading it now). Wasn't > my intent. > > > For this specific patch, I am adding this new API because the Samsung > > PLL driver (drivers/clk/samsung/clk-pll.c) currently is using the > > variable 'timekeeping_suspended' to detect timeouts before the > > clocksource is initialized or timekeeping itself is suspended. My > > patch series aims to modularize the Samsung PLL driver. So to keep the > > driver's functionality intact, I need to add this additional API. > > Sounds good! > > Another small/medium suggestion: Since you're adding a new interface > for non-core users of timekeeping_suspended, it might be good to > switch the other users as well (seems like just > drivers/clk/ti/clkctrl.c and kernel/sched/clock.c), then also remove > the extern in include/linux/timekeeping.h (so there's one consistent > method to access it)? I know it's a sort of scope creep, so apologies > for asking, but it would make the series more attractive if it's not > leaving something for others to clean up later. > > thanks > -john