From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D898C4332F for ; Wed, 29 Sep 2021 20:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 764B861465 for ; Wed, 29 Sep 2021 20:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345266AbhI2UDc (ORCPT ); Wed, 29 Sep 2021 16:03:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345056AbhI2UDb (ORCPT ); Wed, 29 Sep 2021 16:03:31 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E136C061766 for ; Wed, 29 Sep 2021 13:01:49 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id v18so12854629edc.11 for ; Wed, 29 Sep 2021 13:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QVoV53fmEUeXJCW4y56wBFPMYAfyeaHxeC0GyF+IsHY=; b=WFb2peLCM29bT5fbZcRB1U1qwkmqtZpPMoiIUeVEM+cFVB1Pqfaa7JcXjT4vRxCxaE JMZ+Y6UbyxD+/o6VARqaK7WDFv6cdUhWIDwb4YSQTVV4Xd4qJ1++jl7QlH3R3cN4Hhda CMd3R4O/jkL8PK5rvcU5Sc8JC/tYvGThln9yHqwTqZ8MgExUKyFBya7UOiSX9fnjXNs/ 3oQms6XsgLw5dZkH4QZ9aWd32To0Xf/9lPgvK2dRN1LZCdAULaNBTjcl+lpZ2sd75vff fS0VJb3UJy4PvbIjpXj5Lrqinvu4UVhNYmfBmILb9ieH3ZIbeBqkCCcydiKrjYnKe0pZ UIqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QVoV53fmEUeXJCW4y56wBFPMYAfyeaHxeC0GyF+IsHY=; b=C8/ByuMqq6EG6zmwLaby1V1oLoPskAQqsH5NPHCiwqeZZZJp3DV0JXxhoPFQ/uJUaF at+Iws/AbRe3+fwtBcg1r1VzYkXa1MiMFAh7sbmk0gUev/OJR649vxzTcuoCGIhfHLbs LHKm+XqKaKgFUbK5Pu2IdtS3xtTIjgrwbaEmpOhzfhx5irTtiuA7SmTQiRq6SrWEzn/I NvBlu7u1uXhbqVVblCQtUVkSgKe8ftrOv2pV22yFRYe2qmcJLByCC2SR5K8xPvYX8WWM XAaq9xQs3UEBZRcNFmEsO6T8FRCjsMJKb+rqmcdRJV7hA14kCUGk1OhuXOSKi+jPmETZ Vu7Q== X-Gm-Message-State: AOAM531mat2oMvlARA1r294KxpNtwHb2RT/4CgijhmohtHjknnfvrX+7 5DQFv8jXaVVECBSWXp11rLsL1ksETwN4/eIINPcqDQ== X-Google-Smtp-Source: ABdhPJxW/5c5Zm0f6VzlmAE5ubXryikV3fZZQv6MmG3s5nD+j3ke3SZ3s5Of1FQgOZu0GnjUf+fda8e2ZNlPw37L3uQ= X-Received: by 2002:a05:6402:1b8d:: with SMTP id cc13mr2169435edb.235.1632945707418; Wed, 29 Sep 2021 13:01:47 -0700 (PDT) MIME-Version: 1.0 References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-3-willmcvicker@google.com> In-Reply-To: From: Will McVicker Date: Wed, 29 Sep 2021 13:01:31 -0700 Message-ID: Subject: Re: [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended To: John Stultz Cc: Russell King , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Linus Walleij , Alessandro Zummo , Alexandre Belloni , Thomas Gleixner , Lee Jones , Geert Uytterhoeven , Saravana Kannan , Android Kernel Team , linux-arm-kernel , lkml , Linux Samsung SOC , "open list:COMMON CLK FRAMEWORK" , "open list:GPIO SUBSYSTEM" , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Tue, Sep 28, 2021 at 8:42 PM John Stultz wrote: > > On Tue, Sep 28, 2021 at 4:56 PM Will McVicker wrote: > > > > This allows modules to access the value of timekeeping_suspended without > > giving them write access to the variable. > > > > It's important to cover "the why" not "the what" in these commit > messages, so you might add a note as to what code will be the user of > this (the samsung/clk-pll.c code changed later in this series). > > thanks > -john Thanks John for the tip. I will try to be better at that in the followup. For this specific patch, I am adding this new API because the Samsung PLL driver (drivers/clk/samsung/clk-pll.c) currently is using the variable 'timekeeping_suspended' to detect timeouts before the clocksource is initialized or timekeeping itself is suspended. My patch series aims to modularize the Samsung PLL driver. So to keep the driver's functionality intact, I need to add this additional API. --Will