From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20794C2B9F4 for ; Mon, 28 Jun 2021 11:10:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC88F60232 for ; Mon, 28 Jun 2021 11:10:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232791AbhF1LNC (ORCPT ); Mon, 28 Jun 2021 07:13:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232745AbhF1LNC (ORCPT ); Mon, 28 Jun 2021 07:13:02 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC3BEC061574 for ; Mon, 28 Jun 2021 04:10:36 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id x20so18346113ljc.5 for ; Mon, 28 Jun 2021 04:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bWqtZ2im8bhpe7wgbjV8zsEbbfLVDc0iR3ke9Y3lfWw=; b=GWKNCASd9MPmyxEUsoGR9JzIVqWCjK0OSZF1l1oCdifzvEDMqh0KUYe3MV8Dgbr+PA la9gyUtlwDg0n3+3jlE9gokVLM6wdEqMHpYm1GUNKILSnuRdU+RgBU7sRxOUjljpyx1u zKT2T7iMjOJzomPtHeovnBESXt8hdlSg1o9l9GDzfxR/6G/S3tgN1K7+yyCGozJ1EgyI 9PvkiqVsL1bXqLvS7gQ+U/3JwHmPIo1Hy4i7AHzDiPuPyOEXwm7HJstY+KYKcy+at9Yg H1VQ4aM1iq7p8brNaOJS61SqZPEocFRr1bHCErosV2zAZJTQ2DzKJf/Yr1Gt16mOzVxo 1abQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bWqtZ2im8bhpe7wgbjV8zsEbbfLVDc0iR3ke9Y3lfWw=; b=il/lwgJsdsRpQ7F9pOQqFe+MfyPsMiAyk8+Y2LZbcSr2NzOH/qNRyQRLfhMPjLuEVU mcMiACmcEhSw8oKjXsEnsiUwc3RGOsvrYQxwip9+jwqqES6Bn4vNMXgZqW2Fj5egdhpt hZpfODsGlRiCF3SIxdd2AYeBoM5YEtOc7q1szUmHiGBoJQT0NPi/ewVmP9dePMxwRCWY oDy3mXsq0Bil4qopn9wnBb5Qbk0mpJGFdC+fD1CjRxUfoElM5X0sERRxU5lESspWEc2H PiUlpDSLKZOrFB5PcNmLOdx5+hXZWY6gOJx6UHTPuvP0eKZXH0hIQr2g9nFzJYA/ZARV Spdg== X-Gm-Message-State: AOAM533Rf0dr+oQDc46jATDkrjekL1pIsZZ2H7o/QajtLifFwPQkYSDk Rp20M1J67SX9+VCedhE/L6XRU9hNXt3J3VFhbc4AfA== X-Google-Smtp-Source: ABdhPJzyEQpk+qVTQTN61ga94Up2dG17/tdSZ8ryGBxDStAhbzvUPZemkx4xWP9DPdoHPznWcXaHK8zDx3IUoLZtJDU= X-Received: by 2002:a2e:9483:: with SMTP id c3mr19694556ljh.273.1624878635125; Mon, 28 Jun 2021 04:10:35 -0700 (PDT) MIME-Version: 1.0 References: <20210211113309.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid> In-Reply-To: From: Linus Walleij Date: Mon, 28 Jun 2021 13:10:23 +0200 Message-ID: Subject: Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features To: Nicolas Boichat Cc: Andrzej Hajda , Robert Foss , Chun-Kuang Hu , Daniel Vetter , David Airlie , Emil Velikov , Inki Dae , Jernej Skrabec , Jonas Karlman , Joonyoung Shim , Jordan Crouse , Krzysztof Kozlowski , Kyungmin Park , Laurent Pinchart , Maarten Lankhorst , Matthias Brugger , Maxime Ripard , Neil Armstrong , Philipp Zabel , Rajendra Nayak , Rikard Falkeborn , Rob Clark , Sam Ravnborg , Sean Paul , Seung-Woo Kim , Thierry Reding , Thomas Zimmermann , Viresh Kumar , Xin Ji , "open list:DRM PANEL DRIVERS" , freedreno , Linux ARM , MSM , "linux-kernel@vger.kernel.org" , "moderated list:ARM/Mediatek SoC support" , linux-samsung-soc Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat wrote: > On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij wrote: > > > dsi->mode_flags = > > > MIPI_DSI_CLOCK_NON_CONTINUOUS | > > > - MIPI_DSI_MODE_EOT_PACKET; > > > + MIPI_DSI_MODE_NO_EOT_PACKET; > > > > Same, just delete the flag. > > > > These are all just semantic bugs due to the ambiguity of the flags, it is > > possible to provide a Fixes: flag for each file using this flag the wrong way > > but I dunno if it's worth it. > > Wow nice catch. > > I think we should fix all of those _before_ my patch is applied, with > proper Fixes tags so that this can be backported to stable branches, > even if it's a no-op. I can look into it but that may take a bit of > time. This is fixed now, please will you proceed with this patch, because I really like it! Yours, Linus Walleij