From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO Date: Wed, 22 Feb 2017 15:37:37 +0100 Message-ID: References: <1487251636-2480-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1487251636-2480-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1487251636-2480-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> Sender: linux-gpio-owner@vger.kernel.org To: Charles Keepax Cc: Krzysztof Kozlowski , Tomasz Figa , Sylwester Nawrocki , "linux-gpio@vger.kernel.org" , linux-samsung-soc , "linux-kernel@vger.kernel.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" List-Id: linux-samsung-soc@vger.kernel.org On Thu, Feb 16, 2017 at 2:27 PM, Charles Keepax wrote: > If we request a GPIO hog, then gpiochip_add_data will attempt to request > some of its own GPIOs. The driver also uses gpiochip_generic_request > which means that for any GPIO request to succeed the pinctrl needs to be > registered. Currently however the driver registers the GPIO and then the > pinctrl meaning all GPIO hog requests will fail, which then in turn causes > the whole driver to fail probe. Fix this up by ensuring we register the > pinctrl first. Although currently there are no users of GPIO hogs in > mainline there are plenty of Samsung based boards that are widely used > for development purposes of other hardware. Indeed we hit this issue > whilst attaching some additional hardware to an Arndale system. > > Signed-off-by: Charles Keepax > Reviewed-by: Krzysztof Kozlowski > --- > > Changes since v1: > - Updated commit message Patch applied. Will not be visible in -next until after the merge window though. Yours, Linus Walleij