From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3363EC433F5 for ; Thu, 14 Oct 2021 21:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F9A76108B for ; Thu, 14 Oct 2021 21:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbhJNVth (ORCPT ); Thu, 14 Oct 2021 17:49:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbhJNVtg (ORCPT ); Thu, 14 Oct 2021 17:49:36 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B9F6C061570 for ; Thu, 14 Oct 2021 14:47:31 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id x1so5483280iof.7 for ; Thu, 14 Oct 2021 14:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4D2KqVz/grDaUl76s7J9zeGObKQ15bbnSTv7OIZk5vg=; b=aHb1/6TKnQqMhvtJOJF1tVMo8BcJNVRSFTz2VWYibKU9O3GX/MIvY0bW93RHJN+Gww yYW0fGz9LXFulKqY3fcA+8On2SGSH5iyQ+x0VZYh23p7LAOOtKkv6DHZMzYsmCQCisRG q1N2UEHd+BICw52knzA0+JKld6AiYCZIbgOl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4D2KqVz/grDaUl76s7J9zeGObKQ15bbnSTv7OIZk5vg=; b=gAhBA5iAQUZed+ABHpu/MQdSwunUkXByaF4AhXG6WzbquFnQS9a2ehQAPn4JhUznWT 2M0StjhhQUhwAsIO+NIkZXC/+jy9Zkzqfv0MJF4nyjDnh60lgajURoqayUo2CYEs47T5 5JjYHj5PzTiJnIfNiMbDsIzwdQwMeXv7Je1yF/Z291nPrtSRlbEzcRJ7ROtmpZAjWKmV 59KGTGIAWBE5OR19MgDQtD6W+30ZaOmjI0zO41oisO030ZYSYBKidCdojsyYzOCo4203 bQkDtLmYGhjI4IXdxEkImrHiQoW7iPes4KI37fnWv4XNFD/xyQvWhmAwnu89lmx5nUVu HoGw== X-Gm-Message-State: AOAM532+pIocqMbswqBdkaqzIcNqr17p/ft1+y0KnGObtRga+mZ2EZEh ejEFCqkB6AWWlyoQg4dXT4pCImvxpMfkXQ== X-Google-Smtp-Source: ABdhPJyKXk/Mhjcp1UM+edQD5W6FLluNjWQFuNRSdu1yadcj+woURy3xWkA6h61msDmdHdtJVWDMgw== X-Received: by 2002:a6b:7a01:: with SMTP id h1mr1081812iom.55.1634248050751; Thu, 14 Oct 2021 14:47:30 -0700 (PDT) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com. [209.85.166.41]) by smtp.gmail.com with ESMTPSA id ay5sm1972378iob.46.2021.10.14.14.47.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 14:47:30 -0700 (PDT) Received: by mail-io1-f41.google.com with SMTP id e144so5513361iof.3 for ; Thu, 14 Oct 2021 14:47:30 -0700 (PDT) X-Received: by 2002:a6b:f915:: with SMTP id j21mr1122421iog.98.1634247547766; Thu, 14 Oct 2021 14:39:07 -0700 (PDT) MIME-Version: 1.0 References: <20210813195228.2003500-1-mka@chromium.org> In-Reply-To: From: Doug Anderson Date: Thu, 14 Oct 2021 14:38:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v16 0/7] usb: misc: Add onboard_usb_hub driver To: Matthias Kaehlcke Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peter Chen , LKML , Linux USB List , Bastien Nocera , Ravi Chandra Sadineni , Michal Simek , Roger Quadros , Krzysztof Kozlowski , Stephen Boyd , Al Cooper , Al Viro , Alexandre Belloni , Alexandre Torgue , Andrew Lunn , Andrey Zhizhikin , Andy Gross , Arnd Bergmann , Aswath Govindraju , Bjorn Andersson , Catalin Marinas , Dmitry Baryshkov , Dmitry Osipenko , Dong Aisheng , Enric Balletbo i Serra , Fabio Estevam , Fabrice Gasnier , Florian Fainelli , Gregory Clement , Grygorii Strashko , =?UTF-8?Q?Guido_G=C3=BCnther?= , Jagan Teki , Jens Axboe , Johan Hovold , Krzysztof Kozlowski , Lad Prabhakar , Lionel Debieve , Manivannan Sadhasivam , Marek Szyprowski , Mark Brown , =?UTF-8?Q?Martin_J=C3=BCcker?= , Nishanth Menon , Olivier Moysan , Pawel Laszczak , Robert Richter , Russell King , Sebastian Hesselbarth , Shawn Guo , Thomas Gleixner , Tony Lindgren , Vinod Koul , Viresh Kumar , Will Deacon , William Cohen , Linux ARM , linux-arm-msm , linux-omap , linux-samsung-soc , =?UTF-8?Q?=C5=81ukasz_Stelmach?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi, On Tue, Sep 21, 2021 at 10:09 AM Matthias Kaehlcke wrote= : > > Hi Greg, > > are there any actions pending or can this land in usb-testing? > > I confirmed that this series can be rebased on top of v5.15-rc2 > without conflicts. I'm quite interested to know what the next action items are, too. This is one of the very few patches we have for trogdor (excluding MIPI camera, which is a long story) that we're carrying downstream, so I'm keenly interested in making sure it's unblocked (if, indeed, it's blocked on anything). If folks feel that this needs more review eyes before landing again then I'll try to find some time in the next week or two. If it's just waiting for the merge window to open/close so it can have maximal bake time, that's cool too. Please yell if there's something that I can do to help, though! :-) > On Fri, Aug 13, 2021 at 12:52:21PM -0700, Matthias Kaehlcke wrote: > > This series adds: > > - the onboard_usb_hub_driver > > - glue in the xhci-plat driver to create and destroy the > > onboard_usb_hub platform devices if needed > > - a device tree binding for the Realtek RTS5411 USB hub controller > > - device tree changes that add RTS5411 entries for the QCA SC7180 > > based boards trogdor and lazor > > - a couple of stubs for platform device functions to avoid > > unresolved symbols with certain kernel configs > > > > The main issue the driver addresses is that a USB hub needs to be > > powered before it can be discovered. For discrete onboard hubs (an > > example for such a hub is the Realtek RTS5411) this is often solved > > by supplying the hub with an 'always-on' regulator, which is kind > > of a hack. Some onboard hubs may require further initialization > > steps, like changing the state of a GPIO or enabling a clock, which > > requires even more hacks. This driver creates a platform device > > representing the hub which performs the necessary initialization. > > Currently it only supports switching on a single regulator, support > > for multiple regulators or other actions can be added as needed. > > Different initialization sequences can be supported based on the > > compatible string. > > > > Besides performing the initialization the driver can be configured > > to power the hub off during system suspend. This can help to extend > > battery life on battery powered devices which have no requirements > > to keep the hub powered during suspend. The driver can also be > > configured to leave the hub powered when a wakeup capable USB device > > is connected when suspending, and power it off otherwise. > > > > Changes in v16: > > - added patch 'ARM: configs: Explicitly enable USB_XHCI_PLATFORM > > where needed' to keep arm32 defconfigs effectively unchanged > > > > Changes in v15: > > - adjusted dependencies of USB_DWC3_CORE to make sure it can only > > be enabled when at least one of USB_DWC3_HOST, USB_DWC3_GADGET > > or USB_DWC3_DUAL_ROLE is selectable > > > > Changes in v14: > > - rebased on top of v5.14-rc1 > > - dropped DT binding patch which landed in v5.13 > > > > Changes in v13: > > - added patch "usb: Specify dependency on USB_XHCI_PLATFORM with > > 'depends on'" to the series to avoid Kconfig conflicts > > - added patch "arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM" > > to the series to keep effective defconfig unchanged > > > > Changes in v12: > > - onboard_hub driver: use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) > > in onboard_hub.h to also check for the driver built as module > > - onboard_hub_driver: include onboard_hub.h again to make sure there > > are prototype declarations for the public functions > > > > Changes in v11: > > - support multiple onboard hubs connected to the same parent > > - don't include =E2=80=98onboard_hub.h=E2=80=99 from the onboard hub dr= iver > > > > Changes in v10: > > - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=3Dy/m > > - keep 'regulator-boot-on' property for pp3300_hub > > > > Changes in v9: > > - added dependency on ONBOARD_USB_HUB (or !!ONBOARD_USB_HUB) to > > USB_PLATFORM_XHCI > > > > Changes in v7: > > - updated DT binding > > - series rebased on qcom/arm64-for-5.13 > > > > Changes in v6: > > - updated summary > > > > Changes in v5: > > - cover letter added > > > > Matthias Kaehlcke (7): > > usb: misc: Add onboard_usb_hub driver > > of/platform: Add stubs for of_platform_device_create/destroy() > > ARM: configs: Explicitly enable USB_XHCI_PLATFORM where needed > > arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM > > usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' > > usb: host: xhci-plat: Create platform device for onboard hubs in > > probe() > > arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub > > > > .../sysfs-bus-platform-onboard-usb-hub | 8 + > > MAINTAINERS | 7 + > > arch/arm/configs/exynos_defconfig | 1 + > > arch/arm/configs/keystone_defconfig | 1 + > > arch/arm/configs/multi_v7_defconfig | 1 + > > arch/arm/configs/mvebu_v7_defconfig | 1 + > > arch/arm/configs/omap2plus_defconfig | 1 + > > arch/arm/configs/pxa_defconfig | 1 + > > .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 +- > > .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +- > > .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 +- > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 +- > > arch/arm64/configs/defconfig | 1 + > > drivers/usb/cdns3/Kconfig | 2 +- > > drivers/usb/dwc3/Kconfig | 5 +- > > drivers/usb/host/Kconfig | 5 +- > > drivers/usb/host/xhci-plat.c | 6 + > > drivers/usb/host/xhci.h | 2 + > > drivers/usb/misc/Kconfig | 17 + > > drivers/usb/misc/Makefile | 1 + > > drivers/usb/misc/onboard_usb_hub.c | 497 ++++++++++++++++++ > > include/linux/of_platform.h | 22 +- > > include/linux/usb/onboard_hub.h | 18 + > > 23 files changed, 627 insertions(+), 39 deletions(-) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboar= d-usb-hub > > create mode 100644 drivers/usb/misc/onboard_usb_hub.c > > create mode 100644 include/linux/usb/onboard_hub.h > > > > -- > > 2.33.0.rc1.237.g0d66db33f3-goog > >