From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967CEC433EF for ; Thu, 14 Oct 2021 00:17:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D9C861154 for ; Thu, 14 Oct 2021 00:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbhJNATZ (ORCPT ); Wed, 13 Oct 2021 20:19:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbhJNATX (ORCPT ); Wed, 13 Oct 2021 20:19:23 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FBC7C061570; Wed, 13 Oct 2021 17:17:12 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id o20so13921456wro.3; Wed, 13 Oct 2021 17:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rDjhWTWe39jI0tVaVsIwJu3w3RaWMLFlHZz3rzeOD24=; b=JdOQHZ5ZtzM7ARgznKsyJUwSb6+PhHX717J520KvwRnhOeNpb9yzZ5tCkg7Gs8ppT/ j7YUIMyKCtwBIeECn2FQ0OccTpq7g3FCOunnde/dNNXxD3eXZ5RyPUA+Xf5NNQ/aAlmi 4nup7/mgOd4XCYrd/RrMPlrVTqtDehBLy4MV93u1PBSHzqLbykFKspgxX4RAAZShbEhG UqSWtS8UtzS2i69ifjwVeoneGrpdohfkKPo1KKQTINqw+7sVQU7m9krAiRY2TeFV0XIv Nr4dXWccAp23SzFr7YgvjfBfR1QUK/ZAio/Yp/tIGKB12rpowHKdQD67l8pVPU5wZEtX 07tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rDjhWTWe39jI0tVaVsIwJu3w3RaWMLFlHZz3rzeOD24=; b=x8j9HVLJ4T59GgLseFg8XSHc0yompaB5ltC/5qG3r55LCetkAZ64hz/CN/Hs3LqPMT 51F+urnF3CkqdcBqPd/XQvbOWn3lm7X4JUDslBXcRFoNWJALx1kgx1O+9F6edQueSNrc ZI6rpD19ZGJC7Jl1LYMovGHJjWl3Gth4Ms4on9YMgPaSspM8Kc6m8Mw5um1rgUHFJR2y mqFf0Im4ooToK9Cfbf8Gy3v8+jGsgC6cVGOFmsw/tBlTjm0Ikb3x9L3715B9jELsVy6g VU7ZhXsbolmqA/3k0vr3RIyoDFhFZ41u4JzHawWGmFme5yqrP23KA7siaw5qm/z17fu1 DFfg== X-Gm-Message-State: AOAM5319Y5gGTXthj/fufK5PR1QtYgLU78/EOO4rxXQo/FEu2iyRrF+b JRXBDvE2QcAn7S1BgJ0bNLCrSNtU4g8utLxh2X4= X-Google-Smtp-Source: ABdhPJxMNHNuDB+MA25s5aKeg0eD+rF7A5Qv31Rug4l1a5QZcltnDBgAHkjG+aO4fe51kSoiOYUxF2G1qCWgjpVJxas= X-Received: by 2002:a7b:c007:: with SMTP id c7mr75000wmb.101.1634170631010; Wed, 13 Oct 2021 17:17:11 -0700 (PDT) MIME-Version: 1.0 References: <20210910101218.1632297-1-maxime@cerno.tech> <20211013141629.qfeqwsyi5yobzjca@gilmour> In-Reply-To: <20211013141629.qfeqwsyi5yobzjca@gilmour> From: Rob Clark Date: Wed, 13 Oct 2021 17:16:58 -0700 Message-ID: Subject: Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent To: Maxime Ripard Cc: Caleb Connolly , Amit Pundir , John Stultz , Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Robert Foss , Jernej Skrabec , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Kyungmin Park , lkml , Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , Linux Samsung SOC , linux-arm-msm , dri-devel , Chen Feng , Xinwei Kong , Joonyoung Shim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Oct 13, 2021 at 7:16 AM Maxime Ripard wrote: > > Hi Caleb, > > On Thu, Sep 30, 2021 at 09:20:52PM +0100, Caleb Connolly wrote: > > Hi, > > > > On 30/09/2021 20:49, Amit Pundir wrote: > > > On Thu, 30 Sept 2021 at 04:50, Rob Clark wrote: > > > > > > > > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > > > > > > > > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > > > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > > > > > > The best practice to avoid those issues is to register its functions only after > > > > > > > > all its dependencies are live. We also shouldn't wait any longer than we should > > > > > > > > to play nice with the other components that are waiting for us, so in our case > > > > > > > > that would mean moving the DSI device registration to the bridge probe. > > > > > > > > > > > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm > > > > > > > > would be affected by this and wouldn't probe anymore after those changes. > > > > > > > > Exynos and kirin seems to be simple enough for a mechanical change (that still > > > > > > > > requires to be tested), but the changes in msm seemed to be far more important > > > > > > > > and I wasn't confortable doing them. > > > > > > > > > > > > > > > > > > > > > Hey Maxime, > > > > > > > Sorry for taking so long to get to this, but now that plumbers is > > > > > > > over I've had a chance to check it out on kirin > > > > > > > > > > > > > > Rob Clark pointed me to his branch with some fixups here: > > > > > > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > > > > > > > > > > > > But trying to boot hikey with that, I see the following loop indefinitely: > > > > > > > [ 4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator > > > > > > > [ 4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator > > > > > > > [ 4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator > > > > > > > [ 4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator > > > > > > > [ 4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator > > > > > > > [ 4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator > > > > > > > [ 4.681898] adv7511 2-0039: failed to find dsi host > > > > > > > > > > > > I just realized Rob's tree is missing the kirin patch. My apologies! > > > > > > I'll retest and let you know. > > > > > > > > > > Ok, just retested including the kirin patch and unfortunately I'm > > > > > still seeing the same thing. :( > > > > > > > > > > Will dig a bit and let you know when I find more. > > > > > > > > Did you have a chance to test it on anything using drm/msm with DSI > > > > panels? That would at least confirm that I didn't miss anything in > > > > the drm/msm patch to swap the dsi-host vs bridge ordering.. > > > > > > Hi, smoke tested > > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > on Pocophone F1 (sdm845 / A630) with v5.15-rc3. I see no obvious > > > regressions in my limited testing so far including video (youtube) > > > playback. > > Tested on the OnePlus 6 too booting AOSP, works fine. This *fixes* > > FBDEV_EMULATION (so we can get a working framebuffer console) which was > > otherwise broken on 5.15. > > > > However it spits out some warnings during boot: https://p.calebs.dev/gucysowyna.yaml > > Thanks for testing. It looks like the runtime_pm ordering between the > msm devices changed a bit with the conversion Rob did. > > Rob, do you know what could be going on? > Not entirely sure.. I didn't see that first splat, but maybe I was missing some debug config? (The 2nd one is kind of "normal", I think related to bootloader leaving the display on) BR, -R