From: Alim Akhtar <alim.akhtar@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon in Exynos5433
Date: Fri, 20 Aug 2021 20:17:07 +0530 [thread overview]
Message-ID: <CAGOxZ53CeRYafwjP45CsDRgBQtuvyVxJQR4CX4qChWyHzO4_fA@mail.gmail.com> (raw)
In-Reply-To: <20210820082149.84613-1-krzysztof.kozlowski@canonical.com>
On Fri, Aug 20, 2021 at 1:52 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The syscon nodes should come with specific compatible. Correct theh
s/theh/the?
> FSYS syscon to fix dtbs_check warnings:
>
> syscon@156f0000: compatible: 'anyOf' conditional failed, one must be fixed:
> ['syscon'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
With typo fixed above,
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index ebd5091d68b4..4422021cf4b2 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1132,7 +1132,7 @@ syscon_cam1: syscon@145f0000 {
> };
>
> syscon_fsys: syscon@156f0000 {
> - compatible = "syscon";
> + compatible = "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
> --
> 2.30.2
>
--
Regards,
Alim
next prev parent reply other threads:[~2021-08-20 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 8:14 [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433 Krzysztof Kozlowski
2021-08-20 8:21 ` [PATCH 2/2] arm64: dts: exynos: add proper comaptible FSYS syscon " Krzysztof Kozlowski
2021-08-20 14:47 ` Alim Akhtar [this message]
2021-08-20 15:05 ` Krzysztof Kozlowski
2021-08-20 14:44 ` [PATCH 1/2] arm64: dts: exynos: align operating-points table name with dtschema " Alim Akhtar
2021-08-20 15:04 ` Krzysztof Kozlowski
2021-09-15 7:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGOxZ53CeRYafwjP45CsDRgBQtuvyVxJQR4CX4qChWyHzO4_fA@mail.gmail.com \
--to=alim.akhtar@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).