From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D308BC433E1 for ; Thu, 27 Aug 2020 19:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B11EB22BEA for ; Thu, 27 Aug 2020 19:59:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AjsVfQcb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726322AbgH0T7v (ORCPT ); Thu, 27 Aug 2020 15:59:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgH0T7v (ORCPT ); Thu, 27 Aug 2020 15:59:51 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1224DC061264; Thu, 27 Aug 2020 12:59:51 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id i13so3210424pjv.0; Thu, 27 Aug 2020 12:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BtW/ozpx4qaFKtR4WdRiyJH+a5pa+/rdp0E0zYCBtiw=; b=AjsVfQcbbs8m2CmFrHV0gwxOPDDFel6Dtuz0EVsMe9pOvePSe2KyCjg5R54J213aA0 dYs7dOdAsqUXhUKoWNElRVtmUGHCALn0WOiQUKE3W6V6pIo5TVmtY5wvgoJScOJBWpF2 ZwroeOfqHbSXgH9NOC4gFVc4jTWoND5bcI6V09T8yOcf2ohLyiHpQVEaPEZNqdAIqkPI UeZlWWC0M/SJWy9F5wyNplXtqhJHSmtWHVsSFfV7wIy865aw2DytyMKKrm30aAaK0iG0 tmW4yhgyhYPR7janwCUFLJmWVHIfAqhea6q549D12zbhnsK/fJvsZeTjhzSky3l/gGR3 9QZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BtW/ozpx4qaFKtR4WdRiyJH+a5pa+/rdp0E0zYCBtiw=; b=Kwd7yYFMwfiuNdfmp+yz5o1rncNWB9qPDyZtWExxlxb8jfMZz6V4ugrZG3gNDlc2Lu WOP+6v7QVSuSsS2jhlV5ts3tcjxnw9hPpiU8BDYAmdO5Fxbu/SEKxLAVHnoxF0IrjO/K fYqjVuI1F3I59QYY74je8A8sFKay/8fSYOgbYnWsiM8Y7qNzmXm+diQK4PlIjiMVvvkA z2H+Rl7pVmDotZo9pQVnvFehHvxceSbo2XCjvkxxrWCE19vb2Ev130tTFR1lvbvpXyUv OGx5aaQrrxZqel8ktyH2n2cmSUS30mOD9M0gX4Yd0fx5fDArqMupcXRW5ldyVkxDamRW U/JQ== X-Gm-Message-State: AOAM531i0WXafupecX5sW+1tC695hmyZXBdKSlnhHGvDscXKaPjmbUaB n+f660MrNuQojTSJd59GiLmX1iqtbg5j75Rw0hE= X-Google-Smtp-Source: ABdhPJztdvx7l/Bma3wdHdw/Knt4y7nn4/yOSwjk8CneJT6blQkPrpb2KiIZIrG26U/H2iMIqzfbq2Fkdjt5j2df1p0= X-Received: by 2002:a17:90a:2c06:: with SMTP id m6mr433859pjd.129.1598558390619; Thu, 27 Aug 2020 12:59:50 -0700 (PDT) MIME-Version: 1.0 References: <20200827192642.1725-1-krzk@kernel.org> <20200827192642.1725-13-krzk@kernel.org> In-Reply-To: <20200827192642.1725-13-krzk@kernel.org> From: Andy Shevchenko Date: Thu, 27 Aug 2020 22:59:34 +0300 Message-ID: Subject: Re: [PATCH v2 13/18] iio: imu: inv_mpu6050: Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Peter Rosin , Kukjin Kim , Michael Hennerich , Kevin Hilman , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Maxime Coquelin , Alexandre Torgue , Tomasz Duszynski , Linus Walleij , linux-iio , Linux Kernel Mailing List , linux-arm Mailing List , linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, Aug 27, 2020 at 10:28 PM Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. Reviewed-by: Andy Shevchenko > Signed-off-by: Krzysztof Kozlowski > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 20 ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > index 3fee3947f772..18a1898e3e34 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > @@ -1475,22 +1475,14 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, > } > > st->vdd_supply = devm_regulator_get(dev, "vdd"); > - if (IS_ERR(st->vdd_supply)) { > - if (PTR_ERR(st->vdd_supply) != -EPROBE_DEFER) > - dev_err(dev, "Failed to get vdd regulator %d\n", > - (int)PTR_ERR(st->vdd_supply)); > - > - return PTR_ERR(st->vdd_supply); > - } > + if (IS_ERR(st->vdd_supply)) > + return dev_err_probe(dev, PTR_ERR(st->vdd_supply), > + "Failed to get vdd regulator\n"); > > st->vddio_supply = devm_regulator_get(dev, "vddio"); > - if (IS_ERR(st->vddio_supply)) { > - if (PTR_ERR(st->vddio_supply) != -EPROBE_DEFER) > - dev_err(dev, "Failed to get vddio regulator %d\n", > - (int)PTR_ERR(st->vddio_supply)); > - > - return PTR_ERR(st->vddio_supply); > - } > + if (IS_ERR(st->vddio_supply)) > + return dev_err_probe(dev, PTR_ERR(st->vddio_supply), > + "Failed to get vddio regulator\n"); > > result = regulator_enable(st->vdd_supply); > if (result) { > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko