Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge

From: Tim Harvey <tharvey@gateworks.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Marek Vasut <marex@denx.de>,
	devicetree <devicetree@vger.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Robert Foss <robert.foss@linaro.org>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge
Date: Tue, 5 Oct 2021 14:43:32 -0700	[thread overview]
Message-ID: <CAJ+vNU1Hy_94TYgs0isNc2pmiH2sOReZJLhphzQFTN2Z50JPrA@mail.gmail.com> (raw)
In-Reply-To: <CAMty3ZANJz=HSKFzZ8gn896uw98iVwMEpGhmanXNbj77Ren4hw@mail.gmail.com>

On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Hi Sam,
>
> On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Jagan,
> >
> > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote:
> > > This series supports common bridge support for Samsung MIPI DSIM
> > > which is used in Exynos and i.MX8MM SoC's.
> > >
> > > The final bridge supports both the Exynos and i.MX8MM DSI devices.
> > >
> > > Right now bridge offers two sets of implementations.
> > >
> > > A. With component_ops and exynos specific code exclusively for
> > >    exynos dsi drivers and it's legacy bindings.
> > >
> > > B. Without componenet_ops for newly implemented bridges and its
> > >    users like i.MX8MM.
> > >
> > > The future plan is to fix the implementation A) by dropping
> > > component_ops and fixing exynos specific code in order to make
> > > the bridge more mature to use and the same is mentioned in
> > > drivers TODO.
> > >
> > > Patch 0001 - 0006: Bridge conversion
> > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions
> > >
> > > Tested in Engicam i.Core MX8M Mini SoM.
> > >
> > > Anyone interest, please have a look on this repo
> > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim
> > >
> > > Would appreciate anyone from the exynos team to test it on
> > > the exynos platform?
> > >
> > > Any inputs?
> >
> > I really like where you are headign with this!
> > No testing - sorry. But I will try to provide a bit of feedback on the
> > individual patches.
> >
> > I hope you find a way to move forward with this.
>
> Thanks for the response.
>
> We have found some issues with Bridge conversion on existing exynos
> drivers. The component based DSI drivers(like exynos) are difficult to
> attach if it involves kms hotplug. kms hotplug would require drm
> pointer and that pointer would only available after the bind call
> finishes. But the bridge attach in bind call will defer till it find
> the attached bridge.
>
> Right now I'm trying to find the proper way to attach the bridges for
> component based DSI drivers which involves kms hot-plug.
>
> If you have any ideas on this, please let me know.
>

Jagan,

How is your progress on this series? Looking at your repo it looks
like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim
branch but you've got a lot of things there that are likely not
related to this series?

Best regards,

Tim