From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EF6C433E6 for ; Mon, 31 Aug 2020 13:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80542208CA for ; Mon, 31 Aug 2020 13:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598882367; bh=0ELgDN4DCdbC4neuwarO8uv8nWk+EoaxkCEgogyZFGE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=0+eYDvcGbnif23xIe/ocjQeAmle9T/xbjgHaC3CCzKowkGgh6oo4G4xhHV0rY2vZ9 kIG2Y3CSvxSPC3WGjHdbwnrjRB5FEksaGoTp50lQT43olUmh8jPB47qUm6K94mwr66 8JVIfysrJqYw2LvcnR5a9Zg2dLpvKZDhIchmR5gE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726384AbgHaN7X (ORCPT ); Mon, 31 Aug 2020 09:59:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:48266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgHaN7V (ORCPT ); Mon, 31 Aug 2020 09:59:21 -0400 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD84420936; Mon, 31 Aug 2020 13:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598882361; bh=0ELgDN4DCdbC4neuwarO8uv8nWk+EoaxkCEgogyZFGE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ut5tovIEHzLSBfa4ieSRCaowAFda6fVXnIF6OfQVSDnQjQqD5u3XBE9ipwjTcLPjA 8HyTMoS6pX0snp0m/oY5G0zGSFDaK0RFmCmcf26Dx5DV5v/vOXhZ50i8IQcxHCevvO yx44Yq7XOmt5yi5Id68//MxfeE2QR2wd+C/OynSU= Received: by mail-ed1-f44.google.com with SMTP id w1so1906645edr.3; Mon, 31 Aug 2020 06:59:20 -0700 (PDT) X-Gm-Message-State: AOAM532uKRsAsJ8lS8Ey37CFHZaIxYTNDdHJrcDCCsr70rOTAeBT1ajY s+EEQUOBrKRaZL4UgCBCAqQ6NFZTn8+i58nuA5I= X-Google-Smtp-Source: ABdhPJz4mIou6NQDF9GoU0glbeGAVtu339WyqeM8YO5d2GjJ0q1vFCMgP88xGwBXgdcvmJjfHSnIr2cub9+CDPtsrSM= X-Received: by 2002:a50:fd0b:: with SMTP id i11mr1363872eds.298.1598882359253; Mon, 31 Aug 2020 06:59:19 -0700 (PDT) MIME-Version: 1.0 References: <20200830135200.24304-1-krzk@kernel.org> <20200830135200.24304-23-krzk@kernel.org> <96651e85-c27f-3167-7b41-2ea051c25c65@kernel.org> <01bb90db-511d-fbf5-d29a-1fba932f0abf@samsung.com> In-Reply-To: <01bb90db-511d-fbf5-d29a-1fba932f0abf@samsung.com> From: Krzysztof Kozlowski Date: Mon, 31 Aug 2020 15:59:08 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3 To: Sylwester Nawrocki Cc: Sylwester Nawrocki , Marek Szyprowski , Rob Herring , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Denis GNUtoo Carikli , Simon Shields , Bartlomiej Zolnierkiewicz Content-Type: text/plain; charset="UTF-8" Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Mon, 31 Aug 2020 at 15:57, Sylwester Nawrocki wrote: > > On 31.08.2020 12:42, Krzysztof Kozlowski wrote: > > On Mon, 31 Aug 2020 at 12:35, Sylwester Nawrocki wrote: > >> On 8/31/20 10:38, Krzysztof Kozlowski wrote: > >>> On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski wrote: > >>>> On 30.08.2020 15:51, Krzysztof Kozlowski wrote: > >>>>> The camera's pinctrl configuration is simply empty and not effective. > >>>>> Remove it to fix dtbs_check warning: > >>>>> > >>>>> arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array' > >>>>> > >>>>> Signed-off-by: Krzysztof Kozlowski > >>>> > >>>> I think that this was intentional to properly enable support for > >>>> mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the > >>>> default values if no pinctrl properties are provided. Sylwester, could > >>>> you comment? > >>> > >>> Indeed it could be intentional... I see now errors: > >>> [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19 > >>> > >>> I wonder why getting an empty pinctrl is needed... maybe the driver > >>> should accept missing pinctrl? > >> > >> It might have been better to have the pinctrl properties optional, as there > >> might be boards without the image sensor attached and FIMC could still be > >> used in memory-to-memory mode, as Marek pointed out. But it seems too late > >> now to change that. The binding defines the pinctrl properties as required > >> (Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to > >> keep them in dtses. > > > > You can always make a required property optional and it is not a break > > of ABI. The other way around would be a break. Why then not changing > > the driver to accept optional pinctrl? > > Feel free to send the patch, I would prefer to leave that as is though. > Is it really suddenly a problem to use an empty property? The pinctrl > bindings allows it. The bindings scream: arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array' so either we should model it differently (not as empty array), update the driver to make it optional or change the bindings/dtschema. I'll see how to fix it properly. Best regards, Krzysztof