From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:WOLFSON MICROELECTRONICS DRIVERS"
<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data
Date: Thu, 23 Mar 2017 13:34:10 +0200 [thread overview]
Message-ID: <CAJKOXPdqTmv02+WC2Nh5zWiiotJ094dQV8ywBx_1-oupCkVTXQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbm8zA8-p3nWc8-wiwLXRH8FDUdE=2L4QQc79TOT-fdaQ@mail.gmail.com>
On Thu, Mar 23, 2017 at 11:47 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Mon, Mar 20, 2017 at 7:44 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On Fri, Feb 17, 2017 at 01:52:14PM +0000, Charles Keepax wrote:
> >> On Fri, Feb 17, 2017 at 03:35:04PM +0200, Krzysztof Kozlowski wrote:
> >> > On Thu, Feb 16, 2017 at 01:27:16PM +0000, Charles Keepax wrote:
> >> > > Use devm_gpiochip_add_data to simplify the error path in
> >> > > samsung_gpiolib_register. Additionally this would also fix a leak if
> >> > > the pinctrl driver was unbound, although admittedly I can't see any
> >> > > good use-case for doing so, but the driver does currently allow it.
> >> >
> >> > Driver does not allow unbinding (.suppress_bind_attrs = true)...
> >> >
> >>
> >> Oops... sorry missed that.
> >
> > Can you resend with updated commit msg? I think it was not picked up by
> > Linus yet.
>
> I'm expecting you to pick it up and send to me by pull request now I guess,
> or did we agree that a Samsung patches wouldn't be too voluminous this
> cycle?
>
> If you're OK with it, can we proceed to use you as Samsung patch
> collection point for this kernel cycle from this moment on?
I will take it, especially that more things are coming. I already
applied patch from Chanwoo which should go to fixes (initially I put
it on wrong branch).
Best regards,
Krzysztof
prev parent reply other threads:[~2017-03-23 11:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 13:27 [PATCH v2 1/4] pinctrl: Fix trivial spelling typo in a comment Charles Keepax
2017-02-16 13:27 ` [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO Charles Keepax
2017-02-22 14:37 ` Linus Walleij
2017-02-23 17:23 ` Charles Keepax
2017-02-23 17:54 ` [PATCH] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range Charles Keepax
2017-02-27 2:13 ` Tomasz Figa
2017-02-28 9:01 ` Charles Keepax
2017-02-28 17:04 ` [PATCH v2] " Charles Keepax
2017-03-04 11:20 ` Tomasz Figa
2017-03-06 16:49 ` Charles Keepax
2017-03-20 18:39 ` Krzysztof Kozlowski
2017-03-21 9:32 ` Charles Keepax
2017-03-14 13:44 ` [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO Linus Walleij
2017-03-14 13:58 ` Krzysztof Kozlowski
2017-03-16 15:28 ` Linus Walleij
2017-02-16 13:27 ` [PATCH v2 3/4] pinctrl: samsung: Remove unused local variable Charles Keepax
2017-02-22 14:38 ` Linus Walleij
2017-02-16 13:27 ` [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data Charles Keepax
2017-02-17 13:35 ` Krzysztof Kozlowski
2017-02-17 13:52 ` Charles Keepax
2017-03-20 18:44 ` Krzysztof Kozlowski
2017-03-23 9:47 ` Linus Walleij
2017-03-23 11:34 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPdqTmv02+WC2Nh5zWiiotJ094dQV8ywBx_1-oupCkVTXQ@mail.gmail.com \
--to=krzk@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).