From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Date: Tue, 14 Mar 2017 15:04:28 +0200 Message-ID: References: <20170311172527.16368-1-krzk@kernel.org> <20170311172527.16368-5-krzk@kernel.org> <4386279.iJpUOasmTG@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <4386279.iJpUOasmTG@amdc3058> Sender: linux-kernel-owner@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-arm-kernel@lists.infradead.org, Wim Van Sebroeck , Guenter Roeck , Rob Herring , Kukjin Kim , Javier Martinez Canillas , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: >> Watchdog module does not have external dependencies so it can be safely >> enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based >> boards. >> >> Signed-off-by: Krzysztof Kozlowski > > Please first fix the driver w.r.t. infinite interrupt in soft mode > issue and only then enable it on more hardware. IOW this patch > should be placed after patch #7 in the series. The soft-interrupt mode is not the default one so this should not cause any issues by default but I got your point. Makes sense. The pity is the timing. There wasn't much interest in the patchset (no comments since 24 of Feb) so I merged it yesterday evening. Does it brake any platform/board? Best regards, Krzysztof