From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0B10C43461 for ; Sun, 6 Sep 2020 14:44:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71C7920759 for ; Sun, 6 Sep 2020 14:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599403475; bh=7IEOIE7fQw9QHXmykxTiIVu886iDkKJ30802n3q5IwU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=yEBi4fK9RK8lmTX9usK1hv4vaXYj0tbTavM58CeDNCvFqzFosTrjKxukJBJGHvv2j W2SV9CqNMtbeFnohYOqJuPS8A3gZyx6ZWmFVTHPfeFsPAp8OHANAubSO7VTSdvQsou H6cB0mkEDwuEzzQOlMDYVZJVVKAe6rBU9V+pkcWg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728778AbgIFOld (ORCPT ); Sun, 6 Sep 2020 10:41:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:34590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728850AbgIFOkJ (ORCPT ); Sun, 6 Sep 2020 10:40:09 -0400 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01B9B20838; Sun, 6 Sep 2020 14:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599403147; bh=7IEOIE7fQw9QHXmykxTiIVu886iDkKJ30802n3q5IwU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=etXM+rlB1+DW1J4jNFEGcm+fF67s78ieiIJMokib3gbJ/4axa/QC0n2G8dk5lqyab qBGZpGxKO4g23EzVrnLE9URUV/18btbD6jd7BioxTKQiRAZiF9j5rBoO60/0+AU19R QrrjUKSu0Uk6jLxywtE5Upy8feMDExtu7wnkOdM4= Received: by mail-ej1-f51.google.com with SMTP id o8so1353409ejb.10; Sun, 06 Sep 2020 07:39:06 -0700 (PDT) X-Gm-Message-State: AOAM531tqYkhj80e+PXdMwLyhpduhVhMUwWc77d5dfLswhKd6azxDxHT 2qwXRhjc+5czxV+tq8MIXY63DKTLCaqjHxLMBoQ= X-Google-Smtp-Source: ABdhPJwZbjzSkmXyfdB9RtLYvattBo3H9pni7matmcNuK/Qe1S1r3L8Nqgb9OFRwyrC4kvI+4viaz1GbEG+WoE49O3Y= X-Received: by 2002:a17:907:724f:: with SMTP id ds15mr16286701ejc.119.1599403145475; Sun, 06 Sep 2020 07:39:05 -0700 (PDT) MIME-Version: 1.0 References: <20200829142948.32365-1-krzk@kernel.org> <20200903163255.GA2903619@bogus> In-Reply-To: <20200903163255.GA2903619@bogus> From: Krzysztof Kozlowski Date: Sun, 6 Sep 2020 16:38:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema To: Rob Herring Cc: "David S. Miller" , Jakub Kicinski , Krzysztof Opasiak , Kukjin Kim , netdev@vger.kernel.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-nfc@lists.01.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Sylwester Nawrocki , Chanwoo Choi , Inki Dae Content-Type: text/plain; charset="UTF-8" Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, 3 Sep 2020 at 18:33, Rob Herring wrote: > > On Sat, Aug 29, 2020 at 04:29:45PM +0200, Krzysztof Kozlowski wrote: > > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > > This is conversion only so it includes properties with invalid prefixes > > (s3fwrn5,en-gpios) which should be addressed later. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 -------- > > .../devicetree/bindings/net/nfc/s3fwrn5.yaml | 59 +++++++++++++++++++ > > Please rename to samsung,s3fwrn5-i2c.yaml. > > > MAINTAINERS | 1 + > > 3 files changed, 60 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > deleted file mode 100644 > > index f02f6fb7f81c..000000000000 > > --- a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > +++ /dev/null > > @@ -1,25 +0,0 @@ > > -* Samsung S3FWRN5 NCI NFC Controller > > - > > -Required properties: > > -- compatible: Should be "samsung,s3fwrn5-i2c". > > -- reg: address on the bus > > -- interrupts: GPIO interrupt to which the chip is connected > > -- s3fwrn5,en-gpios: Output GPIO pin used for enabling/disabling the chip > > -- s3fwrn5,fw-gpios: Output GPIO pin used to enter firmware mode and > > - sleep/wakeup control > > - > > -Example: > > - > > -&hsi2c_4 { > > - s3fwrn5@27 { > > - compatible = "samsung,s3fwrn5-i2c"; > > - > > - reg = <0x27>; > > - > > - interrupt-parent = <&gpa1>; > > - interrupts = <3 0 0>; > > - > > - s3fwrn5,en-gpios = <&gpf1 4 0>; > > - s3fwrn5,fw-gpios = <&gpj0 2 0>; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > new file mode 100644 > > index 000000000000..c22451dea350 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/nfc/s3fwrn5.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung S3FWRN5 NCI NFC Controller > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + - Krzysztof Opasiak > > + > > +properties: > > + compatible: > > + const: samsung,s3fwrn5-i2c > > + > > + interrupts: > > + maxItems: 1 > > + > > + reg: > > + maxItems: 1 > > + > > + s3fwrn5,en-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used for enabling/disabling the chip > > + > > + s3fwrn5,fw-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used to enter firmware mode and sleep/wakeup control > > + > > +required: > > + - compatible > > + - interrupts > > + - reg > > + - s3fwrn5,en-gpios > > + - s3fwrn5,fw-gpios > > additionalProperties: false Sure, I'll fix both issues. Best regards, Krzysztof