From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51580C433E6 for ; Mon, 31 Aug 2020 08:39:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24CE72073A for ; Mon, 31 Aug 2020 08:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598863147; bh=/mTBwH0H2XS7YSaOFVh9wZUjDwDeG33keE7ZBUOqWL8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ex3rmk5nHSJjpiqUrvQZGcc6MXDjkZ8prns+l4LjwMYeu3UB6lXZArRhraDbmnx6/ GvQeNbg+HHpj6GHaWIUMUtIp3QEF5Mi0M7UIZpA4gPIE38T+VB5yBpOlWzyn0ip6AR UFw9pqRr3x6K7DILejGMsxuBgvwO+NypeZblIvps= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728083AbgHaIjG (ORCPT ); Mon, 31 Aug 2020 04:39:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:59652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgHaIjG (ORCPT ); Mon, 31 Aug 2020 04:39:06 -0400 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63E822137B; Mon, 31 Aug 2020 08:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598863145; bh=/mTBwH0H2XS7YSaOFVh9wZUjDwDeG33keE7ZBUOqWL8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=0DNDIqwVYE/LHMPUqsSOdHXnx3H56mMT3qGKhC9s3QEwOGKmmxQnu97kkJhw1RJaq 2GHqCupyOkmXsanizUsBDchdhqQPHXVlqMjtCKuydcx0+o6XIFHrHSKhUpFtyvlrsx xWZNqcvQMZs05rusutSFTe7ho3t4z/XQZbUThdD4= Received: by mail-ej1-f42.google.com with SMTP id b17so7346564ejq.8; Mon, 31 Aug 2020 01:39:05 -0700 (PDT) X-Gm-Message-State: AOAM532BFfH7Zek1BT1BKrmCo5g3F6qew6CzevyUkF9QOcPVoFh7gDpm FBb6jEWOnAmO0x70xHbVDP4LDVsuaksKehvnhhY= X-Google-Smtp-Source: ABdhPJyowpEQH5t1dzDoER28m99xK7ss6Z0pLGH7Bkoqwr+INsBLkRiqyVs2tsVykl3vYYCRQYzfp7ZyLf/kAhBS5HA= X-Received: by 2002:a17:906:8401:: with SMTP id n1mr111095ejx.215.1598863144013; Mon, 31 Aug 2020 01:39:04 -0700 (PDT) MIME-Version: 1.0 References: <20200830135200.24304-1-krzk@kernel.org> <20200830135200.24304-23-krzk@kernel.org> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 31 Aug 2020 10:38:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3 To: Marek Szyprowski Cc: Rob Herring , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Denis GNUtoo Carikli , Simon Shields , Bartlomiej Zolnierkiewicz , Sylwester Nawrocki Content-Type: text/plain; charset="UTF-8" Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski wrote: > > Hi Krzysztof, > > On 30.08.2020 15:51, Krzysztof Kozlowski wrote: > > The camera's pinctrl configuration is simply empty and not effective. > > Remove it to fix dtbs_check warning: > > > > arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array' > > > > Signed-off-by: Krzysztof Kozlowski > > I think that this was intentional to properly enable support for > mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the > default values if no pinctrl properties are provided. Sylwester, could > you comment? Indeed it could be intentional... I see now errors: [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19 I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl? Best regards, Krzysztof