linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christian Hewitt <christianshewitt@gmail.com>
Cc: "linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Marian Mihailescu <mihailescu2m@gmail.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: BUG: Cannot boot Odroid XU4 from eMMC without this patch
Date: Mon, 27 Sep 2021 13:09:50 +0200	[thread overview]
Message-ID: <CAJKOXPfUnLbhc6e_ccZxhVReV9jHsQ8aykkP=ghK-qURQLCdLA@mail.gmail.com> (raw)
In-Reply-To: <89888711-56BF-4E6C-92EE-2053E773B077@gmail.com>

On Mon, 13 Sept 2021 at 06:32, Christian Hewitt
<christianshewitt@gmail.com> wrote:
>
> https://github.com/chewitt/linux/commit/8a4ebfb43a394e5dc5e9fafc92a50d5e81a4f258
>
> If I boot any recent kernel without the above patch, the emmc module on the XU4 is not detected, see:
>
> Without:
>
> [    3.227837] mmc0: tuning execution failed: -5
> [    3.231229] mmc0: error -5 whilst initialising MMC card
> [    3.536450] mmc0: tuning execution failed: -5
> [    3.539680] mmc0: error -5 whilst initialising MMC card
> [    3.794056] mmc0: tuning execution failed: -5
> [    3.794212] mmc0: error -5 whilst initialising MMC card
> [    4.111097] mmc0: tuning execution failed: -5
> [    4.115356] mmc0: error -5 whilst initialising MMC card
> [    4.426164] mmc0: tuning execution failed: -5
> [    4.429678] mmc0: error -5 whilst initialising MMC card
> [    4.756226] mmc0: tuning execution failed: -5
> [    4.760641] mmc0: error -5 whilst initialising MMC card
>
> With:
>
> [    3.305461] mmc0: new HS400 MMC card at address 0001
> [    3.307444] mmcblk0: mmc0:0001 8GME4R 7.28 GiB
> [    3.308132] mmcblk0boot0: mmc0:0001 8GME4R 4.00 MiB
> [    3.309172] mmcblk0boot1: mmc0:0001 8GME4R 4.00 MiB
> [    3.310255] mmcblk0rpmb: mmc0:0001 8GME4R 512 KiB, chardev (246:0)
> [    3.315963]  mmcblk0: p1 p2
>
> The patch is sourced from a Linux 5.4 patchset used by several retro gaming distros for XU4 images shared in the HardKernel forums. I would be happy to submit it, but the original patch has no description in the commit message. Not being a coding developer myself I cannot explain whether it is correct or what it’s doing to add one. All I can do is confirm that it works, and is needed. SD card boot is not an issue.
>
> I’ve CC’d the original author (Marian) in case he remembers the patch and can comment. It would be good to get this upstream.

The patch might have sense but would require describing conditions -
what MMC input and output clock settings work and which do not work.
Also someone would need to test other Exynos5422 boards and other
Exynos with HS200 and HS400 support (Exynos5433, Exynos7). I think
this should not affect SD cards.

+Cc Marek, Sylwester, Jaehoon and Ulf.

Best regards,
Krzysztof

  reply	other threads:[~2021-09-27 11:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  4:27 Christian Hewitt
2021-09-27 11:09 ` Krzysztof Kozlowski [this message]
2021-10-01  0:40   ` Jaehoon Chung
2021-10-01 13:41     ` Christian Hewitt
2021-10-06 22:16       ` Jaehoon Chung
2021-10-07  4:36         ` Christian Hewitt
2021-10-07 11:05           ` Jaehoon Chung
2021-10-20 11:14             ` Jaehoon Chung
2021-10-04 10:07     ` Marek Szyprowski
2021-10-04 13:01       ` Krzysztof Kozlowski
2021-10-04 15:51         ` Marek Szyprowski
2021-10-06 10:40           ` Ulf Hansson
2021-10-06 22:12             ` Jaehoon Chung
2021-10-06 22:01       ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPfUnLbhc6e_ccZxhVReV9jHsQ8aykkP=ghK-qURQLCdLA@mail.gmail.com' \
    --to=krzk@kernel.org \
    --cc=christianshewitt@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mihailescu2m@gmail.com \
    --cc=snawrocki@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --subject='Re: BUG: Cannot boot Odroid XU4 from eMMC without this patch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).