From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60152C433F5 for ; Wed, 29 Sep 2021 23:29:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A9406154B for ; Wed, 29 Sep 2021 23:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347543AbhI2Xbi (ORCPT ); Wed, 29 Sep 2021 19:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346495AbhI2Xbh (ORCPT ); Wed, 29 Sep 2021 19:31:37 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1614CC06161C for ; Wed, 29 Sep 2021 16:29:56 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id m3so17248132lfu.2 for ; Wed, 29 Sep 2021 16:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3jxizxNlMd3y5kC30EDvr+i+pHVmPKgABz+DF4rjgKs=; b=ZNn9Be9ICes2313BvgS80zA79N5Rq02S19oDdcxEx67Sx2rzL5Gn1xVnuu3/ukS6dh RtjBsCpugu9twNEt/dyydKYUcEe//8cHEgNaSmNAM9JttRf66LomPN0bRf8t0UmYIH6J bK8f/eh0Jg5jTt5RM3jaBwYLMr4tSVtsnJ6t1BL1Tx/sirWQuI/MN57Yvd5c3rj4jtCl ufitWPMWyXCopRxWyRu6ONxWq+6kWNCJWoS0JMr6GptBK0Scan2mjbOH0RyRhmLURchN u306sBL0XbZ8cbmzje+XWEYOAekY8Im+A2omYOA/XmPk+EYU7T6M4WCs3u8gTjLcBxXB pLKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3jxizxNlMd3y5kC30EDvr+i+pHVmPKgABz+DF4rjgKs=; b=EGp4cK2RP2kbifMHi6n7fNddaOGlXAVoS0GlEi1XZ+dIjoSK/PsHSeJQGlBA80HGQg fIs8xuCxYXjgKZ1wT1P4OnrKqwEGqW4EBNkrIyf6F5PgoktK1B5lRGjizQovnpE0Ol+G zH6eHXB9S/i0+JiebcTGSKYSiAv79joAhpkbbtwbb/VKtwYrd7gEW3eUJrNtdhm4WTzT 7+FlsCMqeMLxQGx7kCLvx7T+5Q2GCxiQmm5oItWlpacYZE2oXDOmVpCTyc38wMQwE5wc QdfElRLn/VxN2SunsXu598xPUMD/BWatDmRnkTxFtJbo3TQDr41/VA+bx7fm/yt7I84b ky+g== X-Gm-Message-State: AOAM532e951/IEjq7/cdW686sPyKSIqzh/p1kykAnNGpp2vAPM8mfM7J yYowicFYeY97TPDVPoOQU1MQ+cniA8x0fimQ1+uh3A== X-Google-Smtp-Source: ABdhPJxEKlQI/LHiS4pZSJWaQTK5azLO1ThGLFdst/S7wFdxgxStmC6elHJTeXAejJ+cfi1lHCUXfQO9r4xF0Yu/Cgs= X-Received: by 2002:a05:6512:ea5:: with SMTP id bi37mr2501644lfb.36.1632958194363; Wed, 29 Sep 2021 16:29:54 -0700 (PDT) MIME-Version: 1.0 References: <20210910101218.1632297-1-maxime@cerno.tech> In-Reply-To: From: John Stultz Date: Wed, 29 Sep 2021 16:29:42 -0700 Message-ID: Subject: Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent To: Maxime Ripard Cc: Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Robert Foss , Jernej Skrabec , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Kyungmin Park , lkml , Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , Linux Samsung SOC , linux-arm-msm , Rob Clark , dri-devel , Chen Feng , Xinwei Kong , Joonyoung Shim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > > The best practice to avoid those issues is to register its functions only after > > > > all its dependencies are live. We also shouldn't wait any longer than we should > > > > to play nice with the other components that are waiting for us, so in our case > > > > that would mean moving the DSI device registration to the bridge probe. > > > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm > > > > would be affected by this and wouldn't probe anymore after those changes. > > > > Exynos and kirin seems to be simple enough for a mechanical change (that still > > > > requires to be tested), but the changes in msm seemed to be far more important > > > > and I wasn't confortable doing them. > > > > > > > > > Hey Maxime, > > > Sorry for taking so long to get to this, but now that plumbers is > > > over I've had a chance to check it out on kirin > > > > > > Rob Clark pointed me to his branch with some fixups here: > > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > > > > But trying to boot hikey with that, I see the following loop indefinitely: > > > [ 4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator > > > [ 4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator > > > [ 4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator > > > [ 4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator > > > [ 4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator > > > [ 4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator > > > [ 4.681898] adv7511 2-0039: failed to find dsi host > > > > I just realized Rob's tree is missing the kirin patch. My apologies! > > I'll retest and let you know. > > Ok, just retested including the kirin patch and unfortunately I'm > still seeing the same thing. :( > > Will dig a bit and let you know when I find more. Hey Maxime! I chased down the issue. The dsi probe code was still calling drm_of_find_panel_or_bridge() in order to succeed. I've moved the logic that looks for the bridge into the bridge_init and with that it seems to work. Feel free (assuming it looks ok) to fold this change into your kirin patch: https://git.linaro.org/people/john.stultz/android-dev.git/commit/?id=4a35ccc4d7a53f68d6d93da3b47e232a7c75b91d thanks -john