From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B67C6FA94 for ; Mon, 19 Sep 2022 22:56:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbiISW4a (ORCPT ); Mon, 19 Sep 2022 18:56:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229983AbiISW42 (ORCPT ); Mon, 19 Sep 2022 18:56:28 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 646AC402D9 for ; Mon, 19 Sep 2022 15:56:23 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id sb3so2051734ejb.9 for ; Mon, 19 Sep 2022 15:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5S9VBftUHA8Ab+AfT1DhnDF/jWnQCvfphMhw9w+YVhc=; b=pT3AVw/XaQKfMJa28M67X6CWfwalI0Uvo6unsRjOTD2Z+d/hMLJagRy91+fB9mWt/H RvjlLsn+3FsNx74QkbruJHKtTQ+30w35PYmoN36zBZvRhmzaaut2t/ejO0VHEYQ77EDj OXDYFEqkBBbGSPaGws21i+7eNFUtsVpC10Ocfp53V0C+AqpxtnC2gWLf09NvoZb8DNZe nefkWz5Q2xpTnqPE/9sJZpmszdShkKibcjHKjjaL4N2+oQKOJucjE0sZV5m8l2gxJQLL eUTG5Bs9Z5UoBJW4L2zlLkhjGsOc0HVn5guvp/vsJvOqjFnEQJHDOGaHy7aMupntX7WF 7vTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5S9VBftUHA8Ab+AfT1DhnDF/jWnQCvfphMhw9w+YVhc=; b=rKnovejNM1ujUbez9R7mWaC2bonb6HAQVPLvbYP4aT1W9hcBj3w1qboZIWR6ae3jTA 9dsuNBWklWg8sWJcDIA+FLrjxgoerzu9YHHxpiY/pX5ysyUkdrxisFxoqMtCvPo5w5XA SGdeVAQ/YFq0JXu5Ljyca8bE1uY7PuNXynMdobs5X0EzWZ3H81GwOAdYQrAjY4K5/Ysn l7KPAibA6H08DibC9Wyk3RsSaIWIVHYt5aQ5Av8iYmxF4H6JCo2cX/jAYxSlYSbvIUU/ 8+NCGDbKKUon9we9Pb7e9VQgilxtfwNJc0YdM/Dske+WwZ/JrZUflEVjaa0TjJyn8U9C NrLQ== X-Gm-Message-State: ACrzQf08CxYzSqP7LGXOTAK7ylQSOMzUKqzMWvTqYW8Lg+dCETG+zB5a CJG4S4W1gSCPcuY6/Sy5TONuV4QvUCHjb6T0xs1iGg== X-Google-Smtp-Source: AMsMyM5kdxcAfNB78ChbidtnpNAMschNYMIGpvHRr7zgKTZ4CCEGx6bhJgHHTNr9SAgKH+LAmfDCBtvH2R9hQBackB8= X-Received: by 2002:a17:906:ef8c:b0:77c:8f77:330 with SMTP id ze12-20020a170906ef8c00b0077c8f770330mr14503775ejb.604.1663628181793; Mon, 19 Sep 2022 15:56:21 -0700 (PDT) MIME-Version: 1.0 References: <20220701012647.2007122-1-saravanak@google.com> In-Reply-To: From: Olof Johansson Date: Mon, 19 Sep 2022 15:56:09 -0700 Message-ID: Subject: Re: [PATCH v2 0/2] Fix console probe delay when stdout-path isn't set To: Greg Kroah-Hartman Cc: Saravana Kannan , "Rafael J. Wysocki" , Laurentiu Tudor , Jiri Slaby , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Joel Stanley , Andrew Jeffery , Nicolas Saenz Julienne , Broadcom internal kernel review list , Florian Fainelli , Ray Jui , Scott Branden , Al Cooper , Andy Shevchenko , Paul Cercueil , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Tobias Klauser , Russell King , Vineet Gupta , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Alexander Shiyan , Baruch Siach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Taichi Sugaya , Takao Orito , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Andy Gross , Bjorn Andersson , Pali Rohar , Andreas Farber , Manivannan Sadhasivam , Krzysztof Kozlowski , Alim Akhtar , Laxman Dewangan , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , "David S. Miller" , Hammer Hsieh , Peter Korsgaard , Timur Tabi , Michal Simek , Rob Herring , sascha hauer , peng fan , kevin hilman , ulf hansson , len brown , pavel machek , joerg roedel , will deacon , andrew lunn , heiner kallweit , eric dumazet , jakub kicinski , paolo abeni , linus walleij , hideaki yoshifuji , david ahern , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-actions@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, sparclinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Mon, Sep 19, 2022 at 1:44 AM Greg Kroah-Hartman wrote: > > On Sun, Sep 18, 2022 at 08:44:27PM -0700, Olof Johansson wrote: > > On Tue, Aug 23, 2022 at 8:37 AM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Jun 30, 2022 at 06:26:38PM -0700, Saravana Kannan wrote: > > > > These patches are on top of driver-core-next. > > > > > > > > Even if stdout-path isn't set in DT, this patch should take console > > > > probe times back to how they were before the deferred_probe_timeout > > > > clean up series[1]. > > > > > > Now dropped from my queue due to lack of a response to other reviewer's > > > questions. > > > > What happened to this patch? I have a 10 second timeout on console > > probe on my SiFive Unmatched, and I don't see this flag being set for > > the serial driver. In fact, I don't see it anywhere in-tree. I can't > > seem to locate another patchset from Saravana around this though, so > > I'm not sure where to look for a missing piece for the sifive serial > > driver. > > > > This is the second boot time regression (this one not fatal, unlike > > the Layerscape PCIe one) from the fw_devlink patchset. > > > > Greg, can you revert the whole set for 6.0, please? It's obviously > > nowhere near tested enough to go in and I expect we'll see a bunch of > > -stable fixups due to this if we let it remain in. > > What exactly is "the whole set"? I have the default option fix queued > up and will send that to Linus later this week (am traveling back from > Plumbers still), but have not heard any problems about any other issues > at all other than your report. I stand corrected in this case, the issue on the Hifive Unmatched was a regression due to a PWM clock change -- I just sent a patch for that (serial driver fix). So it seems like as long as the fw_devlink.strict=1 patch is reverted, things are back to a working state here. I still struggle with how the fw_devlink patchset is expected to work though, since DT is expected to describe the hardware configuration, and it has no knowledge of whether there are drivers that will be bound to any referenced supplier devnodes. It's not going to work well to assume that they will always be bound, and to add 10 second timeouts for those cases isn't a good solution. Seems like the number of special cases will keep adding up. The whole design feels like it's falling short, and it's been patched here and there to deal with the shortcomings, instead of revisiting the full solution. (The patches are the console one, and another to deal with nfsroot boots). As long as it doesn't keep regressing others, I suppose the work to redesign it can happen in-tree, but it's not usually how we try to do it for new functionality. Especially since it's still being iterated on (with active patch sets posted around -rc1 for improvements). Oh, and one more thing for the future -- the main patch that changes behavior due to dependency tracking is 2f8c3ae8288e, named "driver core: Add wait_for_init_devices_probe helper function". It's easy to overlook this when looking at a list of patches since it's said to just introduce a helper. -Olof