From: Dave Airlie <airlied@gmail.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: airlied@linux.ie, daniel@ffwll.ch,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [GIT PULL] exynos-drm-fixes
Date: Fri, 24 Nov 2023 11:14:26 +1000 [thread overview]
Message-ID: <CAPM=9txk2nqYykd5shh3Ux7Jff8hweQnhpNUtYmT9nbcKrHdsA@mail.gmail.com> (raw)
In-Reply-To: <20231120225537.1270358-1-inki.dae@samsung.com>
On Tue, 21 Nov 2023 at 09:00, Inki Dae <inki.dae@samsung.com> wrote:
>
> Hi Dave and Daniel,
>
> Two fixups - fixing a potential error pointer dereference and wrong
> error checking.
Hi Inki,
This fails to build on arm32, and it seems one of the fixes is wrong
[airlied@dreadlord drm-fixes]$ make ARCH=arm
CROSS_COMPILE=arm-linux-gnu- O=../../arm-build-fixes/ -j16
make[1]: Entering directory '/home/airlied/devel/kernel/arm-build-fixes'
GEN Makefile
CALL /home/airlied/devel/kernel/dim/drm-fixes/scripts/checksyscalls.sh
CC [M] drivers/gpu/drm/exynos/exynos_drm_dma.o
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:
In function ‘exynos_drm_register_dma’:
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:119:40:
error: passing argument 1 of ‘PTR_ERR’ makes pointer from integer
without a cast [-Werror=int-conversion]
119 | return PTR_ERR(-ENODEV);
In file included from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/string.h:9,
from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-mapping.h:7,
from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-map-ops.h:9,
from
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:7:
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/err.h:49:61:
note: expected ‘const void *’ but argument is of type ‘int’
49 | static inline long __must_check PTR_ERR(__force const void *ptr)
| ~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors
I think it should just be return -ENODEV, since the function returns an int.
Please fix it up and resend.
Thanks,
Dave.
>
> Ps. regarding the first patch, I had sent a GIT-PULL[1] but it seems
> you missed.
> [1] https://lore.kernel.org/dri-devel/20231006040950.4397-1-inki.dae@samsung.com/T/#u
>
> Please kindly let me know if there is any problem.
>
> Thanks,
> Inki Dae
>
> The following changes since commit 98b1cc82c4affc16f5598d4fa14b1858671b2263:
>
> Linux 6.7-rc2 (2023-11-19 15:02:14 -0800)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos tags/exynos-drm-fixes-for-v6.7-rc3
>
> for you to fetch changes up to a30ba4bd7cdb5726d86a557c5df8df71c7bc7fad:
>
> drm/exynos: fix a wrong error checking (2023-11-21 07:41:11 +0900)
>
> ----------------------------------------------------------------
> Two fixups
> - Fix a potential error pointer dereference by checking the return value
> of exynos_drm_crtc_get_by_type() function before accessing to crtc
> object.
> - Fix a wrong error checking in exynos_drm_dma.c modules, which was reported
> by Dan[1]
>
> [1] https://lore.kernel.org/all/33e52277-1349-472b-a55b-ab5c3462bfcf@moroto.mountain/
>
> ----------------------------------------------------------------
> Inki Dae (1):
> drm/exynos: fix a wrong error checking
>
> Xiang Yang (1):
> drm/exynos: fix a potential error pointer dereference
>
> drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +++-----
> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++
> 2 files changed, 5 insertions(+), 5 deletions(-)
next prev parent reply other threads:[~2023-11-24 1:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231120225538epcas1p205a656dfe9771fc992ee1a6756ca67d3@epcas1p2.samsung.com>
2023-11-20 22:55 ` [GIT PULL] exynos-drm-fixes Inki Dae
2023-11-24 1:14 ` Dave Airlie [this message]
2024-01-22 7:24 Inki Dae
-- strict thread matches above, loose matches on Subject: below --
2023-10-06 4:09 Inki Dae
2023-06-07 4:31 Inki Dae
2023-05-15 8:39 Inki Dae
2022-06-14 14:13 Inki Dae
[not found] <CGME20220210105530epcas1p2a8812b767cecfc06c068bf8aba8b9cb5@epcas1p2.samsung.com>
2022-02-10 11:07 ` Inki Dae
2022-02-22 9:27 ` Inki Dae
2021-09-28 7:41 Inki Dae
2021-10-01 16:51 ` Daniel Vetter
[not found] <CGME20210520033819epcas1p4aef9997d933b28551b7bd2db754328b8@epcas1p4.samsung.com>
2021-05-20 3:47 ` Inki Dae
[not found] <CGME20210329111202epcas1p265fd87320ede9688b4d80b408159a8ce@epcas1p2.samsung.com>
2021-03-29 11:20 ` Inki Dae
[not found] <CGME20201124021344epcas1p35cdaad81e2682f4b59ae3f611e6176ea@epcas1p3.samsung.com>
2020-11-24 2:21 ` Inki Dae
2020-08-26 7:15 Inki Dae
[not found] <CGME20200629015359epcas1p23157f5c5c4468ed2c09ce894bcd6d932@epcas1p2.samsung.com>
2020-06-29 1:59 ` Inki Dae
[not found] <CGME20200302052126epcas1p21d95dcf8a7e458a2332f0532cc2f6e3e@epcas1p2.samsung.com>
2020-03-02 5:25 ` Inki Dae
[not found] <CGME20191219000323epcas1p4e611fadbe0280766b75ac01af5c68587@epcas1p4.samsung.com>
2019-12-19 0:06 ` Inki Dae
[not found] <CGME20190802083122epcas1p298fb8295a77e3adfa839eec619318591@epcas1p2.samsung.com>
2019-08-02 8:33 ` Inki Dae
2019-08-02 15:11 ` Daniel Vetter
[not found] <CGME20190321095657epcas1p45a32777dd62b9e11664a7547e6cd18ae@epcas1p4.samsung.com>
2019-03-21 9:57 ` Inki Dae
[not found] <CGME20181105084853epcas2p4da21de0c2b4eea224eafa33ad2927322@epcas2p4.samsung.com>
2018-11-05 8:48 ` Inki Dae
[not found] <CGME20181001022506epcas2p37545aaab29371eb75cacb56aca24fb72@epcas2p3.samsung.com>
2018-10-01 2:24 ` Inki Dae
[not found] <CGME20180702061402epcas2p4d7270720b0176845133c41e21f784896@epcas2p4.samsung.com>
2018-07-02 6:14 ` [GIT PULL]: exynos-drm-fixes Inki Dae
[not found] <CGME20180509002644epcas1p109a7cedee1657e6bb4e3bd00c7e14f1d@epcas1p1.samsung.com>
2018-05-09 0:26 ` [GIT PULL] exynos-drm-fixes Inki Dae
[not found] <CGME20180420060157epcas2p1ba05f61666f38579990553940336b6ff@epcas2p1.samsung.com>
2018-04-20 6:01 ` Inki Dae
[not found] <CGME20180318235804epcas1p1b99ccfde868cb05157ad768117ea704c@epcas1p1.samsung.com>
2018-03-18 23:58 ` Inki Dae
[not found] <CGME20180220042517epcas2p292d31d0c5f0b147b640775a99de04ff4@epcas2p2.samsung.com>
2018-02-20 4:25 ` Inki Dae
[not found] <CGME20171207021757epcas1p4a5d5acadbddee99b174908aa831eeb3b@epcas1p4.samsung.com>
2017-12-07 2:17 ` Inki Dae
[not found] <CGME20171015230125epcas2p3a74e507c3d2627500f5179ab83117e33@epcas2p3.samsung.com>
2017-10-15 23:01 ` Inki Dae
[not found] <CGME20170920100341epcas1p4cb241e784f843a95853ec019d115c4a8@epcas1p4.samsung.com>
2017-09-20 10:03 ` Inki Dae
[not found] <CGME20170727030554epcas1p2a6a263885bfc1f82dfcdb194f6a7037f@epcas1p2.samsung.com>
2017-07-27 3:05 ` Inki Dae
[not found] <CGME20170116090314epcas1p3be0bda8ccc11f3be5475bb405a24a246@epcas1p3.samsung.com>
2017-01-16 9:03 ` Inki Dae
2016-11-22 5:48 Inki Dae
2016-11-24 23:59 ` Dave Airlie
2016-11-29 14:20 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9txk2nqYykd5shh3Ux7Jff8hweQnhpNUtYmT9nbcKrHdsA@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).