From: Leonard Crestez <leonard.crestez@nxp.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
"krzk@kernel.org" <krzk@kernel.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"heiko@sntech.de" <heiko@sntech.de>,
"lukasz.luba@arm.com" <lukasz.luba@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"a.swigon@samsung.com" <a.swigon@samsung.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"kgene@kernel.org" <kgene@kernel.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v2 02/11] PM / devfreq: Remove devfreq_get_devfreq_by_phandle function
Date: Fri, 20 Dec 2019 01:40:42 +0000 [thread overview]
Message-ID: <VI1PR04MB7023160888F88B5800A90189EE2D0@VI1PR04MB7023.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 46e629e0-fee4-21a6-3baa-f347ff6417d8@samsung.com
On 2019-12-20 2:54 AM, Chanwoo Choi wrote:
> On 12/20/19 9:46 AM, Leonard Crestez wrote:
>> On 20.12.2019 02:18, Chanwoo Choi wrote:
>>> Previously, devfreq core support 'devfreq' property in order to get
>>> the devfreq device by phandle. But, 'devfreq' property name is not proper
>>> on devicetree binding because this name doesn't mean the any h/w attribute.
>>>
>>> The devfreq core hand over the right to decide the property name
>>> for getting the devfreq device on devicetree. Each devfreq driver
>>> will decide the property name on devicetree binding and then get
>>> the devfreq device by using devfreq_get_devfreq_by_node().
>>>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>> drivers/devfreq/devfreq.c | 35 -----------------------------------
>>> drivers/devfreq/exynos-bus.c | 12 +++++++++++-
>>> include/linux/devfreq.h | 8 --------
>>> 3 files changed, 11 insertions(+), 44 deletions(-)
>>>
>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>>> index cb8ca81c8973..c3d3c7c802a0 100644
>>> --- a/drivers/devfreq/devfreq.c
>>> +++ b/drivers/devfreq/devfreq.c
>>> @@ -991,48 +991,13 @@ struct devfreq *devfreq_get_devfreq_by_node(struct device_node *node)
>>>
>>> return ERR_PTR(-ENODEV);
>>> }
>>> -
>>> -/*
>>> - * devfreq_get_devfreq_by_phandle - Get the devfreq device from devicetree
>>> - * @dev - instance to the given device
>>> - * @index - index into list of devfreq
>>> - *
>>> - * return the instance of devfreq device
>>> - */
>>> -struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, int index)
>>> -{
>>> - struct device_node *node;
>>> - struct devfreq *devfreq;
>>> -
>>> - if (!dev)
>>> - return ERR_PTR(-EINVAL);
>>> -
>>> - if (!dev->of_node)
>>> - return ERR_PTR(-EINVAL);
>>> -
>>> - node = of_parse_phandle(dev->of_node, "devfreq", index);
>>> - if (!node)
>>> - return ERR_PTR(-ENODEV);
>>> -
>>> - devfreq = devfreq_get_devfreq_by_node(node);
>>> - of_node_put(node);
>>> -
>>> - return devfreq;
>>> -}
>>> -
>>> #else
>>> struct devfreq *devfreq_get_devfreq_by_node(struct device_node *node)
>>> {
>>> return ERR_PTR(-ENODEV);
>>> }
>>> -
>>> -struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, int index)
>>> -{
>>> - return ERR_PTR(-ENODEV);
>>> -}
>>> #endif /* CONFIG_OF */
>>> EXPORT_SYMBOL_GPL(devfreq_get_devfreq_by_node);
>>> -EXPORT_SYMBOL_GPL(devfreq_get_devfreq_by_phandle);
>>>
>>> /**
>>> * devm_devfreq_remove_device() - Resource-managed devfreq_remove_device()
>>> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
>>> index 7f5917d59072..1bc4e3c81115 100644
>>> --- a/drivers/devfreq/exynos-bus.c
>>> +++ b/drivers/devfreq/exynos-bus.c
>>> @@ -86,6 +86,16 @@ static int exynos_bus_get_event(struct exynos_bus *bus,
>>> return ret;
>>> }
>>>
>>> +static struct devfreq *exynos_bus_get_parent_devfreq(struct device_node *np)
>>> +{
>>> + struct device_node *node = of_parse_phandle(np, "devfreq", 0);
>>> +
>>> + if (!node)
>>> + return ERR_PTR(-ENODEV);
>>> +
>>> + return devfreq_get_devfreq_by_node(node);
>>
>> You need to call of_node_put(node) here and in several other places.
>>
>> The old devfreq_get_devfreq_by_phandle API handled this internally but
>> devfreq_get_devfreq_by_node doesn't.
>
> Thanks. I'll fix it.
>
>>
>> Maybe the _by_phandle API could be kept and just take the property name
>> instead of always using "devfreq"?
>
> Do you mean like below?
> devfreq_get_devfreq_by_phandle(struct device *dev, int index)
> -> devfreq_get_devfreq_by_phandle(struct device *dev, char *property_name, int index)
>
> In case of devfreq-event.c,
> struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
> struct device *dev,
> char property_name,
> int index)
> int devfreq_event_get_edev_count(struct device *dev, char *property_name)
Yes. These helpers would avoid the need for explicit of_node_put.
>
>>
>>> +}
>>> +
>>> /*
>>> * devfreq function for both simple-ondemand and passive governor
>>> */
>>> @@ -353,7 +363,7 @@ static int exynos_bus_profile_init_passive(struct exynos_bus *bus,
>>> profile->exit = exynos_bus_passive_exit;
>>>
>>> /* Get the instance of parent devfreq device */
>>> - parent_devfreq = devfreq_get_devfreq_by_phandle(dev, 0);
>>> + parent_devfreq = exynos_bus_get_parent_devfreq(dev->of_node);
>>> if (IS_ERR(parent_devfreq))
>>> return -EPROBE_DEFER;
>>>
>>> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
>>> index 1dccc47acbce..a4351698fb64 100644
>>> --- a/include/linux/devfreq.h
>>> +++ b/include/linux/devfreq.h
>>> @@ -254,8 +254,6 @@ extern void devm_devfreq_unregister_notifier(struct device *dev,
>>> struct notifier_block *nb,
>>> unsigned int list);
>>> extern struct devfreq *devfreq_get_devfreq_by_node(struct device_node *node);
>>> -extern struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
>>> - int index);
>>>
>>> #if IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)
>>> /**
>>> @@ -413,12 +411,6 @@ static inline struct devfreq *devfreq_get_devfreq_by_node(struct device_node *no
>>> return ERR_PTR(-ENODEV);
>>> }
>>>
>>> -static inline struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
>>> - int index)
>>> -{
>>> - return ERR_PTR(-ENODEV);
>>> -}
>>> -
>>> static inline int devfreq_update_stats(struct devfreq *df)
>>> {
>>> return -EINVAL;
next prev parent reply other threads:[~2019-12-20 1:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191220001759epcas1p131a41a619847d80c64470f7c1920121f@epcas1p1.samsung.com>
2019-12-20 0:24 ` [PATCH v2 00/11] PM / devfreq: Remove deprecated 'devfreq' and 'devfreq-events' properties Chanwoo Choi
[not found] ` <CGME20191220001759epcas1p4bbbcf6a84c09229db0ddae86be294405@epcas1p4.samsung.com>
2019-12-20 0:24 ` [PATCH v2 01/11] PM / devfreq: Add devfreq_get_devfreq_by_node function Chanwoo Choi
2020-01-09 9:47 ` Lukasz Luba
[not found] ` <CGME20191220001759epcas1p4ce1c2017937a35de84eab720b9732df0@epcas1p4.samsung.com>
2019-12-20 0:24 ` [PATCH v2 02/11] PM / devfreq: Remove devfreq_get_devfreq_by_phandle function Chanwoo Choi
2019-12-20 0:46 ` Leonard Crestez
2019-12-20 1:00 ` Chanwoo Choi
2019-12-20 1:40 ` Leonard Crestez [this message]
2019-12-20 2:14 ` Chanwoo Choi
2020-01-09 10:37 ` Lukasz Luba
2020-01-09 10:54 ` Chanwoo Choi
2020-01-09 10:57 ` Lukasz Luba
[not found] ` <CGME20191220001759epcas1p1fc0e5019514f7c99606347432d66bfd0@epcas1p1.samsung.com>
2019-12-20 0:24 ` [PATCH v2 03/11] PM / devfreq: event: Add devfreq_event_get_edev_by_node function Chanwoo Choi
[not found] ` <CGME20191220001759epcas1p3051f7916542b7234aac5273e0baab83b@epcas1p3.samsung.com>
2019-12-20 0:24 ` [PATCH v2 04/11] dt-bindings: devfreq: exynos-bus: Replace deprecated 'devfreq' and 'devfreq-events' property Chanwoo Choi
2019-12-20 8:43 ` Krzysztof Kozlowski
[not found] ` <CGME20191220001759epcas1p495fc9cdb6f2bd86abf63d16f61e68804@epcas1p4.samsung.com>
2019-12-20 0:24 ` [PATCH v2 05/11] dt-bindings: devfreq: rk3399_dmc: Replace deprecated " Chanwoo Choi
[not found] ` <CGME20191220001800epcas1p364322170854fdd171c43f6b1de2b61a4@epcas1p3.samsung.com>
2019-12-20 0:24 ` [PATCH v2 06/11] dt-bindings: memory: exynos5422-dmc: Replace the " Chanwoo Choi
[not found] ` <CGME20191220001800epcas1p3accefc4384d9503481311f25f5794cb8@epcas1p3.samsung.com>
2019-12-20 0:24 ` [PATCH v2 07/11] PM / devfreq: exynos-bus: Replace the deprecated 'devfreq' and " Chanwoo Choi
[not found] ` <CGME20191220001800epcas1p383927f73060e0e9aaad2fd9aaf881b6d@epcas1p3.samsung.com>
2019-12-20 0:24 ` [PATCH v2 08/11] PM / devfreq: rk3399_dmc: Replace the deprecated " Chanwoo Choi
[not found] ` <CGME20191220001800epcas1p41ab059757aeec99060cb4f47b0f48ac0@epcas1p4.samsung.com>
2019-12-20 0:24 ` [PATCH v2 09/11] memory: samsung: exynos5422-dmc: " Chanwoo Choi
[not found] ` <CGME20191220001800epcas1p2f2dfd9d24e275425b07a06bcdeb4aba9@epcas1p2.samsung.com>
2019-12-20 0:24 ` [PATCH v2 10/11] ARM: dts: exynos: Replace deprecated property for Exynos bus and DMC Chanwoo Choi
[not found] ` <CGME20191220001800epcas1p13d5f4ff181c10a118e151a86891a7130@epcas1p1.samsung.com>
2019-12-20 0:24 ` [PATCH v2 11/11] arm64: dts: exynos: Replace deprecated property for Exynos bus on TM2 Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB7023160888F88B5800A90189EE2D0@VI1PR04MB7023.eurprd04.prod.outlook.com \
--to=leonard.crestez@nxp.com \
--cc=a.swigon@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).