From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6414C433FE for ; Tue, 28 Sep 2021 09:52:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADC0C610E5 for ; Tue, 28 Sep 2021 09:52:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240044AbhI1JyS (ORCPT ); Tue, 28 Sep 2021 05:54:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239989AbhI1JyR (ORCPT ); Tue, 28 Sep 2021 05:54:17 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EC20C061575 for ; Tue, 28 Sep 2021 02:52:38 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id t16-20020a1c7710000000b003049690d882so1670068wmi.5 for ; Tue, 28 Sep 2021 02:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=GuHPLheShRlbOpi51aLOYmcYsG+bNOOwfr/gYWEALaw=; b=o1TDOq0LiwPkSupy54hfguLkuJ5+Ii8Gk8YO5lZ4D7rYxHjsaslijOA6FSKwUud29j lJRoUv3tEo7jaGRXV+GCMcS09fd6xioukRVOxvBPWjgHTBNKHvBbmOl4KMo2gMroKnF6 jMqSklqxOsMalnsJJuUKLSejLeJYtBQuCnTtGdQUYiGgQkkibe8bhvhZBLOLnX8KCG1s hDi4QBQOk9xhLHaF9Hjeq24VOzSj70+VjQt9YUnG25ssF2nBDcnlyHAlF5gDhgF8EZyv l74Tzkhgm95uSzmZ0PjDAkrLP+tUXzKYHA5WWJs8GlhQhi15q3RAsKZHmgnAbW3rkaeq 87AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=GuHPLheShRlbOpi51aLOYmcYsG+bNOOwfr/gYWEALaw=; b=n713g+Ok/xgZJTcdv+jVpIfLnKKoceCyWw/ga1D4/GGBCOlLCPw4kcVyVVF/thn7Tk tjAfni/YR3oPFTILSskXJwuWggZlWEkb9zck5O7UEzRSACUoIoVGBpr8yO7QnBwn+K6X X8H3yEjrWRdhpm3zR/cglLhlghWwI2phrwjBMZag5l/FEB+tEQ6TpP05iuzaquCd8SWW BJwSQAhmbsIlOncUdsauc0e8woh/8ipBKu8uBsQ9ZMCR+rq3yrmFLDtq+o4G8YFP9kFa elbw3gm4ZpOkc9Muwk1Hi/zXiL+wWCQWmkI4ijWHN+G4U0UD3VB/5YrDbDDMNm8pfuCI 2N2A== X-Gm-Message-State: AOAM530fKohiILOI+6Y2q6f9PJN/AZHMRl2SUfznBoMOprEgEJy+wexG zEuptDU+8ZaOt0cMnulHWJq8vnpk1urTXQ== X-Google-Smtp-Source: ABdhPJzugmyfSJ6wM5od5emO0tsj0/opG3+kwzLDnnw74iHAPISXEdmJeQu+mCnvTAje7ebw3Y9mNQ== X-Received: by 2002:a1c:2289:: with SMTP id i131mr3722335wmi.34.1632822756859; Tue, 28 Sep 2021 02:52:36 -0700 (PDT) Received: from google.com ([95.148.6.233]) by smtp.gmail.com with ESMTPSA id l17sm642980wrx.24.2021.09.28.02.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 02:52:36 -0700 (PDT) Date: Tue, 28 Sep 2021 10:52:34 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Chanwoo Choi , Bartlomiej Zolnierkiewicz , Liam Girdwood , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Rob Herring Subject: Re: [RESEND PATCH v2 4/4] mfd: max14577: Do not enforce (incorrect) interrupt trigger type Message-ID: References: <20210602110445.33536-1-krzysztof.kozlowski@canonical.com> <20210602110445.33536-4-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210602110445.33536-4-krzysztof.kozlowski@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, 02 Jun 2021, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski > > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Maxim 14577/77836 datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > The interrupt line is shared between PMIC and charger driver, so using > level sensitive interrupt is here especially important to avoid races. > With an edge configuration in case if first PMIC signals interrupt > followed shortly after by the RTC, the interrupt might not be yet > cleared/acked thus the second one would not be noticed. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Rob Herring > > --- > > Changes since v1: > 1. Add Ack > --- > Documentation/devicetree/bindings/mfd/max14577.txt | 4 ++-- > drivers/mfd/max14577.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog