From: Jaehoon Chung <jh80.chung@samsung.com>
To: Alim Akhtar <alim.akhtar@samsung.com>,
Pankaj Dubey <pankaj.dubey@samsung.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org
Cc: krzk@kernel.org, kgene@kernel.org, jingoohan1@gmail.com,
bhelgaas@google.com, sanath@samsung.com,
Niyas Ahmed S T <niyas.ahmed@samsung.com>,
CPGS <cpgs@samsung.com>
Subject: Re: [PATCH] PCI: exynos: refactor exynos pcie driver
Date: Tue, 27 Dec 2016 19:18:33 +0900 [thread overview]
Message-ID: <a4200793-19dd-3727-505c-5840a8ec72bb@samsung.com> (raw)
In-Reply-To: <58620B5A.1060900@samsung.com>
Dear Alim,
On 12/27/2016 03:34 PM, Alim Akhtar wrote:
> Hi Jaehoon,
>
[snip]
>>
>> Ah. Right..And i'm doing the refactoring to reuse the current pci-exynos.c.
> There is a nice refactoring patch posted by Pankaj recently @
> https://lkml.org/lkml/2016/12/23/73
> I would suggest you to rebase your work on this top.
Well, i don't think so. Pankaj's patch might be good way..but i can't agree about a few point.
If based on Pankaj's patch, it's more complex..
why put the ops callback for getting clock and mem resource?
If PHY generic framework is used, it's unnecessary. because it needs to get elbi and dbi resources.
clock resources("pcie" and "pcie_bus") are general things.
If Pankaj's patch is applied, also need to make the exynos5433_pcie_* callback functions?
It doesn't make sense.
I want to know maintainer's opinion..we can just touch a little for supporting All Exynos SoCs.
Best Regards,
Jaehoon Chung
>
>> Maybe..Today or Tomorrow..I will send the patches..At that time, could you also check them?
>> Any comments might be helpful to me! :)
>>
> Will wait for you patches :-)
>
>> Best Regards,
>> Jaehoon Chung
>>
[snip]
next prev parent reply other threads:[~2016-12-27 10:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161223105411epcas1p3727f726e757ec6c6d7bff04a9af40077@epcas1p3.samsung.com>
2016-12-23 10:56 ` [PATCH] PCI: exynos: refactor exynos pcie driver Pankaj Dubey
2016-12-23 18:37 ` Jingoo Han
2016-12-27 3:27 ` Pankaj Dubey
2016-12-24 9:25 ` Krzysztof Kozlowski
2016-12-26 9:02 ` Jaehoon Chung
2016-12-26 9:06 ` Jaehoon Chung
2016-12-26 9:46 ` Alim Akhtar
2016-12-27 1:09 ` Jaehoon Chung
2016-12-27 2:12 ` Alim Akhtar
2016-12-27 2:30 ` Jaehoon Chung
2016-12-27 6:34 ` Alim Akhtar
2016-12-27 10:18 ` Jaehoon Chung [this message]
2016-12-28 3:10 ` Pankaj Dubey
2016-12-28 5:25 ` Jaehoon Chung
2016-12-26 14:43 ` Jingoo Han
2016-12-27 1:12 ` Jaehoon Chung
2016-12-27 4:21 ` Pankaj Dubey
2016-12-27 13:35 ` Bartlomiej Zolnierkiewicz
2016-12-28 3:13 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4200793-19dd-3727-505c-5840a8ec72bb@samsung.com \
--to=jh80.chung@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=bhelgaas@google.com \
--cc=cpgs@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=niyas.ahmed@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=sanath@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).