From: Andrzej Hajda <a.hajda@samsung.com>
To: Andi Shyti <andi.shyti@samsung.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v2 2/3] Input: add support for the STMicroelectronics FingerTip touchscreen
Date: Thu, 16 Mar 2017 09:22:16 +0100 [thread overview]
Message-ID: <a78e77c3-7bc5-95a8-fbf9-31baf91cdd56@samsung.com> (raw)
In-Reply-To: <20170210021721.12218-3-andi.shyti@samsung.com>
Hi Andi,
On 10.02.2017 03:17, Andi Shyti wrote:
(...)
> +
> + err = devm_request_threaded_irq(&client->dev, client->irq,
> + NULL, stmfts_irq_handler,
> + IRQF_ONESHOT | IRQF_TRIGGER_LOW,
> + "stmfts_irq", sdata);
> + if (err)
> + return err;
> +
> + /*
> + * Disable irq they, they are not needed at this stage.
> + * One possible case when an IRQ can be already rased is e.g. if the
> + * regulator is set as always on and the stmfts device sends an IRQ as
> + * soon as it gets powered, de-synchronizing the power on sequence.
> + * During power on, the device will be reset and all the initialization
> + * IRQ will be resent.
> + */
> + disable_irq(sdata->client->irq);
It is safer to set:
irq_set_status_flags(client->irq, IRQ_NOAUTOEN);
before devm_request_threaded_irq
Regards
Andrzej
next prev parent reply other threads:[~2017-03-16 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170210021728epcas1p3864184ab4ffe6e4cf6614984e83e307a@epcas1p3.samsung.com>
2017-02-10 2:17 ` [PATCH v2 0/3] STM FingerTip S touchscreen support for TM2 board Andi Shyti
[not found] ` <CGME20170210021728epcas5p46d0256d507157cd4387b707ec616c1d1@epcas5p4.samsung.com>
2017-02-10 2:17 ` [PATCH v2 1/3] Input: add STMicroelectronics FingerTip touchscreen driver Andi Shyti
2017-02-16 2:13 ` Rob Herring
[not found] ` <CGME20170210021729epcas1p3e11cade2daa21d2dd23839975e29acb6@epcas1p3.samsung.com>
2017-02-10 2:17 ` [PATCH v2 2/3] Input: add support for the STMicroelectronics FingerTip touchscreen Andi Shyti
2017-03-07 23:41 ` Chanwoo Choi
2017-03-10 11:43 ` Andi Shyti
2017-03-16 8:22 ` Andrzej Hajda [this message]
[not found] ` <CGME20170210021729epcas5p4101902873e65e0a8faeb2f9cbea5843c@epcas5p4.samsung.com>
2017-02-10 2:17 ` [PATCH v2 3/3] arm64: dts: exynos: Add stmfts touchscreen node for TM2 and TM2E Andi Shyti
[not found] ` <20170210021721.12218-4-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-02-10 13:39 ` Krzysztof Kozlowski
2017-03-07 19:55 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78e77c3-7bc5-95a8-fbf9-31baf91cdd56@samsung.com \
--to=a.hajda@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=javier@osg.samsung.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).