linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, willy.mh.wolff.ml@gmail.com,
	k.konieczny@samsung.com, chanwoo@kernel.org,
	myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
	s.nawrocki@samsung.com, kgene@kernel.org
Subject: Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold
Date: Fri, 10 Jul 2020 15:00:37 +0100	[thread overview]
Message-ID: <b0ecbdd9-f445-b2f7-755a-cbc10cb1e56c@arm.com> (raw)
In-Reply-To: <ef88644a-a75d-82c0-8b60-eb2810c68f58@samsung.com>



On 7/10/20 2:49 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> On 7/10/20 2:56 PM, Lukasz Luba wrote:
>>
>>
>> On 7/10/20 1:45 PM, Krzysztof Kozlowski wrote:
>>> On Fri, Jul 10, 2020 at 09:34:45AM +0100, Lukasz Luba wrote:
>>>> Hi Chanwoo,
>>>>
>>>> On 7/9/20 5:08 AM, Chanwoo Choi wrote:
>>>>> Hi Lukasz,
>>>>>
>>>>> On 7/9/20 12:34 AM, Lukasz Luba wrote:
>>>>>> In order to react faster and make better decisions under some workloads,
>>>>>> benchmarking the memory subsystem behavior, adjust the polling interval
>>>>>> and upthreshold value used by the simple_ondemand governor.
>>>>>>
>>>>>> Reported-by: Willy Wolff <willy.mh.wolff.ml@gmail.com>
>>>>>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>>>>>> ---
>>>>>>     drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
>>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
>>>>>> index 93e9c2429c0d..e03ee35f0ab5 100644
>>>>>> --- a/drivers/memory/samsung/exynos5422-dmc.c
>>>>>> +++ b/drivers/memory/samsung/exynos5422-dmc.c
>>>>>> @@ -1466,10 +1466,10 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
>>>>>>              * Setup default thresholds for the devfreq governor.
>>>>>>              * The values are chosen based on experiments.
>>>>>>              */
>>>>>> -        dmc->gov_data.upthreshold = 30;
>>>>>> +        dmc->gov_data.upthreshold = 10;
>>>>>>             dmc->gov_data.downdifferential = 5;
>>>>>> -        exynos5_dmc_df_profile.polling_ms = 500;
>>>>>> +        exynos5_dmc_df_profile.polling_ms = 100;
>>>>>>         }
>>>>>>
>>>>>
>>>>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>>
>>>>
>>>> Thank you for the review. Do you think this patch could go through
>>>> your tree together with your patches?
>>>>
>>>> I don't know Krzysztof's opinion about the patch 2/2, but
>>>> I would expect, assuming the patch itself is correct, he would
>>>> like to take it into his next/dt branch.
>>>
>>> In the cover letter you mentioned that this is a follow up for the
>>> Chanwoo's patchset. But are these patches really depending on it? Can
>>> they be picked up independently?
>>
>>
>> They are not heavily dependent on Chanwoo's patches.
>> Yes, they can be picked up independently.
> 
> Hmmm, are you sure?

In a sense: in two phases (first the Chanwoo's changes land into
devfreq, then when Krzysztof prepares his topic branches for
arm soc, I assumed Chanwoo's patches are mainline and will be there
already).

> 
> Sure, they will apply fine but without Chanwoo's patches won't they
> cause the dmc driver to use using polling mode with deferred timer
> (unintended/bad behavior) instead of IRQs (current behavior) or
> polling mode with delayed timer (future behavior)?

I was assuming that it will take longer, when Krzysztof is going to pick
patch 2/2, definitely after a while (and it could be also the case for
patch 1/1 if Krzysztof was going to take it).

I think there is no rush and it can go in two phases.

Good point Bartek for clarifying this. I wasn't clear in the messages.
Thank you for keeping eye on this.

Regards,
Lukasz


> 
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
> 
>> I just wanted to mention that the patch 1/2 was produced on the
>> code base which had already applied Chanwoo's patch for DMC.
>> If you like to take both 1/2 and 2/2 into your tree, it's good.
>>
>> Thank you for having a look on this.
>>
>> Regards,
>> Lukasz
>>
>>
>>>
>>> The DTS patch must go through arm soc, so I will take it. If it really
>>> depends on driver changes, then it has to wait for next release.
>>>
>>> Best regards,
>>> Krzysztof
>>>
> 

  reply	other threads:[~2020-07-10 14:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 15:34 [PATCH 0/2] Exynos5422 DMC: adjust to new devfreq monitoring mechanism Lukasz Luba
2020-07-08 15:34 ` [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold Lukasz Luba
2020-07-09  4:08   ` Chanwoo Choi
2020-07-10  8:34     ` Lukasz Luba
2020-07-10 12:45       ` Krzysztof Kozlowski
2020-07-10 12:56         ` Lukasz Luba
2020-07-10 13:07           ` Krzysztof Kozlowski
2020-07-10 13:49           ` Bartlomiej Zolnierkiewicz
2020-07-10 14:00             ` Lukasz Luba [this message]
2020-07-10 14:47               ` Krzysztof Kozlowski
2020-07-10 13:13       ` Marek Szyprowski
2020-07-10 13:19         ` Krzysztof Kozlowski
2020-07-10 13:41           ` Lukasz Luba
2020-07-10 14:49             ` Krzysztof Kozlowski
2020-07-10 15:45               ` Lukasz Luba
2020-07-08 15:34 ` [PATCH 2/2] ARM: dts: exynos: Remove interrupts from DMC controller in Exynos5422 Lukasz Luba
2020-08-17 15:50   ` Krzysztof Kozlowski
2020-08-17 17:17     ` Lukasz Luba
2020-08-21  6:31       ` Krzysztof Kozlowski
2020-08-21  6:32         ` Krzysztof Kozlowski
2020-08-24 11:34           ` Lukasz Luba
2020-10-26 19:57   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0ecbdd9-f445-b2f7-755a-cbc10cb1e56c@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=chanwoo@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=k.konieczny@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=s.nawrocki@samsung.com \
    --cc=willy.mh.wolff.ml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).