From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 836DBC4338F for ; Tue, 17 Aug 2021 10:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 678DD60F38 for ; Tue, 17 Aug 2021 10:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239258AbhHQKHR (ORCPT ); Tue, 17 Aug 2021 06:07:17 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:46008 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239269AbhHQKF5 (ORCPT ); Tue, 17 Aug 2021 06:05:57 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id B0834412B6 for ; Tue, 17 Aug 2021 10:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629194723; bh=GOIsTUQ+gJL63rEPiNcOFHz6lWCZ7WtQFp4xSBwe2Ag=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=KR3OuOLtFVIu4XExacpwX/8dSub2ngtOKv6LCQNweF4Bho7czM20sa/BgRekZufGS xqs6bjy/F+imrKpHycy+QK9ESHEh2hH8nokCgByTQu4fgaRH+rB/QL2Ig76PjRmzIe X1Wq/26umxem1Rq8kxaDGs+Udip/eTqfeOo6KvJMvpBMZxwUDNsJlny47pKlEXBGEO SuBaHxX2G1VdkFQOMtEGLbPYZsB6BmuRTSXKOZSXYXipPJ07E6eSYVfTP6PWGzyoOD 9xbZTBNsbgUC1OIim5HLS051jMCZ8kQUZe6cgJqDfdfjhBxJIJADvx1j1I/EMnhchc KEG3aBIKA7wxQ== Received: by mail-ej1-f71.google.com with SMTP id gg1-20020a170906e281b029053d0856c4cdso5798548ejb.15 for ; Tue, 17 Aug 2021 03:05:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GOIsTUQ+gJL63rEPiNcOFHz6lWCZ7WtQFp4xSBwe2Ag=; b=kL+UZ0C8kEK40Xh6DOq2GaU50im1SCYAwLpD6Dw9exHyjzf+s3Hc7vykN8x6sU7Yqk IGOYIsv8eDyHONptimaS0aeSZ7FrIU8Rhyq0V+mkZ/NWXoMQoZogHTmebQbFHUrZJ+YF yF4aANz1k2FBM4TZv1TkCYZXNyrmPpWTYvRF8OYEbq7fOcIbS/Kw9HVVGEWv+VhFMhmX 3sfSxp6QqkZnni0iwqNtDNDRQ4N759fJw3apavdoyEme8FT/TlkWRlvfGls4aNFWoEDj c3qA6lBD02Z3/LbnFlVVgi7+pVwTQd/BcU8cZ6bNWM3kTymDyarjHYjV9Ok8pL4jHhp6 SerA== X-Gm-Message-State: AOAM533+UMJGCPphGFKmtbZWxdW6qLDG0PWHHlVCfpWEwO2apwXmLso0 75QyatCuFkg4yC+g38+0hta5VMt1TDX7+YSAzecDHZQMalzTEBsoTVclxW3WlufQFjvURlK6nmg q4WWOId4I4pGFHOod60oNRVGyHDl52j5D9MeOzAz3c1s9fgeZ X-Received: by 2002:a05:6402:214d:: with SMTP id bq13mr3229749edb.263.1629194722047; Tue, 17 Aug 2021 03:05:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzC3ptiEqOWsybRDl1sa+LgQ0zWpCdCEsdKyWGPcbPrtTBHxez2xHpr+Za6aNluTlhnkIYe4g== X-Received: by 2002:a05:6402:214d:: with SMTP id bq13mr3229732edb.263.1629194721860; Tue, 17 Aug 2021 03:05:21 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id p23sm559903ejc.19.2021.08.17.03.05.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 03:05:21 -0700 (PDT) Subject: Re: [PATCH 2/2] dt-bindings: rng: convert Samsung Exynos TRNG to dtschema To: Lukasz Stelmach Cc: Thomas Gleixner , Marc Zyngier , Rob Herring , Matt Mackall , Herbert Xu , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org References: <20210811084306.28740-2-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Tue, 17 Aug 2021 12:05:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 17/08/2021 11:55, Lukasz Stelmach wrote: > It was <2021-08-11 śro 10:43>, when Krzysztof Kozlowski wrote: >> Convert Samsung Exynos SoC True Random Number Generator bindings to DT >> schema format using json-schema. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/rng/samsung,exynos5250-trng.txt | 17 ------- >> .../bindings/rng/samsung,exynos5250-trng.yaml | 44 +++++++++++++++++++ >> MAINTAINERS | 2 +- >> 3 files changed, 45 insertions(+), 18 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt >> create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt >> b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt >> deleted file mode 100644 >> index 5a613a4ec780..000000000000 >> --- a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt >> +++ /dev/null >> @@ -1,17 +0,0 @@ >> -Exynos True Random Number Generator >> - >> -Required properties: >> - >> -- compatible : Should be "samsung,exynos5250-trng". >> -- reg : Specifies base physical address and size of the registers map. >> -- clocks : Phandle to clock-controller plus clock-specifier pair. >> -- clock-names : "secss" as a clock name. >> - >> -Example: >> - >> - rng@10830600 { >> - compatible = "samsung,exynos5250-trng"; >> - reg = <0x10830600 0x100>; >> - clocks = <&clock CLK_SSS>; >> - clock-names = "secss"; >> - }; >> diff --git >> a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.yaml >> b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.yaml >> new file mode 100644 >> index 000000000000..a50c34d5d199 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.yaml >> @@ -0,0 +1,44 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: >> https://protect2.fireeye.com/v1/url?k=f38ca35b-ac179a0d-f38d2814-0cc47a31ce52-1faa1ecb65482b8a&q=1&e=8b3490f9-a5fc-4da0-b2ee-7b0aec781403&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Frng%2Fsamsung%2Cexynos5250-trng.yaml%23 >> +$schema: >> https://protect2.fireeye.com/v1/url?k=9409519d-cb9268cb-9408dad2-0cc47a31ce52-12394c4409905980&q=1&e=8b3490f9-a5fc-4da0-b2ee-7b0aec781403&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >> + >> +title: Samsung Exynos SoC True Random Number Generator >> + >> +maintainers: >> + - Krzysztof Kozlowski >> + - Łukasz Stelmach >> + >> +properties: >> + compatible: >> + const: samsung,exynos5250-trng >> + >> + clocks: >> + maxItems: 1 > > How about copying description from above into the description: property? But what to copy? There is no description except generic clock bindings. > >> + >> + clock-names: >> + items: >> + - const: secss >> + >> + reg: >> + maxItems: 1 > > ditto. The same, I have no clue what to copy. It's obvious that reg contains "physical address and size of the registers map". Best regards, Krzysztof