From: Lukasz Stelmach <l.stelmach@samsung.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
jim.cromie@gmail.com, "Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH net-next v14 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Date: Tue, 20 Jul 2021 15:50:21 +0200 [thread overview]
Message-ID: <dleftjlf61nlgi.fsf%l.stelmach@samsung.com> (raw)
In-Reply-To: <20210720123646.2991df22@cakuba> (Jakub Kicinski's message of "Tue, 20 Jul 2021 12:36:46 +0200")
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
It was <2021-07-20 wto 12:36>, when Jakub Kicinski wrote:
> On Mon, 19 Jul 2021 21:28:52 +0200, Łukasz Stelmach wrote:
>> + ax_local->stats =
>> + devm_netdev_alloc_pcpu_stats(&spi->dev,
>> + struct ax88796c_pcpu_stats);
>> + if (!ax_local->stats)
>> + return -ENOMEM;
>> + u64_stats_init(&ax_local->stats->syncp);
>
> ../drivers/net/ethernet/asix/ax88796c_main.c:971:33: warning: incorrect type in argument 1 (different address spaces)
> ../drivers/net/ethernet/asix/ax88796c_main.c:971:33: expected struct u64_stats_sync *syncp
> ../drivers/net/ethernet/asix/ax88796c_main.c:971:33: got struct u64_stats_sync [noderef] __percpu *
>
Fixed, thanks.
Apparently separate u64_stats_init() is not necessary as
netdev_alloc_pcpu_stats() invokes it for_each_possible_cpu.
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2021-07-20 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210719192908eucas1p230d8bc4d30fc1da8d9c9e162b5fc0bff@eucas1p2.samsung.com>
2021-07-19 19:28 ` [PATCH net-next v14 0/3] AX88796C SPI Ethernet Adapter Łukasz Stelmach
[not found] ` <CGME20210719192913eucas1p1dfd7dff3ca85db20ce638c9355b41ada@eucas1p1.samsung.com>
2021-07-19 19:28 ` [PATCH net-next v14 1/3] dt-bindings: vendor-prefixes: Add asix prefix Łukasz Stelmach
[not found] ` <CGME20210719192913eucas1p22ebe775ac3f40af0184a6569e6e869f3@eucas1p2.samsung.com>
2021-07-19 19:28 ` [PATCH net-next v14 2/3] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter Łukasz Stelmach
[not found] ` <CGME20210719192913eucas1p2f7b31eacf8c77f8c86bf5a5ca88310b9@eucas1p2.samsung.com>
2021-07-19 19:28 ` [PATCH net-next v14 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Łukasz Stelmach
2021-07-20 10:36 ` Jakub Kicinski
[not found] ` <CGME20210720135031eucas1p1f83f554ff6e98ff719505e0d0cce7aaa@eucas1p1.samsung.com>
2021-07-20 13:50 ` Lukasz Stelmach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dleftjlf61nlgi.fsf%l.stelmach@samsung.com \
--to=l.stelmach@samsung.com \
--cc=andrew@lunn.ch \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jim.cromie@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).