linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties
@ 2020-08-29 14:24 ` Krzysztof Kozlowski
  2020-08-29 14:24   ` [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: " Krzysztof Kozlowski
                     ` (12 more replies)
  0 siblings, 13 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:24 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

Additional properties actually might appear (e.g. assigned-clocks) so
use unevaluatedProperties to fix dtbs_check warnings like:

  arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
    'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
index 686c13c14e32..30ff2da81416 100644
--- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
@@ -86,7 +86,7 @@ required:
   - compatible
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 allOf:
   - if:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: Use unevaluatedProperties
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
@ 2020-08-29 14:24   ` Krzysztof Kozlowski
  2020-08-31 12:15     ` Sylwester Nawrocki
  2020-09-03 16:42     ` Rob Herring
  2020-08-29 14:24   ` [PATCH 03/10] dt-bindings: timer: exynos4210-mct: " Krzysztof Kozlowski
                     ` (11 subsequent siblings)
  12 siblings, 2 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:24 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

Additional properties or nodes actually might appear (e.g. operating
points table) so use unevaluatedProperties to fix dtbs_check warnings
like:

  arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000:
    'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
index 80d519a76db2..c60300ffd764 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
@@ -96,7 +96,7 @@ required:
   - interrupt-names
   - clocks
 
-additionalProperties: false
+unevaluatedProperties: false
 
 allOf:
   - if:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 03/10] dt-bindings: timer: exynos4210-mct: Use unevaluatedProperties
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
  2020-08-29 14:24   ` [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: " Krzysztof Kozlowski
@ 2020-08-29 14:24   ` Krzysztof Kozlowski
  2020-08-31 12:16     ` Sylwester Nawrocki
  2020-09-03 16:42     ` Rob Herring
  2020-08-29 14:24   ` [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles Krzysztof Kozlowski
                     ` (10 subsequent siblings)
  12 siblings, 2 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:24 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

Additional properties actually might appear (e.g. clocks) so use
unevaluatedProperties to fix dtbs_check warnings like:

  arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: timer@101c0000:
    'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
index 37bd01a62c52..f46373fca95a 100644
--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
@@ -52,7 +52,7 @@ required:
   - interrupts
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
  2020-08-29 14:24   ` [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: " Krzysztof Kozlowski
  2020-08-29 14:24   ` [PATCH 03/10] dt-bindings: timer: exynos4210-mct: " Krzysztof Kozlowski
@ 2020-08-29 14:24   ` Krzysztof Kozlowski
  2020-08-31 12:30     ` Sylwester Nawrocki
  2020-09-02 16:06     ` Krzysztof Kozlowski
  2020-08-29 14:24   ` [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema Krzysztof Kozlowski
                     ` (9 subsequent siblings)
  12 siblings, 2 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:24 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

Samsung Exynos SoCs use syscon for system registers so document its
compatibles.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 049ec2ffc7f9..0f21943dea28 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -40,6 +40,10 @@ properties:
               - allwinner,sun50i-a64-system-controller
               - microchip,sparx5-cpu-syscon
               - mstar,msc313-pmsleep
+              - samsung,exynos3-sysreg
+              - samsung,exynos4-sysreg
+              - samsung,exynos5-sysreg
+              - samsung,exynos5433-sysreg
 
           - const: syscon
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (2 preceding siblings ...)
  2020-08-29 14:24   ` [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles Krzysztof Kozlowski
@ 2020-08-29 14:24   ` Krzysztof Kozlowski
  2020-09-14 18:15     ` Rob Herring
  2020-08-29 14:24   ` [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (8 subsequent siblings)
  12 siblings, 1 reply; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:24 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

Add Samsung 11-pin USB-C connector into standard dtschema bindings file.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../connector/samsung,usb-connector-11pin.txt | 49 -------------------
 .../bindings/connector/usb-connector.yaml     | 44 +++++++++++++++++
 2 files changed, 44 insertions(+), 49 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/connector/samsung,usb-connector-11pin.txt

diff --git a/Documentation/devicetree/bindings/connector/samsung,usb-connector-11pin.txt b/Documentation/devicetree/bindings/connector/samsung,usb-connector-11pin.txt
deleted file mode 100644
index 3dd8961154ab..000000000000
--- a/Documentation/devicetree/bindings/connector/samsung,usb-connector-11pin.txt
+++ /dev/null
@@ -1,49 +0,0 @@
-Samsung micro-USB 11-pin connector
-==================================
-
-Samsung micro-USB 11-pin connector is an extension of micro-USB connector.
-It is present in multiple Samsung mobile devices.
-It has additional pins to route MHL traffic simultanously with USB.
-
-The bindings are superset of usb-connector bindings for micro-USB connector[1].
-
-Required properties:
-- compatible: must be: "samsung,usb-connector-11pin", "usb-b-connector",
-- type: must be "micro".
-
-Required nodes:
-- any data bus to the connector should be modeled using the OF graph bindings
-  specified in bindings/graph.txt, unless the bus is between parent node and
-  the connector. Since single connector can have multpile data buses every bus
-  has assigned OF graph port number as follows:
-    0: High Speed (HS),
-    3: Mobile High-Definition Link (MHL), specific to 11-pin Samsung micro-USB.
-
-[1]: bindings/connector/usb-connector.yaml
-
-Example
--------
-
-Micro-USB connector with HS lines routed via controller (MUIC) and MHL lines
-connected to HDMI-MHL bridge (sii8620):
-
-muic-max77843@66 {
-	...
-	usb_con: connector {
-		compatible = "samsung,usb-connector-11pin", "usb-b-connector";
-		label = "micro-USB";
-		type = "micro";
-
-		ports {
-			#address-cells = <1>;
-			#size-cells = <0>;
-
-			port@3 {
-				reg = <3>;
-				usb_con_mhl: endpoint {
-					remote-endpoint = <&sii8620_mhl>;
-				};
-			};
-		};
-	};
-};
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index 9bd52e63c935..dc6ff64422d4 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -25,6 +25,10 @@ properties:
           - const: gpio-usb-b-connector
           - const: usb-b-connector
 
+      - items:
+          - const: samsung,usb-connector-11pin
+          - const: usb-b-connector
+
   label:
     description: Symbolic name for the connector.
 
@@ -158,6 +162,16 @@ allOf:
         - required:
             - id-gpios
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: samsung,usb-connector-11pin
+    then:
+      properties:
+        type:
+          const: micro
+
 examples:
   # Micro-USB connector with HS lines routed via controller (MUIC).
   - |
@@ -233,3 +247,33 @@ examples:
         vbus-supply = <&usb_p0_vbus>;
       };
     };
+
+  # Micro-USB connector with HS lines routed via controller (MUIC) and MHL
+  # lines connected to HDMI-MHL bridge (sii8620) on Samsung Exynos5433-based
+  # mobile phone
+  - |
+    muic-max77843 {
+      usb_con4: connector {
+        compatible = "samsung,usb-connector-11pin", "usb-b-connector";
+        label = "micro-USB";
+        type = "micro";
+
+        ports {
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          port@0 {
+            reg = <0>;
+            muic_to_usb: endpoint {
+              remote-endpoint = <&usb_to_muic>;
+            };
+          };
+          port@3 {
+            reg = <3>;
+            usb_con_mhl: endpoint {
+              remote-endpoint = <&sii8620_mhl>;
+            };
+          };
+        };
+      };
+    };
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (3 preceding siblings ...)
  2020-08-29 14:24   ` [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema Krzysztof Kozlowski
@ 2020-08-29 14:24   ` Krzysztof Kozlowski
  2020-08-31 12:31     ` Sylwester Nawrocki
                       ` (2 more replies)
  2020-08-29 14:24   ` [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433 Krzysztof Kozlowski
                     ` (7 subsequent siblings)
  12 siblings, 3 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:24 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

Additional properties actually might appear (e.g. power-domains) so use
unevaluatedProperties to fix dtbs_check warnings like:

  arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2s@11440000:
    Additional properties are not allowed ('power-domains', '#address-cells', 'interrupts', '#size-cells' were unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/sound/samsung-i2s.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml
index b2ad093d94df..16dc81288115 100644
--- a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml
+++ b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml
@@ -115,7 +115,7 @@ required:
   - clocks
   - clock-names
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (4 preceding siblings ...)
  2020-08-29 14:24   ` [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties Krzysztof Kozlowski
@ 2020-08-29 14:24   ` Krzysztof Kozlowski
  2020-08-31 12:52     ` Marek Szyprowski
                       ` (2 more replies)
  2020-08-29 14:24   ` [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes Krzysztof Kozlowski
                     ` (6 subsequent siblings)
  12 siblings, 3 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:24 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

"gpios" property is deprecated.  Update the Exynos5433 DTS to fix
dtbs_checks warnings like:

  arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'sda-gpios' is a required property
  arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' is a required property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 250fc01de78d..6246cce2a15e 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -87,8 +87,8 @@
 
 	i2c_max98504: i2c-gpio-0 {
 		compatible = "i2c-gpio";
-		gpios = <&gpd0 1 GPIO_ACTIVE_HIGH /* SPK_AMP_SDA */
-			 &gpd0 0 GPIO_ACTIVE_HIGH /* SPK_AMP_SCL */ >;
+		sda-gpios = <&gpd0 1 GPIO_ACTIVE_HIGH>;
+		scl-gpios = <&gpd0 0 GPIO_ACTIVE_HIGH>;
 		i2c-gpio,delay-us = <2>;
 		#address-cells = <1>;
 		#size-cells = <0>;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (5 preceding siblings ...)
  2020-08-29 14:24   ` [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433 Krzysztof Kozlowski
@ 2020-08-29 14:24   ` Krzysztof Kozlowski
  2020-08-31 13:00     ` Sylwester Nawrocki
  2020-09-01 10:13     ` Krzysztof Kozlowski
  2020-08-29 14:25   ` [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Krzysztof Kozlowski
                     ` (5 subsequent siblings)
  12 siblings, 2 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:24 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

System register nodes, implementing syscon binding, should use
appropriate compatible.  This fixes dtbs_check warnings:

  arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: syscon@13b80000:
    compatible: ['syscon'] is not valid under any of the given schemas

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 74ac4ac75865..b2eebdd88c3c 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1015,17 +1015,17 @@
 		};
 
 		syscon_disp: syscon@13b80000 {
-			compatible = "syscon";
+			compatible = "samsung,exynos5433-sysreg", "syscon";
 			reg = <0x13b80000 0x1010>;
 		};
 
 		syscon_cam0: syscon@120f0000 {
-			compatible = "syscon";
+			compatible = "samsung,exynos5433-sysreg", "syscon";
 			reg = <0x120f0000 0x1020>;
 		};
 
 		syscon_cam1: syscon@145f0000 {
-			compatible = "syscon";
+			compatible = "samsung,exynos5433-sysreg", "syscon";
 			reg = <0x145f0000 0x1038>;
 		};
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (6 preceding siblings ...)
  2020-08-29 14:24   ` [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes Krzysztof Kozlowski
@ 2020-08-29 14:25   ` Krzysztof Kozlowski
  2020-08-31 12:50     ` Marek Szyprowski
  2020-08-29 14:25   ` [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in " Krzysztof Kozlowski
                     ` (4 subsequent siblings)
  12 siblings, 1 reply; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:25 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

The USB-C connector bindings require port@0.  Such port was already
described in DTS but outside of the connector itself.  Put it into
proper place to fix dtbs_check warnings like:

  arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Not tested on HQ. Please kindly review and test.

Best regards,
Krzysztof
---
 .../boot/dts/exynos/exynos5433-tm2-common.dtsi    | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 6246cce2a15e..bab6c1addd5f 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -871,6 +871,13 @@
 					#address-cells = <1>;
 					#size-cells = <0>;
 
+					port@0 {
+						reg = <0>;
+						muic_to_usb: endpoint {
+							remote-endpoint = <&usb_to_muic>;
+						};
+					};
+
 					port@3 {
 						reg = <3>;
 						musb_con_to_mhl: endpoint {
@@ -879,14 +886,6 @@
 					};
 				};
 			};
-
-			ports {
-				port {
-					muic_to_usb: endpoint {
-						remote-endpoint = <&usb_to_muic>;
-					};
-				};
-			};
 		};
 
 		regulators {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (7 preceding siblings ...)
  2020-08-29 14:25   ` [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Krzysztof Kozlowski
@ 2020-08-29 14:25   ` Krzysztof Kozlowski
  2020-08-31 13:11     ` Marek Szyprowski
  2020-08-31 12:14   ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Sylwester Nawrocki
                     ` (3 subsequent siblings)
  12 siblings, 1 reply; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-29 14:25 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

The Wolfson Arizona codec is interrupt controller which is required by
bindings.  This fixes dtbs_check warnings like:

  arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required property
  arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Not tested on HQ. Please kindly review and test.

Best regards,
Krzysztof
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index bab6c1addd5f..49cd55d6891c 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -1242,6 +1242,8 @@
 
 		gpio-controller;
 		#gpio-cells = <2>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
 
 		wlf,micd-detect-debounce = <300>;
 		wlf,micd-bias-start-time = <0x1>;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (8 preceding siblings ...)
  2020-08-29 14:25   ` [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in " Krzysztof Kozlowski
@ 2020-08-31 12:14   ` Sylwester Nawrocki
  2020-09-01 10:11   ` Krzysztof Kozlowski
                     ` (2 subsequent siblings)
  12 siblings, 0 replies; 36+ messages in thread
From: Sylwester Nawrocki @ 2020-08-31 12:14 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Liam Girdwood,
	Mark Brown, Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. assigned-clocks) so
> use unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
>     'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: Use unevaluatedProperties
  2020-08-29 14:24   ` [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: " Krzysztof Kozlowski
@ 2020-08-31 12:15     ` Sylwester Nawrocki
  2020-09-03 16:42     ` Rob Herring
  1 sibling, 0 replies; 36+ messages in thread
From: Sylwester Nawrocki @ 2020-08-31 12:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Liam Girdwood,
	Mark Brown, Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> Additional properties or nodes actually might appear (e.g. operating
> points table) so use unevaluatedProperties to fix dtbs_check warnings
> like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000:
>     'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 03/10] dt-bindings: timer: exynos4210-mct: Use unevaluatedProperties
  2020-08-29 14:24   ` [PATCH 03/10] dt-bindings: timer: exynos4210-mct: " Krzysztof Kozlowski
@ 2020-08-31 12:16     ` Sylwester Nawrocki
  2020-09-03 16:42     ` Rob Herring
  1 sibling, 0 replies; 36+ messages in thread
From: Sylwester Nawrocki @ 2020-08-31 12:16 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Liam Girdwood,
	Mark Brown, Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. clocks) so use
> unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: timer@101c0000:
>     'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles
  2020-08-29 14:24   ` [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles Krzysztof Kozlowski
@ 2020-08-31 12:30     ` Sylwester Nawrocki
  2020-08-31 12:34       ` Krzysztof Kozlowski
  2020-09-02 16:06     ` Krzysztof Kozlowski
  1 sibling, 1 reply; 36+ messages in thread
From: Sylwester Nawrocki @ 2020-08-31 12:30 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Kukjin Kim, Rob Herring, David Airlie, Daniel Vetter, Lee Jones,
	Sangbeom Kim, Liam Girdwood, Mark Brown, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Chanwoo Choi, Inki Dae

On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> Samsung Exynos SoCs use syscon for system registers so document its
> compatibles.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 049ec2ffc7f9..0f21943dea28 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -40,6 +40,10 @@ properties:
>                - allwinner,sun50i-a64-system-controller
>                - microchip,sparx5-cpu-syscon
>                - mstar,msc313-pmsleep
> +              - samsung,exynos3-sysreg
> +              - samsung,exynos4-sysreg
> +              - samsung,exynos5-sysreg
> +              - samsung,exynos5433-sysreg

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Do you also have a patch updating Documentation/devicetree/
bindings/arm/samsung/sysreg.yaml with new compatibles?

-- 
Regards,
Sylwester

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties
  2020-08-29 14:24   ` [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties Krzysztof Kozlowski
@ 2020-08-31 12:31     ` Sylwester Nawrocki
  2020-09-01 11:02     ` Mark Brown
  2020-09-03 16:43     ` Rob Herring
  2 siblings, 0 replies; 36+ messages in thread
From: Sylwester Nawrocki @ 2020-08-31 12:31 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Liam Girdwood,
	Mark Brown, Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. power-domains) so use
> unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2s@11440000:
>     Additional properties are not allowed ('power-domains', '#address-cells', 'interrupts', '#size-cells' were unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles
  2020-08-31 12:30     ` Sylwester Nawrocki
@ 2020-08-31 12:34       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-31 12:34 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: Kukjin Kim, Rob Herring, David Airlie, Daniel Vetter, Lee Jones,
	Sangbeom Kim, Liam Girdwood, Mark Brown, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Chanwoo Choi, Inki Dae

On Mon, Aug 31, 2020 at 02:30:52PM +0200, Sylwester Nawrocki wrote:
> On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> > Samsung Exynos SoCs use syscon for system registers so document its
> > compatibles.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index 049ec2ffc7f9..0f21943dea28 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > @@ -40,6 +40,10 @@ properties:
> >                - allwinner,sun50i-a64-system-controller
> >                - microchip,sparx5-cpu-syscon
> >                - mstar,msc313-pmsleep
> > +              - samsung,exynos3-sysreg
> > +              - samsung,exynos4-sysreg
> > +              - samsung,exynos5-sysreg
> > +              - samsung,exynos5433-sysreg
> 
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
> Do you also have a patch updating Documentation/devicetree/
> bindings/arm/samsung/sysreg.yaml with new compatibles?

Good point. This file should be probably dropped as everything is
documented in syscon.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
  2020-08-29 14:25   ` [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Krzysztof Kozlowski
@ 2020-08-31 12:50     ` Marek Szyprowski
  2020-09-02 11:23       ` Andrzej Hajda
  0 siblings, 1 reply; 36+ messages in thread
From: Marek Szyprowski @ 2020-08-31 12:50 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi,
	Inki Dae, Andrzej Hajda

Hi Krzysztof,

On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
> The USB-C connector bindings require port@0.  Such port was already
> described in DTS but outside of the connector itself.  Put it into
> proper place to fix dtbs_check warnings like:
>
>    arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

I'm not sure if topic should be about USB-C, I will call it simply USB 
connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, 
which has nothing in common with USB Type-C.

Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, 
so something has to be somehow adjusted or fixed. Added CC Andrzej 
Hajda, who actually worked on this.

> ---
>
> Not tested on HQ. Please kindly review and test.
>
> Best regards,
> Krzysztof
> ---
>   .../boot/dts/exynos/exynos5433-tm2-common.dtsi    | 15 +++++++--------
>   1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 6246cce2a15e..bab6c1addd5f 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -871,6 +871,13 @@
>   					#address-cells = <1>;
>   					#size-cells = <0>;
>   
> +					port@0 {
> +						reg = <0>;
> +						muic_to_usb: endpoint {
> +							remote-endpoint = <&usb_to_muic>;
> +						};
> +					};
> +
>   					port@3 {
>   						reg = <3>;
>   						musb_con_to_mhl: endpoint {
> @@ -879,14 +886,6 @@
>   					};
>   				};
>   			};
> -
> -			ports {
> -				port {
> -					muic_to_usb: endpoint {
> -						remote-endpoint = <&usb_to_muic>;
> -					};
> -				};
> -			};
>   		};
>   
>   		regulators {

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433
  2020-08-29 14:24   ` [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433 Krzysztof Kozlowski
@ 2020-08-31 12:52     ` Marek Szyprowski
  2020-08-31 12:58     ` Sylwester Nawrocki
  2020-09-01 10:12     ` Krzysztof Kozlowski
  2 siblings, 0 replies; 36+ messages in thread
From: Marek Szyprowski @ 2020-08-31 12:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi, Inki Dae


On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> "gpios" property is deprecated.  Update the Exynos5433 DTS to fix
> dtbs_checks warnings like:
>
>    arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'sda-gpios' is a required property
>    arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>   arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 250fc01de78d..6246cce2a15e 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -87,8 +87,8 @@
>   
>   	i2c_max98504: i2c-gpio-0 {
>   		compatible = "i2c-gpio";
> -		gpios = <&gpd0 1 GPIO_ACTIVE_HIGH /* SPK_AMP_SDA */
> -			 &gpd0 0 GPIO_ACTIVE_HIGH /* SPK_AMP_SCL */ >;
> +		sda-gpios = <&gpd0 1 GPIO_ACTIVE_HIGH>;
> +		scl-gpios = <&gpd0 0 GPIO_ACTIVE_HIGH>;
>   		i2c-gpio,delay-us = <2>;
>   		#address-cells = <1>;
>   		#size-cells = <0>;

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433
  2020-08-29 14:24   ` [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433 Krzysztof Kozlowski
  2020-08-31 12:52     ` Marek Szyprowski
@ 2020-08-31 12:58     ` Sylwester Nawrocki
  2020-09-01 10:12     ` Krzysztof Kozlowski
  2 siblings, 0 replies; 36+ messages in thread
From: Sylwester Nawrocki @ 2020-08-31 12:58 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Liam Girdwood,
	Mark Brown, Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> "gpios" property is deprecated.  Update the Exynos5433 DTS to fix
> dtbs_checks warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'sda-gpios' is a required property
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes
  2020-08-29 14:24   ` [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes Krzysztof Kozlowski
@ 2020-08-31 13:00     ` Sylwester Nawrocki
  2020-09-01 10:13     ` Krzysztof Kozlowski
  1 sibling, 0 replies; 36+ messages in thread
From: Sylwester Nawrocki @ 2020-08-31 13:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Liam Girdwood,
	Mark Brown, Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On 29.08.2020 16:24, Krzysztof Kozlowski wrote:
> System register nodes, implementing syscon binding, should use
> appropriate compatible.  This fixes dtbs_check warnings:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: syscon@13b80000:
>     compatible: ['syscon'] is not valid under any of the given schemas
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2
  2020-08-29 14:25   ` [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in " Krzysztof Kozlowski
@ 2020-08-31 13:11     ` Marek Szyprowski
  2020-08-31 13:49       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 36+ messages in thread
From: Marek Szyprowski @ 2020-08-31 13:11 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel
  Cc: Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi, Inki Dae


On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
> The Wolfson Arizona codec is interrupt controller which is required by
> bindings.  This fixes dtbs_check warnings like:
>
>    arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required property
>    arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

However I really wonder if it makes sense to expose this to DTS. Indeed, 
the main MFD device of the WM5110 chip is interrupt controller, but its 
interrupts are requested internally by the respective drivers.

> ---
>
> Not tested on HQ. Please kindly review and test.
>
> Best regards,
> Krzysztof
> ---
>   arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index bab6c1addd5f..49cd55d6891c 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -1242,6 +1242,8 @@
>   
>   		gpio-controller;
>   		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
>   
>   		wlf,micd-detect-debounce = <300>;
>   		wlf,micd-bias-start-time = <0x1>;

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2
  2020-08-31 13:11     ` Marek Szyprowski
@ 2020-08-31 13:49       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-31 13:49 UTC (permalink / raw)
  To: Marek Szyprowski
  Cc: Kukjin Kim, Rob Herring, David Airlie, Daniel Vetter, Lee Jones,
	Sangbeom Kim, Sylwester Nawrocki, Liam Girdwood, Mark Brown,
	Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On Mon, 31 Aug 2020 at 15:12, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
>
> On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
> > The Wolfson Arizona codec is interrupt controller which is required by
> > bindings.  This fixes dtbs_check warnings like:
> >
> >    arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required property
> >    arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> However I really wonder if it makes sense to expose this to DTS. Indeed,
> the main MFD device of the WM5110 chip is interrupt controller, but its
> interrupts are requested internally by the respective drivers.

In such case maybe the schema should be updated? Feel free to send a
follow up or a replacement patch for this one.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (9 preceding siblings ...)
  2020-08-31 12:14   ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Sylwester Nawrocki
@ 2020-09-01 10:11   ` Krzysztof Kozlowski
  2020-09-01 14:50   ` Mark Brown
  2020-09-03 16:41   ` Rob Herring
  12 siblings, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 10:11 UTC (permalink / raw)
  To: Rob Herring
  Cc: Kukjin Kim, David Airlie, Daniel Vetter, Lee Jones, Sangbeom Kim,
	Sylwester Nawrocki, Liam Girdwood, Mark Brown, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi,
	Inki Dae

On Sat, Aug 29, 2020 at 04:24:52PM +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. assigned-clocks) so
> use unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
>     'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi Rob,

Could you pick all of my dt-bindings schema patches if they are ok? From
this and other series. You already have few of them in your tree so it
will help to avoid conflicts.

I am afraid that subsystem maintainers can leave them to you and vice
versa :)

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433
  2020-08-29 14:24   ` [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433 Krzysztof Kozlowski
  2020-08-31 12:52     ` Marek Szyprowski
  2020-08-31 12:58     ` Sylwester Nawrocki
@ 2020-09-01 10:12     ` Krzysztof Kozlowski
  2 siblings, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 10:12 UTC (permalink / raw)
  To: Kukjin Kim, Rob Herring, David Airlie, Daniel Vetter, Lee Jones,
	Sangbeom Kim, Sylwester Nawrocki, Liam Girdwood, Mark Brown,
	Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On Sat, Aug 29, 2020 at 04:24:58PM +0200, Krzysztof Kozlowski wrote:
> "gpios" property is deprecated.  Update the Exynos5433 DTS to fix
> dtbs_checks warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'sda-gpios' is a required property
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++--

Applied.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes
  2020-08-29 14:24   ` [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes Krzysztof Kozlowski
  2020-08-31 13:00     ` Sylwester Nawrocki
@ 2020-09-01 10:13     ` Krzysztof Kozlowski
  1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 10:13 UTC (permalink / raw)
  To: Kukjin Kim, Rob Herring, David Airlie, Daniel Vetter, Lee Jones,
	Sangbeom Kim, Sylwester Nawrocki, Liam Girdwood, Mark Brown,
	Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On Sat, Aug 29, 2020 at 04:24:59PM +0200, Krzysztof Kozlowski wrote:
> System register nodes, implementing syscon binding, should use
> appropriate compatible.  This fixes dtbs_check warnings:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: syscon@13b80000:
>     compatible: ['syscon'] is not valid under any of the given schemas
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---

Applied.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties
  2020-08-29 14:24   ` [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties Krzysztof Kozlowski
  2020-08-31 12:31     ` Sylwester Nawrocki
@ 2020-09-01 11:02     ` Mark Brown
  2020-09-03 16:43     ` Rob Herring
  2 siblings, 0 replies; 36+ messages in thread
From: Mark Brown @ 2020-09-01 11:02 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Kukjin Kim, Rob Herring, David Airlie, Daniel Vetter, Lee Jones,
	Sangbeom Kim, Sylwester Nawrocki, Liam Girdwood, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi,
	Inki Dae

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

On Sat, Aug 29, 2020 at 04:24:57PM +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. power-domains) so use
> unevaluatedProperties to fix dtbs_check warnings like:

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (10 preceding siblings ...)
  2020-09-01 10:11   ` Krzysztof Kozlowski
@ 2020-09-01 14:50   ` Mark Brown
  2020-09-03 16:45     ` Rob Herring
  2020-09-03 16:41   ` Rob Herring
  12 siblings, 1 reply; 36+ messages in thread
From: Mark Brown @ 2020-09-01 14:50 UTC (permalink / raw)
  To: Liam Girdwood, dri-devel, Thomas Gleixner, linux-arm-kernel,
	David Airlie, Lee Jones, Sylwester Nawrocki, linux-kernel,
	Rob Herring, Krzysztof Kozlowski, alsa-devel, Sangbeom Kim,
	Daniel Lezcano, Kukjin Kim, Daniel Vetter, linux-samsung-soc,
	devicetree
  Cc: Chanwoo Choi, Inki Dae, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Sylwester Nawrocki

On Sat, 29 Aug 2020 16:24:52 +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. assigned-clocks) so
> use unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
>     'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: samsung-i2s: Use unevaluatedProperties
      commit: 8187d8300251a99e40e288be80bef6a15b7b22e4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
  2020-08-31 12:50     ` Marek Szyprowski
@ 2020-09-02 11:23       ` Andrzej Hajda
  2020-09-16  7:59         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 36+ messages in thread
From: Andrzej Hajda @ 2020-09-02 11:23 UTC (permalink / raw)
  To: Marek Szyprowski, Krzysztof Kozlowski, Kukjin Kim, Rob Herring,
	David Airlie, Daniel Vetter, Lee Jones, Sangbeom Kim,
	Sylwester Nawrocki, Liam Girdwood, Mark Brown, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel
  Cc: Sylwester Nawrocki, Chanwoo Choi, Bartlomiej Zolnierkiewicz


On 31.08.2020 14:50, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
>> The USB-C connector bindings require port@0.  Such port was already
>> described in DTS but outside of the connector itself.  Put it into
>> proper place to fix dtbs_check warnings like:
>>
>>     arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> I'm not sure if topic should be about USB-C, I will call it simply USB
> connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector,
> which has nothing in common with USB Type-C.
>
> Anyway, this patch breaks DWC3 (tested in Device mode) driver operation,
> so something has to be somehow adjusted or fixed. Added CC Andrzej
> Hajda, who actually worked on this.
>
>> ---
>>
>> Not tested on HQ. Please kindly review and test.
>>
>> Best regards,
>> Krzysztof
>> ---
>>    .../boot/dts/exynos/exynos5433-tm2-common.dtsi    | 15 +++++++--------
>>    1 file changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> index 6246cce2a15e..bab6c1addd5f 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> @@ -871,6 +871,13 @@
>>    					#address-cells = <1>;
>>    					#size-cells = <0>;
>>    
>> +					port@0 {
>> +						reg = <0>;
>> +						muic_to_usb: endpoint {
>> +							remote-endpoint = <&usb_to_muic>;
>> +						};
>> +					};
>> +


According to not-yet-yaml documentation of dt-bindings (patch 05/10):
> -Required nodes:
> -- any data bus to the connector should be modeled using the OF graph bindings
> -  specified in bindings/graph.txt, unless the bus is between parent node and
> -  the connector.

This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary.


>>    					port@3 {
>>    						reg = <3>;
>>    						musb_con_to_mhl: endpoint {
>> @@ -879,14 +886,6 @@
>>    					};
>>    				};
>>    			};
>> -
>> -			ports {
>> -				port {
>> -					muic_to_usb: endpoint {
>> -						remote-endpoint = <&usb_to_muic>;
>> -					};
>> -				};


And this port belongs to MUIC - it describes connection between USB-HOST 
and MUIC, it has nothing to do with the connector, and is necessary.


Regards

Andrzej


>> -			};
>>    		};
>>    
>>    		regulators {
> Best regards

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles
  2020-08-29 14:24   ` [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles Krzysztof Kozlowski
  2020-08-31 12:30     ` Sylwester Nawrocki
@ 2020-09-02 16:06     ` Krzysztof Kozlowski
  1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 16:06 UTC (permalink / raw)
  To: Kukjin Kim, Rob Herring, David Airlie, Daniel Vetter, Lee Jones,
	Sangbeom Kim, Sylwester Nawrocki, Liam Girdwood, Mark Brown,
	Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-samsung-soc, devicetree, linux-kernel, dri-devel,
	alsa-devel
  Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
	Chanwoo Choi, Inki Dae

On Sat, Aug 29, 2020 at 04:24:55PM +0200, Krzysztof Kozlowski wrote:
> Samsung Exynos SoCs use syscon for system registers so document its
> compatibles.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++
>  1 file changed, 4 insertions(+)

As pointed by Sylwester, I will send a follow up to remove other YAML
file. This patch could be dropped.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties
  2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
                     ` (11 preceding siblings ...)
  2020-09-01 14:50   ` Mark Brown
@ 2020-09-03 16:41   ` Rob Herring
  12 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2020-09-03 16:41 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Kukjin Kim, David Airlie, Daniel Vetter, Lee Jones, Sangbeom Kim,
	Sylwester Nawrocki, Liam Girdwood, Mark Brown, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi,
	Inki Dae

On Sat, Aug 29, 2020 at 04:24:52PM +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. assigned-clocks) so
> use unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
>     'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: Use unevaluatedProperties
  2020-08-29 14:24   ` [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: " Krzysztof Kozlowski
  2020-08-31 12:15     ` Sylwester Nawrocki
@ 2020-09-03 16:42     ` Rob Herring
  1 sibling, 0 replies; 36+ messages in thread
From: Rob Herring @ 2020-09-03 16:42 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Kukjin Kim, David Airlie, Daniel Vetter, Lee Jones, Sangbeom Kim,
	Sylwester Nawrocki, Liam Girdwood, Mark Brown, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi,
	Inki Dae

On Sat, Aug 29, 2020 at 04:24:53PM +0200, Krzysztof Kozlowski wrote:
> Additional properties or nodes actually might appear (e.g. operating
> points table) so use unevaluatedProperties to fix dtbs_check warnings
> like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000:
>     'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 03/10] dt-bindings: timer: exynos4210-mct: Use unevaluatedProperties
  2020-08-29 14:24   ` [PATCH 03/10] dt-bindings: timer: exynos4210-mct: " Krzysztof Kozlowski
  2020-08-31 12:16     ` Sylwester Nawrocki
@ 2020-09-03 16:42     ` Rob Herring
  1 sibling, 0 replies; 36+ messages in thread
From: Rob Herring @ 2020-09-03 16:42 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Kukjin Kim, David Airlie, Daniel Vetter, Lee Jones, Sangbeom Kim,
	Sylwester Nawrocki, Liam Girdwood, Mark Brown, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi,
	Inki Dae

On Sat, Aug 29, 2020 at 04:24:54PM +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. clocks) so use
> unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: timer@101c0000:
>     'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties
  2020-08-29 14:24   ` [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties Krzysztof Kozlowski
  2020-08-31 12:31     ` Sylwester Nawrocki
  2020-09-01 11:02     ` Mark Brown
@ 2020-09-03 16:43     ` Rob Herring
  2 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2020-09-03 16:43 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Kukjin Kim, David Airlie, Daniel Vetter, Lee Jones, Sangbeom Kim,
	Sylwester Nawrocki, Liam Girdwood, Mark Brown, Daniel Lezcano,
	Thomas Gleixner, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, dri-devel, alsa-devel, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Chanwoo Choi,
	Inki Dae

On Sat, Aug 29, 2020 at 04:24:57PM +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. power-domains) so use
> unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2s@11440000:
>     Additional properties are not allowed ('power-domains', '#address-cells', 'interrupts', '#size-cells' were unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/sound/samsung-i2s.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties
  2020-09-01 14:50   ` Mark Brown
@ 2020-09-03 16:45     ` Rob Herring
  0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2020-09-03 16:45 UTC (permalink / raw)
  To: Mark Brown
  Cc: Liam Girdwood, dri-devel, Thomas Gleixner, linux-arm-kernel,
	David Airlie, Lee Jones, Sylwester Nawrocki, linux-kernel,
	Krzysztof Kozlowski, alsa-devel, Sangbeom Kim, Daniel Lezcano,
	Kukjin Kim, Daniel Vetter, linux-samsung-soc, devicetree,
	Chanwoo Choi, Inki Dae, Marek Szyprowski,
	Bartlomiej Zolnierkiewicz, Sylwester Nawrocki

On Tue, Sep 01, 2020 at 03:50:00PM +0100, Mark Brown wrote:
> On Sat, 29 Aug 2020 16:24:52 +0200, Krzysztof Kozlowski wrote:
> > Additional properties actually might appear (e.g. assigned-clocks) so
> > use unevaluatedProperties to fix dtbs_check warnings like:
> > 
> >   arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
> >     'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/1] ASoC: samsung-i2s: Use unevaluatedProperties
>       commit: 8187d8300251a99e40e288be80bef6a15b7b22e4

Please revert or drop. All these 'unevaluatedProperties' changes are 
wrong.

Rob

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema
  2020-08-29 14:24   ` [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema Krzysztof Kozlowski
@ 2020-09-14 18:15     ` Rob Herring
  0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2020-09-14 18:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Sangbeom Kim, Bartlomiej Zolnierkiewicz, Mark Brown,
	Marek Szyprowski, Liam Girdwood, David Airlie, Daniel Lezcano,
	linux-arm-kernel, Rob Herring, Lee Jones, devicetree, Inki Dae,
	Daniel Vetter, Kukjin Kim, alsa-devel, Chanwoo Choi,
	linux-samsung-soc, Thomas Gleixner, Sylwester Nawrocki,
	dri-devel, Sylwester Nawrocki, linux-kernel

On Sat, 29 Aug 2020 16:24:56 +0200, Krzysztof Kozlowski wrote:
> Add Samsung 11-pin USB-C connector into standard dtschema bindings file.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../connector/samsung,usb-connector-11pin.txt | 49 -------------------
>  .../bindings/connector/usb-connector.yaml     | 44 +++++++++++++++++
>  2 files changed, 44 insertions(+), 49 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/connector/samsung,usb-connector-11pin.txt
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
  2020-09-02 11:23       ` Andrzej Hajda
@ 2020-09-16  7:59         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-16  7:59 UTC (permalink / raw)
  To: Andrzej Hajda
  Cc: Marek Szyprowski, Kukjin Kim, Rob Herring, David Airlie,
	Daniel Vetter, Lee Jones, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Mark Brown, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	dri-devel, alsa-devel, Sylwester Nawrocki, Chanwoo Choi,
	Bartlomiej Zolnierkiewicz

On Wed, Sep 02, 2020 at 01:23:50PM +0200, Andrzej Hajda wrote:
> 
> On 31.08.2020 14:50, Marek Szyprowski wrote:
> > Hi Krzysztof,
> >
> > On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
> >> The USB-C connector bindings require port@0.  Such port was already
> >> described in DTS but outside of the connector itself.  Put it into
> >> proper place to fix dtbs_check warnings like:
> >>
> >>     arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > I'm not sure if topic should be about USB-C, I will call it simply USB
> > connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector,
> > which has nothing in common with USB Type-C.
> >
> > Anyway, this patch breaks DWC3 (tested in Device mode) driver operation,
> > so something has to be somehow adjusted or fixed. Added CC Andrzej
> > Hajda, who actually worked on this.
> >
> >> ---
> >>
> >> Not tested on HQ. Please kindly review and test.
> >>
> >> Best regards,
> >> Krzysztof
> >> ---
> >>    .../boot/dts/exynos/exynos5433-tm2-common.dtsi    | 15 +++++++--------
> >>    1 file changed, 7 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> index 6246cce2a15e..bab6c1addd5f 100644
> >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> @@ -871,6 +871,13 @@
> >>    					#address-cells = <1>;
> >>    					#size-cells = <0>;
> >>    
> >> +					port@0 {
> >> +						reg = <0>;
> >> +						muic_to_usb: endpoint {
> >> +							remote-endpoint = <&usb_to_muic>;
> >> +						};
> >> +					};
> >> +
> 
> 
> According to not-yet-yaml documentation of dt-bindings (patch 05/10):
> > -Required nodes:
> > -- any data bus to the connector should be modeled using the OF graph bindings
> > -  specified in bindings/graph.txt, unless the bus is between parent node and
> > -  the connector.
> 
> This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary.
> 
> 
> >>    					port@3 {
> >>    						reg = <3>;
> >>    						musb_con_to_mhl: endpoint {
> >> @@ -879,14 +886,6 @@
> >>    					};
> >>    				};
> >>    			};
> >> -
> >> -			ports {
> >> -				port {
> >> -					muic_to_usb: endpoint {
> >> -						remote-endpoint = <&usb_to_muic>;
> >> -					};
> >> -				};
> 
> 
> And this port belongs to MUIC - it describes connection between USB-HOST 
> and MUIC, it has nothing to do with the connector, and is necessary.

Thanks for checking this. It's really appreciated!

I'll work on v2 later to address the schema warning, hopefully without
breaking things...

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 36+ messages in thread

end of thread, other threads:[~2020-09-16  7:59 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200829142522eucas1p2ecc9517be9060d7291b27deba1be8fe4@eucas1p2.samsung.com>
2020-08-29 14:24 ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-29 14:24   ` [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: " Krzysztof Kozlowski
2020-08-31 12:15     ` Sylwester Nawrocki
2020-09-03 16:42     ` Rob Herring
2020-08-29 14:24   ` [PATCH 03/10] dt-bindings: timer: exynos4210-mct: " Krzysztof Kozlowski
2020-08-31 12:16     ` Sylwester Nawrocki
2020-09-03 16:42     ` Rob Herring
2020-08-29 14:24   ` [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles Krzysztof Kozlowski
2020-08-31 12:30     ` Sylwester Nawrocki
2020-08-31 12:34       ` Krzysztof Kozlowski
2020-09-02 16:06     ` Krzysztof Kozlowski
2020-08-29 14:24   ` [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema Krzysztof Kozlowski
2020-09-14 18:15     ` Rob Herring
2020-08-29 14:24   ` [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-31 12:31     ` Sylwester Nawrocki
2020-09-01 11:02     ` Mark Brown
2020-09-03 16:43     ` Rob Herring
2020-08-29 14:24   ` [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433 Krzysztof Kozlowski
2020-08-31 12:52     ` Marek Szyprowski
2020-08-31 12:58     ` Sylwester Nawrocki
2020-09-01 10:12     ` Krzysztof Kozlowski
2020-08-29 14:24   ` [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes Krzysztof Kozlowski
2020-08-31 13:00     ` Sylwester Nawrocki
2020-09-01 10:13     ` Krzysztof Kozlowski
2020-08-29 14:25   ` [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Krzysztof Kozlowski
2020-08-31 12:50     ` Marek Szyprowski
2020-09-02 11:23       ` Andrzej Hajda
2020-09-16  7:59         ` Krzysztof Kozlowski
2020-08-29 14:25   ` [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in " Krzysztof Kozlowski
2020-08-31 13:11     ` Marek Szyprowski
2020-08-31 13:49       ` Krzysztof Kozlowski
2020-08-31 12:14   ` [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties Sylwester Nawrocki
2020-09-01 10:11   ` Krzysztof Kozlowski
2020-09-01 14:50   ` Mark Brown
2020-09-03 16:45     ` Rob Herring
2020-09-03 16:41   ` Rob Herring

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox