From: Hans Verkuil <hverkuil@xs4all.nl>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RFT] media: exynos4-is: add missed clk_disable_unprepare in remove
Date: Fri, 10 Jan 2020 14:40:21 +0100 [thread overview]
Message-ID: <f253eb6e-5e21-fd9b-8c2f-371beea66afa@xs4all.nl> (raw)
In-Reply-To: <20191219074824.15047-1-hslester96@gmail.com>
Anyone able/willing to test this patch?
Regards,
Hans
On 12/19/19 8:48 AM, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare() to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
> - Add a check of pm_runtime_enable() to match enable in probe.
> - Add RFT tag.
>
> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c
> index e87c6a09205b..17de14fbba31 100644
> --- a/drivers/media/platform/exynos4-is/fimc-lite.c
> +++ b/drivers/media/platform/exynos4-is/fimc-lite.c
> @@ -1614,6 +1614,9 @@ static int fimc_lite_remove(struct platform_device *pdev)
> struct fimc_lite *fimc = platform_get_drvdata(pdev);
> struct device *dev = &pdev->dev;
>
> + if (!pm_runtime_enabled(dev))
> + clk_disable_unprepare(fimc->clock);
> +
> pm_runtime_disable(dev);
> pm_runtime_set_suspended(dev);
> fimc_lite_unregister_capture_subdev(fimc);
>
next prev parent reply other threads:[~2020-01-10 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 7:48 [PATCH v2 RFT] media: exynos4-is: add missed clk_disable_unprepare in remove Chuhong Yuan
2020-01-10 13:40 ` Hans Verkuil [this message]
2020-01-13 7:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f253eb6e-5e21-fd9b-8c2f-371beea66afa@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hslester96@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).