From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FA8C7618A for ; Sun, 12 Mar 2023 17:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbjCLRJQ (ORCPT ); Sun, 12 Mar 2023 13:09:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbjCLRJP (ORCPT ); Sun, 12 Mar 2023 13:09:15 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F11A9211D0 for ; Sun, 12 Mar 2023 10:09:12 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id g10so10901959eda.1 for ; Sun, 12 Mar 2023 10:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678640951; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ur0YRak4azgO8ER8v9X1Sisyj3A0UjrzNilpdcu+HRk=; b=IIumIHOspITOgjriMp5ESfe4mr+ULnDvPBgJipm3w8unQT74U3jSJ0ZYxyJ3yA7l1w wzQzBmdo48JSDwrmGI5NNHrj6qB4LwBjNcm+y4kD7txoNzXnlv6W3m54HK8X+qOL5YA0 IY6cyOAQZmZuL9WqiPPaoGuXb3wqfwCMSmzUPXNTQBiq1ErNXeA5UtcMRXcnh0xzlDK6 87eT+bj19kVx2bzZiI8RHt/APiSIdokGzw/U5ZgKxoJrWKwXnQFPWFgHdszEeIHUE9RR w+1cESbv7K+k5D0KDdqDm0NdHJzG8kigScImY2DdcrNQeGzwaQwMCyLrse+TD39Ykv78 /P2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678640951; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ur0YRak4azgO8ER8v9X1Sisyj3A0UjrzNilpdcu+HRk=; b=1ijxqTvWrNO73F0X3iy5UpYaCjLnFQd3hYNs6HkadTZmpDJPYBUoDf3UaT8OIOqOom p28zu5Lmjk0/vNRAXyD2ghsWIoaLBaitGBYMqXFK9Cxpq9Q8hjKRhiFwFHff/tT1yl18 i+ZSPVqqjQBQ3Vz5MBQw6tk3kcb7hk3iEGWKQHCe/8GZmKtrzLWm1irsZ5LRQ1NnCQZB G7z/CzLIIwea7I/jPaMueWhZs/kNl5ChnEeUbiBrSkfPuGfNjk1WOL+yVuFJFLbRvYxJ W4B2/5tNbwmBotpxuL9j9BZErMo3b2eBlCzTtyjbSwO+ncbZdyn8Xx/YFpxkLQbKE2AI 53Tw== X-Gm-Message-State: AO0yUKUmgjuuwvi0UdTYEyeinatOBpj1QWSSqheEksN+8+K2TsLVaTCT 7EsfhJE4dSjlinONS5H1kMiM2Q== X-Google-Smtp-Source: AK7set+9rjs/pkVy7AWNiNv0a34Mg1Vn463+p/9TwJdBU4BL6GlFQorb6rS66Q1i0nTHMIp1JktUoQ== X-Received: by 2002:a17:906:3b48:b0:921:da99:f39c with SMTP id h8-20020a1709063b4800b00921da99f39cmr5463449ejf.12.1678640951442; Sun, 12 Mar 2023 10:09:11 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d9f6:3e61:beeb:295a? ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id i5-20020a170906850500b0091e1878bc59sm2425726ejx.68.2023.03.12.10.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Mar 2023 10:09:11 -0700 (PDT) Message-ID: Date: Sun, 12 Mar 2023 18:09:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 1/2] dt-bindings: exynos-dw-mshc-common: add exynos78xx variants Content-Language: en-US To: Sergey Lisov , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Jaehoon Chung Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <640e0136.c20a0220.2d5bf.1959@mx.google.com> From: Krzysztof Kozlowski In-Reply-To: <640e0136.c20a0220.2d5bf.1959@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 12/03/2023 17:43, Sergey Lisov wrote: >> Bindings and DTS (and driver) are always separate. > > Okay, will split the patch. > >> Compatibles must be specific. > > No, this way you'd have tons of identical compatibles that only differ in > the exynosXXXX digits, and are functionally equivalent. Thanks for letting me know. https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 >> That's non-bisectable change (also breaking other users of DTS), so you >> need to explain in commit msg rationale - devices were never compatible >> and using exynos7 does not work in certain cases. BTW, this rationale was only example - you need to come with something real. Best regards, Krzysztof