From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
balbi@kernel.org, gregkh@linuxfoundation.org, nathan@kernel.org,
ndesaulniers@google.com, arnd@arndb.de, gustavoars@kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: gadget: s3c: Fix incorrect resources releasing
Date: Fri, 5 Mar 2021 11:05:51 +0100 [thread overview]
Message-ID: <f63496f6-f894-2a86-0328-0f8dadbd28cc@canonical.com> (raw)
In-Reply-To: <20210221074117.937965-1-christophe.jaillet@wanadoo.fr>
On 21/02/2021 08:41, Christophe JAILLET wrote:
> Since commit fe0f8e5c9ba8 ("usb: gadget: s3c: use platform resources"),
> 'request_mem_region()' and 'ioremap()' are no more used, so they don't need
> to be undone in the error handling path of the probe and in the removre
s/removre/remove/
> function.
>
> Remove these calls and the unneeded 'rsrc_start' and 'rsrc_len' global
> variables.
>
> Fixes: fe0f8e5c9ba8 ("usb: gadget: s3c: use platform resources")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> the 'err' label is used only to reduce the diff size of this patch. It is
> removed in the following patch.
>
> checkpatch reports:
> WARNING: Unknown commit id 'fe0f8e5c9ba8', maybe rebased or not pulled?
> According to https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/usb/gadget/udc/s3c2410_udc.c?id=188db4435ac64f0918def7ba0593d408700ecc4b
> the commit ID looks correct to me. Maybe something should be tweaked somewhere
> before applying, but I don't know what!
> ---
> drivers/usb/gadget/udc/s3c2410_udc.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
With fixing of commit sha:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2021-03-05 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 7:41 [PATCH 1/2] usb: gadget: s3c: Fix incorrect resources releasing Christophe JAILLET
2021-02-22 6:03 ` Dan Carpenter
2021-02-23 21:27 ` Christophe JAILLET
2021-03-05 10:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f63496f6-f894-2a86-0328-0f8dadbd28cc@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).