From: Sylwester Nawrocki <snawrocki@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>,
pawel.mikolaj.chmiel@gmail.com, mturquette@baylibre.com
Cc: kgene@kernel.org, krzk@kernel.org,
linux-samsung-soc@vger.kernel.org, tomasz.figa@gmail.com,
linux-kernel@vger.kernel.org, cw00.choi@samsung.com,
s.nawrocki@samsung.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] clk: exynos7: Keep aclk_fsys1_200 enabled
Date: Tue, 9 Feb 2021 15:46:07 +0100 [thread overview]
Message-ID: <fa918113-c20b-1867-7c32-b30fd09e185e@kernel.org> (raw)
In-Reply-To: <161285690197.418021.15554726449883492168@swboyd.mtv.corp.google.com>
On 09.02.2021 08:48, Stephen Boyd wrote:
> Quoting (2021-01-31 09:04:28)
>> This clock must be always enabled to allow access to any registers in
>> fsys1 CMU. Until proper solution based on runtime PM is applied
>> (similar to what was done for Exynos5433), fix this by calling
>> clk_prepare_enable() directly from clock provider driver.
>>
>> It was observed on Samsung Galaxy S6 device (based on Exynos7420), where
>> UFS module is probed before pmic used to power that device.
>> In this case defer probe was happening and that clock was disabled by
>> UFS driver, causing whole boot to hang on next CMU access.
>>
>
> Does this need a Fixes tag?
That would be
Fixes: 753195a749a6 ("clk: samsung: exynos7: Correct CMU_FSYS1 clocks names")
i.e. commit that introduced definition of the clock. But the fix cannot be
backported that far as build fails with an error:
drivers/clk/samsung/clk-exynos7.c: In function ‘exynos7_clk_top1_init’:
drivers/clk/samsung/clk-exynos7.c:554:21: error: ‘struct clk_onecell_data’ has no member named ‘hws’
554 | hws = ctx->clk_data.hws;
It could only by backported up to:
ecb1f1f7311f ("clk: samsung: Convert common drivers to the new clk_hw API")
We need a different patch to fix it properly in stable kernels.
And dts for board this bugfix patch was prepared is not upstream yet.
prev parent reply other threads:[~2021-02-09 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210131170444epcas1p1244bfbf4e3bf121360e973b719a699c0@epcas1p1.samsung.com>
[not found] ` <20210131170428.3290-1-pawel.mikolaj.chmiel@gmail.com>
2021-02-01 4:50 ` [PATCH v3] clk: exynos7: Keep aclk_fsys1_200 enabled Chanwoo Choi
2021-02-01 15:18 ` Sylwester Nawrocki
2021-02-09 7:48 ` Stephen Boyd
2021-02-09 14:46 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa918113-c20b-1867-7c32-b30fd09e185e@kernel.org \
--to=snawrocki@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).