From: 정종민 <jjmin.jeong@samsung.com>
To: "'Christoph Hellwig'" <hch@infradead.org>
Cc: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
<cang@codeaurora.org>, <beanhuo@micron.com>,
<adrian.hunter@intel.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] scsi: ufs: add quirk to handle broken UIC command
Date: Thu, 3 Jun 2021 12:08:57 +0900 [thread overview]
Message-ID: <000001d75825$cb0ab5f0$612021d0$@samsung.com> (raw)
In-Reply-To: <YK9RkXoLsUT38cTP@infradead.org>
> > samsung ExynosAuto SoC has two types of host controller interface to
> > support the virtualization of UFS Device.
> > One is the physical host(PH) that the same as conventaional UFSHCI,
> > and the other is the virtual host(VH) that support data transfer
> function only.
>
> You forgot to include the hunk that actually sets the quirk.
thanks for your review.
We will set up the quirk in exynos ufs driver.
I will upload the patch together in v2 patchs.
>
> Also please work on the commit log formatting.
I'll erase the change-id log next patch too. Thank you.
>
> > Change-Id: Ie528726b29bcb643149440bf1c90eaa5995c5ac1
>
> This kind of crap has no business in a commit log.
Best Regards,
Jongmin jeong
next prev parent reply other threads:[~2021-06-03 3:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210527031217epcas2p44b9d999edcc55b345dfd0749acefeaec@epcas2p4.samsung.com>
2021-05-27 3:08 ` [PATCH 0/3] Add quirk to support exynos ufshci jongmin jeong
[not found] ` <CGME20210527031219epcas2p313fcf248833cf14ec9a164dd91a1ca13@epcas2p3.samsung.com>
2021-05-27 3:08 ` [PATCH 1/3] scsi: ufs: add quirk to handle broken UIC command jongmin jeong
2021-05-27 8:00 ` Christoph Hellwig
2021-06-03 3:08 ` 정종민 [this message]
[not found] ` <CGME20210527031220epcas2p269503cfa517d80af350c5344cdeb24c7@epcas2p2.samsung.com>
2021-05-27 3:09 ` [PATCH 2/3] scsi: ufs: add quirk to enable host controller without interface configuration jongmin jeong
[not found] ` <CGME20210527031220epcas2p41a5ba641919769ca95ccea81e5f3bfb0@epcas2p4.samsung.com>
2021-05-27 3:09 ` [PATCH 3/3] scsi: ufs: add quirk to support host reset only jongmin jeong
2021-05-27 6:08 ` kernel test robot
2021-05-27 6:31 ` Can Guo
2021-05-27 6:53 ` Can Guo
2021-06-03 3:21 ` 정종민
2021-05-27 7:34 ` kernel test robot
2021-05-27 8:17 ` [PATCH 0/3] Add quirk to support exynos ufshci Alim Akhtar
2021-05-27 16:40 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d75825$cb0ab5f0$612021d0$@samsung.com' \
--to=jjmin.jeong@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).