From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Alice'" <alice.chao@mediatek.com>, <stanley.chu@mediatek.com>,
<linux-scsi@vger.kernel.org>, <martin.petersen@oracle.com>,
<avri.altman@wdc.com>, <jejb@linux.ibm.com>
Cc: <wsd_upstream@mediatek.com>, <peter.wang@mediatek.com>,
<chun-hung.wu@mediatek.com>, <jonathan.hsu@mediatek.com>,
<powen.kao@mediatek.com>, <cc.chou@mediatek.com>,
<chaotian.jing@mediatek.com>, <jiajie.hao@mediatek.com>
Subject: RE: [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing
Date: Thu, 27 May 2021 22:09:51 +0530 [thread overview]
Message-ID: <002501d75316$ec811f30$c5835d90$@samsung.com> (raw)
In-Reply-To: <20210527155817.15006-2-alice.chao@mediatek.com>
> -----Original Message-----
> From: Alice <alice.chao@mediatek.com>
> Sent: 27 May 2021 21:28
> To: stanley.chu@mediatek.com; linux-scsi@vger.kernel.org;
> martin.petersen@oracle.com; avri.altman@wdc.com;
> alim.akhtar@samsung.com; jejb@linux.ibm.com
> Cc: wsd_upstream@mediatek.com; peter.wang@mediatek.com; chun-
> hung.wu@mediatek.com; alice.chao@mediatek.com;
> jonathan.hsu@mediatek.com; powen.kao@mediatek.com;
> cc.chou@mediatek.com; chaotian.jing@mediatek.com;
> jiajie.hao@mediatek.com
> Subject: [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing
>
> From: "Alice.Chao" <alice.chao@mediatek.com>
>
> HCI disable before HW Reset.
> Because of the property of mtk ufshci,
> we need to change reset flow to avoid potential issues.
>
Please re-format the commit message and mention few wards about potential
issues.
> Change-Id: I3eb917fd2953b58dcf7e021286d1de71c9232cfb
Hmm, run a checkpatch before submitting any patch.
> Signed-off-by: Alice.Chao <alice.chao@mediatek.com>
> CR-Id: ALPS05728133
What are these ID? Please remove.
> Feature: UFS(Universal Flash Storage)
Please check Documentation/process/submitting-patches.rst, before submitting
patches.
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c
b/drivers/scsi/ufs/ufs-mediatek.c
> index a981f261b304..c62603ed3d33 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -846,6 +846,9 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba)
> {
> struct arm_smccc_res res;
>
> + /* disable hba before device reset */
> + ufshcd_hba_stop(hba);
> +
> ufs_mtk_device_reset_ctrl(0, res);
>
> /*
> --
> 2.18.0
next prev parent reply other threads:[~2021-05-27 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 15:58 [PATCH 1/1] scsi: ufs: Export ufshcd_hba_stop Alice
2021-05-27 15:58 ` [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing Alice
2021-05-27 16:39 ` Alim Akhtar [this message]
2021-05-27 16:02 Alice
2021-05-27 16:02 ` Alice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002501d75316$ec811f30$c5835d90$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=alice.chao@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=jonathan.hsu@mediatek.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).