From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Can Guo'" <cang@codeaurora.org>
Cc: <linux-scsi@vger.kernel.org>
Subject: RE: [RFC PATCH v1 1/2] ufs: add a vops to configure block parameter
Date: Mon, 21 Dec 2020 13:28:45 +0900 [thread overview]
Message-ID: <002f01d6d751$c545d820$4fd18860$@samsung.com> (raw)
In-Reply-To: <d2ba958d2e4b20de0b900a9a53ed169d@codeaurora.org>
> > Thers could be some cases to set block paramters
>
> s/Thers/There/g
>
> > per host, because of its own dma structurs or whatever.
>
> s/structurs/structure/g
>
> >
> > Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
> > ---
> > drivers/scsi/ufs/ufshcd.c | 2 ++
> > drivers/scsi/ufs/ufshcd.h | 8 ++++++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index 92d433d..58f9cb6 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -4758,6 +4758,8 @@ static int ufshcd_slave_configure(struct
> > scsi_device *sdev)
> >
> > ufshcd_crypto_setup_rq_keyslot_manager(hba, q);
> >
> > + ufshcd_vops_config_request_queue(hba, sdev);
>
> How about make it more univeral, like ufshcd_vops_slave_configure()?
>
> Thanks,
>
> Can Guo.
>
Will refer and thanks for all of your comments
Thanks.
Kiwoong Kim
> > +
> > return 0;
> > }
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > index 61344c4..657bdbd 100644
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/drivers/scsi/ufs/ufshcd.h
> > @@ -329,6 +329,7 @@ struct ufs_hba_variant_ops {
> > void *data);
> > int (*program_key)(struct ufs_hba *hba,
> > const union ufs_crypto_cfg_entry *cfg, int
slot);
> > + void (*config_request_queue)(struct scsi_device *sdev);
> > };
> >
> > /* clock gating state */
> > @@ -1228,6 +1229,13 @@ static inline void
> > ufshcd_vops_config_scaling_param(struct ufs_hba *hba,
> > hba->vops->config_scaling_param(hba, profile, data); }
> >
> > +static inline void ufshcd_vops_config_request_queue(struct ufs_hba
> > *hba,
> > + struct scsi_device
*sdev)
> > +{
> > + if (hba->vops && hba->vops->config_request_queue)
> > + hba->vops->config_request_queue(sdev);
> > +}
> > +
> > extern struct ufs_pm_lvl_states ufs_pm_lvl_states[];
> >
> > /*
next prev parent reply other threads:[~2020-12-21 4:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201219044914epcas2p45c64d96a9a9097cc100f6d477c0c36ce@epcas2p4.samsung.com>
2020-12-19 4:38 ` [RFC PATCH v1 0/2] permit to set block parameters per vendor Kiwoong Kim
[not found] ` <CGME20201219044916epcas2p16927b09270a3d829520af414dd64d80f@epcas2p1.samsung.com>
2020-12-19 4:38 ` [RFC PATCH v1 1/2] ufs: add a vops to configure block parameter Kiwoong Kim
2020-12-21 2:57 ` Can Guo
2020-12-21 4:28 ` Kiwoong Kim [this message]
[not found] ` <CGME20201219044917epcas2p271c5a6dbbab952f8f1ba1e6a56f91bca@epcas2p2.samsung.com>
2020-12-19 4:38 ` [RFC PATCH v1 2/2] ufs: ufs-exynos: set dma_alignment to 4095 Kiwoong Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01d6d751$c545d820$4fd18860$@samsung.com' \
--to=kwmad.kim@samsung.com \
--cc=cang@codeaurora.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).