linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>
Cc: linux-scsi@vger.kernel.org,
	GR-QLogic-Storage-Upstream@marvell.com,
	target-devel@vger.kernel.org, linux@yadro.com,
	Quinn Tran <qutran@marvell.com>, Arun Easi <aeasi@marvell.com>,
	Nilesh Javali <njavali@marvell.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Daniel Wagner <dwagner@suse.de>,
	Himanshu Madhani <himanshu.madhani@oracle.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Keep initiator ports after RSCN
Date: Tue, 26 May 2020 21:21:52 +0200	[thread overview]
Message-ID: <06a74050412a378acf31f41ce5e39c6c739ee91e.camel@suse.com> (raw)
In-Reply-To: <20200521151730.GA73599@SPB-NB-133.local>

Roman,

> [...]
>
> So, as a summary, it seems that the existing code mostly keeps
> sessions
> until:
>  - a conflict of N_Port_ID, N_Port_Name or N_Port handle detected;
>  - the session is in the middle of refresh/rescan and RSCN arrives;
>  - there's an explicit process or port logout from the session, i.e.
>    PRLO, TPRLO, LOGO
>  - there's a new port or process login from the same session, i.e.
>    PLOGI, PRLI;
>  - target is shut down;
>  - target port link is reset;
> 
> And if a session of an initiator is deleted when driver works in
> target
> mode, new session won't be established until a PLOGI and PRLI come
> from
> the initiator.
> 
> The assumption is used qlt_handle_cmd_for_atio() and
> qlt_handle_task_mgmt() to discard commands and TMFs from initiators
> that
> are not logged in.
> 

thank you for this incredibly extensive response. I'll bookmark it,
I guess it can serve as a reference for future qla2xxx work. I hope you
didn't do all this work just for my little question.

Forgive me that I won't immediately try to review this document in
detail. You've studied and understood this driver in much more depth
than I probably ever will.

Thanks again,
Martin



> Thanks,
> Roman



  reply	other threads:[~2020-05-26 19:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 18:31 [PATCH] scsi: qla2xxx: Keep initiator ports after RSCN Roman Bolshakov
2020-05-18 22:40 ` Himanshu Madhani
2020-05-18 23:22 ` Roman Bolshakov
2020-05-26 19:17   ` Martin Wilck
2020-05-19  8:46 ` Martin Wilck
2020-05-21 15:17   ` Roman Bolshakov
2020-05-26 19:21     ` Martin Wilck [this message]
2020-06-03  1:42 ` Martin K. Petersen
2020-06-05 14:23   ` Roman Bolshakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06a74050412a378acf31f41ce5e39c6c739ee91e.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=aeasi@marvell.com \
    --cc=bvanassche@acm.org \
    --cc=dwagner@suse.de \
    --cc=himanshu.madhani@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@yadro.com \
    --cc=njavali@marvell.com \
    --cc=qutran@marvell.com \
    --cc=r.bolshakov@yadro.com \
    --cc=stable@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).