From: Bart Van Assche <bvanassche@acm.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Doug Gilbert <dgilbert@interlog.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v3 3/3] scsi: ufs: ufshcd: constify pointed data
Date: Wed, 22 Jun 2022 09:13:35 -0700 [thread overview]
Message-ID: <08544601-3364-0352-415f-2e3576b84976@acm.org> (raw)
In-Reply-To: <20220613100655.105301-4-krzysztof.kozlowski@linaro.org>
On 6/13/22 03:06, Krzysztof Kozlowski wrote:
> Constify arrays and pointers to data which is not modified for code
^^
> safety.
is -> are?
> @@ -7848,7 +7850,7 @@ static int ufshcd_quirk_tune_host_pa_tactivate(struct ufs_hba *hba)
> u32 granularity, peer_granularity;
> u32 pa_tactivate, peer_pa_tactivate;
> u32 pa_tactivate_us, peer_pa_tactivate_us;
> - u8 gran_to_us_table[] = {1, 4, 8, 16, 32, 100};
> + const u8 gran_to_us_table[] = {1, 4, 8, 16, 32, 100};
Can this array be declared static? Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2022-06-22 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 10:06 [PATCH v3 0/3] scsi: ufs: minor cleanups Krzysztof Kozlowski
2022-06-13 10:06 ` [PATCH v3 1/3] scsi: core: fix white-spaces Krzysztof Kozlowski
2022-06-13 10:06 ` [PATCH v3 2/3] scsi: ufs: ufshcd-pltfrm: constify pointed data Krzysztof Kozlowski
2022-06-22 16:11 ` Bart Van Assche
2022-06-13 10:06 ` [PATCH v3 3/3] scsi: ufs: ufshcd: " Krzysztof Kozlowski
2022-06-22 16:13 ` Bart Van Assche [this message]
2022-06-23 7:16 ` Krzysztof Kozlowski
2022-06-22 14:50 ` [PATCH v3 0/3] scsi: ufs: minor cleanups Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08544601-3364-0352-415f-2e3576b84976@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.ibm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).