From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C50C433FE for ; Mon, 21 Nov 2022 14:30:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbiKUOaz (ORCPT ); Mon, 21 Nov 2022 09:30:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230243AbiKUOaw (ORCPT ); Mon, 21 Nov 2022 09:30:52 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A0686C735; Mon, 21 Nov 2022 06:30:51 -0800 (PST) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NG8tj1trCz15Ml8; Mon, 21 Nov 2022 22:30:21 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 22:30:48 +0800 Subject: Re: [PATCH 1/2] scsi: core: Use SCSI_SCAN_RESCAN in __scsi_add_device() To: John Garry , , CC: , , References: <20221121121725.1910795-1-john.g.garry@oracle.com> <20221121121725.1910795-2-john.g.garry@oracle.com> From: Jason Yan Message-ID: <0973e45f-eb1e-ffaf-4637-9b49f69f8106@huawei.com> Date: Mon, 21 Nov 2022 22:30:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20221121121725.1910795-2-john.g.garry@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2022/11/21 20:17, John Garry wrote: > Instead of using hardcoded '1' as the __scsi_add_device() -> > scsi_probe_and_add_lun() rescan arg, use proper macro SCSI_SCAN_RESCAN. > > Signed-off-by: John Garry > Reviewed-by: Damien Le Moal > --- > drivers/scsi/scsi_scan.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Looks good, Reviewed-by: Jason Yan