From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <cang@codeaurora.org>,
asutoshd@codeaurora.org, nguyenb@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] scsi: Adjust DBD setting in mode sense for caching mode page per LLD
Date: Mon, 28 Oct 2019 07:58:39 -0700 [thread overview]
Message-ID: <0ca52845-10ec-3310-83f7-81bdb635ec12@acm.org> (raw)
In-Reply-To: <1572234608-32654-2-git-send-email-cang@codeaurora.org>
On 10/27/19 8:50 PM, Can Guo wrote:
> Host sends MODE_SENSE_10 with caching mode page, to check if the device
> supports the cache feature.
> Some LLD standards requires DBD field to be set to 1.
Which LLD standard are you referring to? Please mention at least one
name of such a standard in the patch description.
> Change-Id: I0c8752c1888654942d6d7e6e0f6dc197033ac326
Change-IDs should be left out from upstream patches. Does the presence
of this ID mean that this patch has not been verified with checkpatch?
From the checkpatch source code:
# Check for unwanted Gerrit info
if ($in_commit_log && $line =~ /^\s*change-id:/i) {
ERROR("GERRIT_CHANGE_ID",
"Remove Gerrit Change-Id's before submitting upstream.\n"\
. $herecurr);
}
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index aab4ed8..6d8194f 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -2629,6 +2629,7 @@ static int sd_try_rc16_first(struct scsi_device *sdp)
> {
> int len = 0, res;
> struct scsi_device *sdp = sdkp->device;
> + struct Scsi_Host *host = sdp->host;
>
> int dbd;
> int modepage;
> @@ -2660,7 +2661,10 @@ static int sd_try_rc16_first(struct scsi_device *sdp)
> dbd = 8;
> } else {
> modepage = 8;
> - dbd = 0;
> + if (host->set_dbd_for_caching)
> + dbd = 8;
> + else
> + dbd = 0;
> }
>
> /* cautiously ask */
> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> index 2c3f0c5..3900987 100644
> --- a/include/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -650,6 +650,12 @@ struct Scsi_Host {
> unsigned no_scsi2_lun_in_cdb:1;
>
> /*
> + * Set "DBD" field in mode_sense caching mode page in case it is
> + * mandatory by LLD standard.
> + */
> + unsigned set_dbd_for_caching:1;
> +
> + /*
> * Optional work queue to be utilized by the transport
> */
> char work_q_name[20];
Since this patch by itself has no effect, please resubmit this patch
together with the LLD patch that sets set_dbd_for_caching.
Thanks,
Bart.
next prev parent reply other threads:[~2019-10-28 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 3:50 [PATCH v1 0/5] UFS driver general fixes bundle 1 Can Guo
2019-10-28 3:50 ` [PATCH v1 1/5] scsi: Adjust DBD setting in mode sense for caching mode page per LLD Can Guo
2019-10-28 14:58 ` Bart Van Assche [this message]
2019-10-28 15:01 ` Bart Van Assche
2019-10-29 2:14 ` cang
2019-10-28 3:50 ` [PATCH v1 2/5] scsi: ufs: Set DBD setting in mode sense for caching mode page Can Guo
2019-10-28 3:50 ` [PATCH v1 3/5] scsi: ufs: Release clock if DMA map fails Can Guo
2019-10-28 3:50 ` [PATCH v1 4/5] scsi: ufs: Do not clear the DL layer timers Can Guo
2019-10-28 3:50 ` [PATCH v1 5/5] scsi: ufs: Do not free irq in suspend Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ca52845-10ec-3310-83f7-81bdb635ec12@acm.org \
--to=bvanassche@acm.org \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).