From: <balsundar.p@microsemi.com>
To: <linux-scsi@vger.kernel.org>, <jejb@linux.vnet.ibm.com>
Cc: <aacraid@microsemi.com>
Subject: [PATCH 2/7] scsi: aacraid: fixed IO reporting error
Date: Tue, 15 Oct 2019 11:51:59 +0530 [thread overview]
Message-ID: <1571120524-6037-3-git-send-email-balsundar.p@microsemi.com> (raw)
In-Reply-To: <1571120524-6037-1-git-send-email-balsundar.p@microsemi.com>
From: Balsundar P <balsundar.p@microsemi.com>
The problem is the driver detects FastResponse bit set and saves it to
Fib's flags for not to check IO response status, but it never clear it
for next IO. Hence the next IO will pick up FastResponse bit and not
to check the IO response status and fail to report any type IO error
to kernel
Signed-off-by: Balsundar P <balsundar.p@microsemi.com>
---
drivers/scsi/aacraid/commsup.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 2142a649e865..3f268f669cc3 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -232,6 +232,7 @@ struct fib *aac_fib_alloc_tag(struct aac_dev *dev, struct scsi_cmnd *scmd)
fibptr->type = FSAFS_NTC_FIB_CONTEXT;
fibptr->callback_data = NULL;
fibptr->callback = NULL;
+ fibptr->flags = 0;
return fibptr;
}
--
2.18.1
next prev parent reply other threads:[~2019-10-15 6:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 6:21 [PATCH 0/7] scsi: aacraid updates balsundar.p
2019-10-15 6:21 ` [PATCH 1/7] scsi: aacraid: fix illegal IO beyond last LBA balsundar.p
2019-10-15 6:21 ` balsundar.p [this message]
2019-10-15 6:22 ` [PATCH 3/7] scsi: aacraid: fixed firmware assert issue balsundar.p
2019-10-15 6:22 ` [PATCH 4/7] scsi: aacraid: setting different timeout for src and thor balsundar.p
2019-10-15 6:22 ` [PATCH 5/7] scsi: aacraid: check adapter health balsundar.p
2019-10-15 6:22 ` [PATCH 6/7] scsi: aacraid: send AIF request post IOP RESET balsundar.p
2019-10-15 18:58 ` kbuild test robot
2019-10-15 18:58 ` [RFC PATCH] scsi: aacraid: aac_schedule_bus_scan() can be static kbuild test robot
2019-10-18 7:26 ` Balsundar.P
2019-10-15 6:22 ` [PATCH 7/7] scsi: aacraid: bump version balsundar.p
2019-10-18 23:35 ` [PATCH 0/7] scsi: aacraid updates Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571120524-6037-3-git-send-email-balsundar.p@microsemi.com \
--to=balsundar.p@microsemi.com \
--cc=aacraid@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).