From: Stanley Chu <stanley.chu@mediatek.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <andy.teng@mediatek.com>,
<jejb@linux.ibm.com>, <chun-hung.wu@mediatek.com>,
<kuohong.wang@mediatek.com>, <linux-kernel@vger.kernel.org>,
<avri.altman@wdc.com>, <cang@codeaurora.org>,
<linux-mediatek@lists.infradead.org>, <peter.wang@mediatek.com>,
<alim.akhtar@samsung.com>, <matthias.bgg@gmail.com>,
<asutoshd@codeaurora.org>, <bvanassche@acm.org>,
<linux-arm-kernel@lists.infradead.org>, <beanhuo@micron.com>
Subject: Re: [PATCH v2 1/2] scsi: ufs: pass device information to apply_dev_quirks
Date: Fri, 10 Jan 2020 15:08:41 +0800 [thread overview]
Message-ID: <1578640121.17435.7.camel@mtkswgap22> (raw)
In-Reply-To: <yq136cnx1yo.fsf@oracle.com>
Hi Martin,
On Fri, 2020-01-10 at 01:25 -0500, Martin K. Petersen wrote:
> Stanley,
>
> > Pass UFS device information to vendor-specific variant callback
> > "apply_dev_quirks" because some platform vendors need to know such
> > information to apply special handlings or quirks in specific devices.
>
> This doesn't compile. You missed adding the additional argument to one
> caller of ufshcd_tune_unipro_params().
>
Sorry for this. I'll fix it in next version and try to separate vendor's
implementation and common driver to different commits if this is the
root cause of compile issue.
Thanks.
Stanley
next prev parent reply other threads:[~2020-01-10 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 0:27 [PATCH v2 0/2] scsi: ufs: pass device information to apply_dev_quirks Stanley Chu
2020-01-06 0:27 ` [PATCH v2 1/2] " Stanley Chu
2020-01-06 17:45 ` asutoshd
2020-01-06 20:21 ` Avri Altman
2020-01-07 8:21 ` [EXT] " Bean Huo (beanhuo)
2020-01-10 6:25 ` Martin K. Petersen
2020-01-10 7:08 ` Stanley Chu [this message]
2020-01-06 0:27 ` [PATCH v2 2/2] scsi: ufs-mediatek: add apply_dev_quirks variant operation Stanley Chu
2020-01-07 9:16 ` [EXT] " Bean Huo (beanhuo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1578640121.17435.7.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).