* [PATCH] scsi: core: fix a typo of coding format
@ 2020-02-15 8:58 qiwuchen55
2020-02-15 21:15 ` Finn Thain
0 siblings, 1 reply; 2+ messages in thread
From: qiwuchen55 @ 2020-02-15 8:58 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-scsi, chenqiwu
From: chenqiwu <chenqiwu@xiaomi.com>
Fix a typo of coding format.
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 610ee41..a89cfaf 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1563,7 +1563,7 @@ static int scsi_dispatch_cmd(struct scsi_cmnd *cmd)
}
return rtn;
- done:
+done:
cmd->scsi_done(cmd);
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: core: fix a typo of coding format
2020-02-15 8:58 [PATCH] scsi: core: fix a typo of coding format qiwuchen55
@ 2020-02-15 21:15 ` Finn Thain
0 siblings, 0 replies; 2+ messages in thread
From: Finn Thain @ 2020-02-15 21:15 UTC (permalink / raw)
To: qiwuchen55; +Cc: jejb, martin.petersen, linux-scsi, chenqiwu
On Sat, 15 Feb 2020, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
>
> Fix a typo of coding format.
>
It isn't a 'typo' as it appears to be a deliberate choice.
git grep '^ [a-z_0-9]+:$' -- drivers/scsi/
I can't find anything in Documentation/process that bans indentation of
goto labels. Am I missing something? What do you gain?
If there's nothing in the style guide to mandate churn like this patch,
then we might expect more churn when someone else patches the whitespace
back in (for consistency, taste, fame and fortune, whatever).
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 610ee41..a89cfaf 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1563,7 +1563,7 @@ static int scsi_dispatch_cmd(struct scsi_cmnd *cmd)
> }
>
> return rtn;
> - done:
> +done:
> cmd->scsi_done(cmd);
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-15 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-15 8:58 [PATCH] scsi: core: fix a typo of coding format qiwuchen55
2020-02-15 21:15 ` Finn Thain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).