From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Bodo Stroesser <bstroesser@ts.fujitsu.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Mike Christie <mchristi@redhat.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()
Date: Tue, 26 May 2020 22:12:55 -0400 [thread overview]
Message-ID: <159054550934.12032.1754394879666854643.b4-ty@oracle.com> (raw)
In-Reply-To: <20200523101129.GB98132@mwanda>
On Sat, 23 May 2020 13:11:29 +0300, Dan Carpenter wrote:
> The pr_debug() dereferences "cmd" after we already freed it by calling
> tcmu_free_cmd(cmd). The debug printk needs to be done earlier.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()
https://git.kernel.org/mkp/scsi/c/9d7464b18892
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-05-27 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 10:11 [PATCH] scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd() Dan Carpenter
2020-05-23 13:03 ` David Disseldorp
2020-05-23 19:04 ` Mike Christie
2020-05-25 9:11 ` Bodo Stroesser
2020-05-26 12:26 ` Dan Carpenter
2020-05-27 2:12 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159054550934.12032.1754394879666854643.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bstroesser@ts.fujitsu.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).