From: Can Guo <cang@codeaurora.org>
To: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
hongwus@codeaurora.org, rnayak@codeaurora.org,
linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, salyzyn@google.com, cang@codeaurora.org
Cc: Stanley Chu <stanley.chu@mediatek.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bean Huo <beanhuo@micron.com>,
Bart Van Assche <bvanassche@acm.org>,
James Bottomley <JBottomley@Parallels.com>,
Santosh Y <santoshsy@gmail.com>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Dolev Raviv <draviv@codeaurora.org>,
linux-kernel@vger.kernel.org (open list),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Mediatek SoC support),
linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
SoC support)
Subject: [PATCH 9/9] scsi: ufs: Properly release resources if a task is aborted successfully
Date: Sun, 9 Aug 2020 05:15:55 -0700 [thread overview]
Message-ID: <1596975355-39813-10-git-send-email-cang@codeaurora.org> (raw)
In-Reply-To: <1596975355-39813-1-git-send-email-cang@codeaurora.org>
In current UFS task abort hook, namely ufshcd_abort(), if one task is
aborted successfully, clk_gating.active_reqs held by this task is not
decreased, which makes clk_gating.active_reqs stay above zero forever,
thus clock gating would never happen. Instead of releasing resources of
one task "manually", use the existing func __ufshcd_transfer_req_compl().
This change can also eliminate possible racing of scsi_dma_unmap() from
the real completion in IRQ handler path.
Fixes: 5a0b0cb9bee76 ("ufs: Add support for clock gating")
Signed-off-by: Can Guo <cang@codeaurora.org>
CC: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9ebb5cd..efb40b1 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6636,11 +6636,8 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
goto out;
}
- scsi_dma_unmap(cmd);
-
spin_lock_irqsave(host->host_lock, flags);
- ufshcd_outstanding_req_clear(hba, tag);
- hba->lrb[tag].cmd = NULL;
+ __ufshcd_transfer_req_compl(hba, (1UL << tag));
spin_unlock_irqrestore(host->host_lock, flags);
out:
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-08-09 12:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 12:15 [PATCH v11 0/9] Fix up and simplify error recovery mechanism Can Guo
2020-08-09 12:15 ` [PATCH 1/9] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-08-09 12:15 ` [PATCH 2/9] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config Can Guo
2020-08-09 12:15 ` [PATCH 3/9] scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs Can Guo
2020-08-09 12:15 ` [PATCH 4/9] scsi: ufs: Add some debug infos to ufshcd_print_host_state Can Guo
2020-08-09 12:15 ` [PATCH 5/9] scsi: ufs: Fix concurrency of error handler and other error recovery paths Can Guo
2020-08-09 12:15 ` [PATCH 6/9] scsi: ufs: Recover hba runtime PM error in error handler Can Guo
2020-08-09 12:15 ` [PATCH 7/9] scsi: ufs: Move dumps in IRQ handler to " Can Guo
2020-08-09 12:15 ` [PATCH 8/9] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops Can Guo
2020-08-09 12:15 ` Can Guo [this message]
2020-08-13 2:26 ` [PATCH v11 0/9] Fix up and simplify error recovery mechanism Martin K. Petersen
2020-08-14 6:32 ` Can Guo
2020-08-18 3:11 ` Martin K. Petersen
[not found] <a752927b-dd9b-ebf0-8c77-e2ae0b2aa475@web.de>
2020-08-07 13:01 ` [PATCH 9/9] scsi: ufs: Properly release resources if a task is aborted successfully Can Guo
-- strict thread matches above, loose matches on Subject: below --
2020-08-06 5:06 [PATCH v10 0/9] Fix up and simplify error recovery mechanism Can Guo
2020-08-06 5:06 ` [PATCH 9/9] scsi: ufs: Properly release resources if a task is aborted successfully Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596975355-39813-10-git-send-email-cang@codeaurora.org \
--to=cang@codeaurora.org \
--cc=JBottomley@Parallels.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=draviv@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=santoshsy@gmail.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=sthumma@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).