From: Stanley Chu <stanley.chu@mediatek.com>
To: Can Guo <cang@codeaurora.org>
Cc: <asutoshd@codeaurora.org>, <nguyenb@codeaurora.org>,
<hongwus@codeaurora.org>, <rnayak@codeaurora.org>,
<linux-scsi@vger.kernel.org>, <kernel-team@android.com>,
<saravanak@google.com>, <salyzyn@google.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bean Huo <beanhuo@micron.com>,
"Bart Van Assche" <bvanassche@acm.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] scsi: ufs: Abort tasks before clear them from doorbell
Date: Thu, 27 Aug 2020 16:37:25 +0800 [thread overview]
Message-ID: <1598517445.10649.20.camel@mtkswgap22> (raw)
In-Reply-To: <1598321228-21093-2-git-send-email-cang@codeaurora.org>
On Mon, 2020-08-24 at 19:07 -0700, Can Guo wrote:
> To recovery non-fatal errors, no full reset is required, err_handler only
> clears those pending TRs/TMRs so that scsi layer can re-issue them. In
> current err_handler, TRs are directly cleared from UFS host's doorbell but
> not aborted from device side. However, according to the UFSHCI JEDEC spec,
> the host software shall use UTP Transfer Request List CLear Register to
> clear a task from UFS host's doorbell only when a UTP Transfer Request is
> expected to not be completed, e.g. when the host software receives a
> “FUNCTION COMPLETE” Task Management response which means a Transfer Request
> was aborted. To follow the UFSHCI JEDEC spec, in err_handler, aborts one TR
> before clearing it from doorbell.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
Acked-by: Stanley Chu <stanley.chu@mediatek.com>
next prev parent reply other threads:[~2020-08-27 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 2:07 [RESEND PATCH v1 0/2] Add UFS LINERESET handling Can Guo
2020-08-25 2:07 ` [PATCH v1 1/2] scsi: ufs: Abort tasks before clear them from doorbell Can Guo
2020-08-27 8:37 ` Stanley Chu [this message]
2020-08-30 18:11 ` Bean Huo
2020-08-31 1:20 ` Can Guo
2020-08-31 19:38 ` Bean Huo
2020-08-25 2:07 ` [PATCH v1 2/2] scsi: ufs: Handle LINERESET indication in err handler Can Guo
2020-09-09 2:09 ` [RESEND PATCH v1 0/2] Add UFS LINERESET handling Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2020-08-24 9:39 [PATCH " Can Guo
2020-08-24 9:39 ` [PATCH v1 1/2] scsi: ufs: Abort tasks before clear them from doorbell Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598517445.10649.20.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).