From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D5CC433E7 for ; Mon, 31 Aug 2020 17:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E765520EDD for ; Mon, 31 Aug 2020 17:42:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="TE+jiR8n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728973AbgHaRlo (ORCPT ); Mon, 31 Aug 2020 13:41:44 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34508 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728355AbgHaRlk (ORCPT ); Mon, 31 Aug 2020 13:41:40 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07VHUJ7s143509; Mon, 31 Aug 2020 17:41:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=RVnmFD6orkPvTZtPwJhxt8TKnA6KRF3uENyhRnqkUXc=; b=TE+jiR8n9mKB71qo9+YnW939zwSpqxNcyzzZs916rVnbcQYn33vsYt7hR1s2c1ZsYSIs +Lg7ZaOIFxD6AMqc1D+RNeegBblkSrOsUIeC6Zia+tZQTwdEY0hX2dddUfFIfjIL5RRa DVqCQLLWUKwO5FNSnZV8mikQMqFSJSrAq+vtMZhzcuyK2Eid7jC7U91MYN6hHS1H/MBk VoFl2a5NCYLkdWySRxsa6POmyYm8dp3x5ts3ajwm1jrp48dCLKnPM1qpsGKmwj1oNI3C clsqdvuAG2PhM+WHakRjEfqTun6hWFl5xdCNNVysSOVVUpfrIcMdmq5hl9gc7DsSG7wp Cw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 337eykyjgc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 31 Aug 2020 17:41:26 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07VHf8Af078387; Mon, 31 Aug 2020 17:41:25 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 3380kkyns2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 17:41:25 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07VHfO6I007586; Mon, 31 Aug 2020 17:41:24 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Aug 2020 10:41:24 -0700 From: "Martin K. Petersen" To: jejb@linux.ibm.com, himanshu.madhani@cavium.com, njavali@marvell.com, quinn.tran@cavium.com, Tianjia Zhang Cc: "Martin K . Petersen" , GR-QLogic-Storage-Upstream@marvell.com, linux-scsi@vger.kernel.org, tianjia.zhang@alibaba.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba() Date: Mon, 31 Aug 2020 13:41:10 -0400 Message-Id: <159889566024.22322.13846492309208232188.b4-ty@oracle.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200802111530.5020-1-tianjia.zhang@linux.alibaba.com> References: <20200802111530.5020-1-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9730 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 mlxlogscore=974 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310105 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9730 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 priorityscore=1501 phishscore=0 mlxlogscore=987 mlxscore=0 lowpriorityscore=0 clxscore=1011 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310104 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Sun, 2 Aug 2020 19:15:30 +0800, Tianjia Zhang wrote: > On an error exit path, a negative error code should be returned > instead of a positive return value. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba() https://git.kernel.org/mkp/scsi/c/ca4fb89a3d71 -- Martin K. Petersen Oracle Linux Engineering