From: Bart Van Assche <bvanassche@acm.org>
To: Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com,
pedrom.sousa@synopsys.com, sthumma@codeaurora.org,
jejb@linux.ibm.com
Cc: linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com,
evgreen@chromium.org, beanhuo@micron.com,
marc.w.gonzalez@free.fr, subhashj@codeaurora.org,
vivek.gautam@codeaurora.org, kuohong.wang@mediatek.com,
peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
andy.teng@mediatek.com
Subject: Re: [PATCH v2 3/3] scsi: ufs-mediatek: enable auto suspend capability
Date: Thu, 12 Sep 2019 14:46:15 +0100 [thread overview]
Message-ID: <160452c7-c53c-155c-49a9-4365166032a8@acm.org> (raw)
In-Reply-To: <1568270135-32442-4-git-send-email-stanley.chu@mediatek.com>
On 9/12/19 7:35 AM, Stanley Chu wrote:
> Enable auto suspend capability in MediaTek UFS driver.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> Reviewed-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 0f6ff33ce52e..b7b177c6194c 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -117,6 +117,11 @@ static int ufs_mtk_setup_clocks(struct ufs_hba *hba, bool on,
> return ret;
> }
>
> +static void ufs_mtk_set_caps(struct ufs_hba *hba)
> +{
> + hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND;
> +}
> +
> /**
> * ufs_mtk_init - find other essential mmio bases
> * @hba: host controller instance
> @@ -147,6 +152,8 @@ static int ufs_mtk_init(struct ufs_hba *hba)
> if (err)
> goto out_variant_clear;
>
> + ufs_mtk_set_caps(hba);
> +
> /*
> * ufshcd_vops_init() is invoked after
> * ufshcd_setup_clock(true) in ufshcd_hba_init() thus
Please inline the ufs_mtk_set_caps() function. Introducing single line
functions like is done in this patch doesn't improve readability.
Thanks,
Bart.
next prev parent reply other threads:[~2019-09-12 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 6:35 [PATCH v2] scsi: allow auto suspend override by low-level driver Stanley Chu
2019-09-12 6:35 ` [PATCH v2 1/3] scsi: core: " Stanley Chu
2019-09-12 13:43 ` Bart Van Assche
2019-09-16 6:38 ` Stanley Chu
2019-09-12 6:35 ` [PATCH v2 2/3] scsi: ufs: override auto suspend tunables for ufs Stanley Chu
2019-09-12 6:35 ` [PATCH v2 3/3] scsi: ufs-mediatek: enable auto suspend capability Stanley Chu
2019-09-12 13:46 ` Bart Van Assche [this message]
2019-09-16 6:29 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160452c7-c53c-155c-49a9-4365166032a8@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=chun-hung.wu@mediatek.com \
--cc=evgreen@chromium.org \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=pedrom.sousa@synopsys.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=sthumma@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).