linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <satishkh@cisco.com>, <sebaddel@cisco.com>, <kartilak@cisco.com>,
	<jejb@linux.ibm.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<hare@suse.de>, <hch@lst.de>, <bvanassche@acm.org>,
	John Garry <john.garry@huawei.com>
Subject: [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag
Date: Fri, 13 Aug 2021 21:49:12 +0800	[thread overview]
Message-ID: <1628862553-179450-3-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1628862553-179450-1-git-send-email-john.garry@huawei.com>

It is never read. Setting it and the request tag seems dodgy
anyway.

Signed-off-by: John Garry <john.garry@huawei.com>
---
 drivers/scsi/fnic/fnic_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 0f9cedf78872..f8afbfb468dc 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -2213,7 +2213,7 @@ fnic_scsi_host_start_tag(struct fnic *fnic, struct scsi_cmnd *sc)
 	if (IS_ERR(dummy))
 		return SCSI_NO_TAG;
 
-	sc->tag = rq->tag = dummy->tag;
+	rq->tag = dummy->tag;
 	sc->host_scribble = (unsigned char *)dummy;
 
 	return dummy->tag;
-- 
2.26.2


  parent reply	other threads:[~2021-08-13 13:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 13:49 [PATCH 0/3] Remove scsi_cmnd.tag John Garry
2021-08-13 13:49 ` [PATCH 1/3] scsi: wd719: Stop using scsi_cmnd.tag John Garry
2021-08-13 16:30   ` Hannes Reinecke
2021-08-14  3:11   ` Bart Van Assche
2021-08-13 13:49 ` John Garry [this message]
2021-08-13 16:31   ` [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag Hannes Reinecke
2021-08-14  3:17   ` Bart Van Assche
2021-08-14  7:39     ` Christoph Hellwig
2021-08-14 12:35       ` Hannes Reinecke
2021-08-16 10:00         ` John Garry
2021-08-16 11:11           ` Hannes Reinecke
2021-08-13 13:49 ` [PATCH 3/3] scsi: Remove scsi_cmnd.tag John Garry
2021-08-13 16:31   ` Hannes Reinecke
2021-08-14  3:18   ` Bart Van Assche
2021-08-14  7:40 ` [PATCH 0/3] " Christoph Hellwig
2021-08-16 17:34 ` Martin K. Petersen
2021-08-18 18:08   ` John Garry
2021-08-18 18:46     ` Martin K. Petersen
2021-08-19  2:41     ` Bart Van Assche
2021-08-19  7:15       ` Hannes Reinecke
2021-08-19  7:27         ` John Garry
2021-08-19  7:50           ` Hannes Reinecke
2021-08-19  9:09             ` John Garry
2021-08-24  4:03 ` Martin K. Petersen
2021-08-24  7:54   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1628862553-179450-3-git-send-email-john.garry@huawei.com \
    --to=john.garry@huawei.com \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=kartilak@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=satishkh@cisco.com \
    --cc=sebaddel@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).