From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Ming Lei <ming.lei@redhat.com>,
linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
Bart Van Assche <bvanassche@acm.org>,
Avri Altman <avri.altman@wdc.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
Can Guo <cang@codeaurora.org>, Jens Axboe <axboe@kernel.dk>,
Asutosh Das <asutoshd@codeaurora.org>,
Bean Huo <beanhuo@micron.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] scsi: ufs: Fix task management completion
Date: Tue, 5 Oct 2021 00:32:59 -0400 [thread overview]
Message-ID: <163340836500.12017.3755166310975946882.b4-ty@oracle.com> (raw)
In-Reply-To: <20210922091059.4040-1-adrian.hunter@intel.com>
On Wed, 22 Sep 2021 12:10:59 +0300, Adrian Hunter wrote:
> The UFS driver uses blk_mq_tagset_busy_iter() when identifying task
> management requests to complete, however blk_mq_tagset_busy_iter()
> doesn't work.
>
> blk_mq_tagset_busy_iter() only iterates requests dispatched by the block
> layer. That appears as if it might have started since commit 37f4a24c2469a1
> ("blk-mq: centralise related handling into blk_mq_get_driver_tag") which
> removed 'data->hctx->tags->rqs[rq->tag] = rq' from blk_mq_rq_ctx_init()
> which gets called:
>
> [...]
Applied to 5.15/scsi-fixes, thanks!
[1/1] scsi: ufs: Fix task management completion
https://git.kernel.org/mkp/scsi/c/f5ef336fd2e4
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-10-05 4:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 9:10 [PATCH] scsi: ufs: Fix task management completion Adrian Hunter
2021-09-22 20:48 ` Bart Van Assche
2021-09-23 5:44 ` Adrian Hunter
2021-10-04 17:08 ` Bart Van Assche
2021-10-05 4:32 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163340836500.12017.3755166310975946882.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).