* [PATCH] scsi: mpt3sas: Remove flush_scheduled_work() call.
@ 2022-06-09 13:26 Tetsuo Handa
2022-06-28 3:24 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Tetsuo Handa @ 2022-06-09 13:26 UTC (permalink / raw)
To: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen
Cc: MPT-FusionLinux.pdl, linux-scsi
It seems to me that mpt3sas driver is using dedicated workqueues and
is not calling schedule{,_delayed}_work{,_on}(). Then, there will be
no work to flush using flush_scheduled_work().
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
Please see commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue()
using a macro") for background.
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index b519f4b59d30..9ee27add839a 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -12409,7 +12409,6 @@ scsih_suspend(struct device *dev)
return rc;
mpt3sas_base_stop_watchdog(ioc);
- flush_scheduled_work();
scsi_block_requests(shost);
_scsih_nvme_shutdown(ioc);
ioc_info(ioc, "pdev=0x%p, slot=%s, entering operating state\n",
--
2.18.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: mpt3sas: Remove flush_scheduled_work() call.
2022-06-09 13:26 [PATCH] scsi: mpt3sas: Remove flush_scheduled_work() call Tetsuo Handa
@ 2022-06-28 3:24 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-06-28 3:24 UTC (permalink / raw)
To: Sathya Prakash, Sreekanth Reddy, Tetsuo Handa,
James E.J. Bottomley, Suganath Prabu Subramani
Cc: Martin K . Petersen, MPT-FusionLinux.pdl, linux-scsi
On Thu, 9 Jun 2022 22:26:48 +0900, Tetsuo Handa wrote:
> It seems to me that mpt3sas driver is using dedicated workqueues and
> is not calling schedule{,_delayed}_work{,_on}(). Then, there will be
> no work to flush using flush_scheduled_work().
>
>
Applied to 5.20/scsi-queue, thanks!
[1/1] scsi: mpt3sas: Remove flush_scheduled_work() call.
https://git.kernel.org/mkp/scsi/c/90c3ca3f247d
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 3:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 13:26 [PATCH] scsi: mpt3sas: Remove flush_scheduled_work() call Tetsuo Handa
2022-06-28 3:24 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).