* [PATCH] scsi: libfc: remove redundant variable ev_qual
@ 2022-11-11 17:08 Colin Ian King
2022-11-17 18:14 ` Martin K. Petersen
2022-11-26 3:27 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-11-11 17:08 UTC (permalink / raw)
To: Hannes Reinecke, James E . J . Bottomley, Martin K . Petersen,
linux-scsi
Cc: kernel-janitors, linux-kernel
Variable ev_qual is being assigned and modified but the end result
is never used. The variable is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/scsi/libfc/fc_disc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
index 942fc60f7c21..0f32ded246d0 100644
--- a/drivers/scsi/libfc/fc_disc.c
+++ b/drivers/scsi/libfc/fc_disc.c
@@ -75,7 +75,6 @@ static void fc_disc_recv_rscn_req(struct fc_disc *disc, struct fc_frame *fp)
struct fc_seq_els_data rjt_data;
unsigned int len;
int redisc = 0;
- enum fc_els_rscn_ev_qual ev_qual;
enum fc_els_rscn_addr_fmt fmt;
LIST_HEAD(disc_ports);
struct fc_disc_port *dp, *next;
@@ -107,8 +106,6 @@ static void fc_disc_recv_rscn_req(struct fc_disc *disc, struct fc_frame *fp)
goto reject;
for (pp = (void *)(rp + 1); len > 0; len -= sizeof(*pp), pp++) {
- ev_qual = pp->rscn_page_flags >> ELS_RSCN_EV_QUAL_BIT;
- ev_qual &= ELS_RSCN_EV_QUAL_MASK;
fmt = pp->rscn_page_flags >> ELS_RSCN_ADDR_FMT_BIT;
fmt &= ELS_RSCN_ADDR_FMT_MASK;
/*
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libfc: remove redundant variable ev_qual
2022-11-11 17:08 [PATCH] scsi: libfc: remove redundant variable ev_qual Colin Ian King
@ 2022-11-17 18:14 ` Martin K. Petersen
2022-11-26 3:27 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-11-17 18:14 UTC (permalink / raw)
To: Colin Ian King
Cc: Hannes Reinecke, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> Variable ev_qual is being assigned and modified but the end result is
> never used. The variable is redundant and can be removed.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libfc: remove redundant variable ev_qual
2022-11-11 17:08 [PATCH] scsi: libfc: remove redundant variable ev_qual Colin Ian King
2022-11-17 18:14 ` Martin K. Petersen
@ 2022-11-26 3:27 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-11-26 3:27 UTC (permalink / raw)
To: Hannes Reinecke, James E . J . Bottomley, linux-scsi, Colin Ian King
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Fri, 11 Nov 2022 17:08:24 +0000, Colin Ian King wrote:
> Variable ev_qual is being assigned and modified but the end result
> is never used. The variable is redundant and can be removed.
>
>
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: libfc: remove redundant variable ev_qual
https://git.kernel.org/mkp/scsi/c/0824050682ae
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-26 3:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 17:08 [PATCH] scsi: libfc: remove redundant variable ev_qual Colin Ian King
2022-11-17 18:14 ` Martin K. Petersen
2022-11-26 3:27 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).